Source file src/crypto/x509/x509_test.go

     1  // Copyright 2009 The Go Authors. All rights reserved.
     2  // Use of this source code is governed by a BSD-style
     3  // license that can be found in the LICENSE file.
     4  
     5  package x509
     6  
     7  import (
     8  	"bytes"
     9  	"crypto"
    10  	"crypto/dsa"
    11  	"crypto/ecdh"
    12  	"crypto/ecdsa"
    13  	"crypto/ed25519"
    14  	"crypto/elliptic"
    15  	"crypto/rand"
    16  	"crypto/rsa"
    17  	_ "crypto/sha256"
    18  	_ "crypto/sha512"
    19  	"crypto/x509/pkix"
    20  	"encoding/asn1"
    21  	"encoding/base64"
    22  	"encoding/gob"
    23  	"encoding/hex"
    24  	"encoding/pem"
    25  	"errors"
    26  	"fmt"
    27  	"internal/testenv"
    28  	"io"
    29  	"math"
    30  	"math/big"
    31  	"net"
    32  	"net/url"
    33  	"reflect"
    34  	"runtime"
    35  	"slices"
    36  	"strings"
    37  	"testing"
    38  	"time"
    39  )
    40  
    41  func TestParsePKCS1PrivateKey(t *testing.T) {
    42  	block, _ := pem.Decode([]byte(pemPrivateKey))
    43  	priv, err := ParsePKCS1PrivateKey(block.Bytes)
    44  	if err != nil {
    45  		t.Errorf("Failed to parse private key: %s", err)
    46  		return
    47  	}
    48  	if priv.PublicKey.N.Cmp(rsaPrivateKey.PublicKey.N) != 0 ||
    49  		priv.PublicKey.E != rsaPrivateKey.PublicKey.E ||
    50  		priv.D.Cmp(rsaPrivateKey.D) != 0 ||
    51  		priv.Primes[0].Cmp(rsaPrivateKey.Primes[0]) != 0 ||
    52  		priv.Primes[1].Cmp(rsaPrivateKey.Primes[1]) != 0 {
    53  		t.Errorf("got:%+v want:%+v", priv, rsaPrivateKey)
    54  	}
    55  
    56  	// This private key includes an invalid prime that
    57  	// rsa.PrivateKey.Validate should reject.
    58  	data := []byte("0\x16\x02\x00\x02\x02\u007f\x00\x02\x0200\x02\x0200\x02\x02\x00\x01\x02\x02\u007f\x00")
    59  	if _, err := ParsePKCS1PrivateKey(data); err == nil {
    60  		t.Errorf("parsing invalid private key did not result in an error")
    61  	}
    62  
    63  	// A partial key without CRT values should still parse.
    64  	b, _ := asn1.Marshal(struct {
    65  		Version int
    66  		N       *big.Int
    67  		E       int
    68  		D       *big.Int
    69  		P       *big.Int
    70  		Q       *big.Int
    71  	}{
    72  		N: priv.N,
    73  		E: priv.PublicKey.E,
    74  		D: priv.D,
    75  		P: priv.Primes[0],
    76  		Q: priv.Primes[1],
    77  	})
    78  	p2, err := ParsePKCS1PrivateKey(b)
    79  	if err != nil {
    80  		t.Fatalf("parsing partial private key resulted in an error: %v", err)
    81  	}
    82  	if !p2.Equal(priv) {
    83  		t.Errorf("partial private key did not match original key")
    84  	}
    85  	if p2.Precomputed.Dp == nil || p2.Precomputed.Dq == nil || p2.Precomputed.Qinv == nil {
    86  		t.Errorf("precomputed values not recomputed")
    87  	}
    88  }
    89  
    90  func TestPKCS1MismatchPublicKeyFormat(t *testing.T) {
    91  
    92  	const pkixPublicKey = "30820122300d06092a864886f70d01010105000382010f003082010a0282010100dd5a0f37d3ca5232852ccc0e81eebec270e2f2c6c44c6231d852971a0aad00aa7399e9b9de444611083c59ea919a9d76c20a7be131a99045ec19a7bb452d647a72429e66b87e28be9e8187ed1d2a2a01ef3eb2360706bd873b07f2d1f1a72337aab5ec94e983e39107f52c480d404915e84d75a3db2cfd601726a128cb1d7f11492d4bdb53272e652276667220795c709b8a9b4af6489cbf48bb8173b8fb607c834a71b6e8bf2d6aab82af3c8ad7ce16d8dcf58373a6edc427f7484d09744d4c08f4e19ed07adbf6cb31243bc5d0d1145e77a08a6fc5efd208eca67d6abf2d6f38f58b6fdd7c28774fb0cc03fc4935c6e074842d2e1479d3d8787249258719f90203010001"
    93  	const errorContains = "use ParsePKIXPublicKey instead"
    94  	derBytes, _ := hex.DecodeString(pkixPublicKey)
    95  	_, err := ParsePKCS1PublicKey(derBytes)
    96  	if !strings.Contains(err.Error(), errorContains) {
    97  		t.Errorf("expected error containing %q, got %s", errorContains, err)
    98  	}
    99  }
   100  
   101  func TestMarshalInvalidPublicKey(t *testing.T) {
   102  	_, err := MarshalPKIXPublicKey(&ecdsa.PublicKey{})
   103  	if err == nil {
   104  		t.Errorf("expected error, got MarshalPKIXPublicKey success")
   105  	}
   106  	_, err = MarshalPKIXPublicKey(&ecdsa.PublicKey{
   107  		Curve: elliptic.P256(),
   108  		X:     big.NewInt(1), Y: big.NewInt(2),
   109  	})
   110  	if err == nil {
   111  		t.Errorf("expected error, got MarshalPKIXPublicKey success")
   112  	}
   113  }
   114  
   115  func testParsePKIXPublicKey(t *testing.T, pemBytes string) (pub any) {
   116  	block, _ := pem.Decode([]byte(pemBytes))
   117  	pub, err := ParsePKIXPublicKey(block.Bytes)
   118  	if err != nil {
   119  		t.Fatalf("Failed to parse public key: %s", err)
   120  	}
   121  
   122  	pubBytes2, err := MarshalPKIXPublicKey(pub)
   123  	if err != nil {
   124  		t.Errorf("Failed to marshal public key for the second time: %s", err)
   125  		return
   126  	}
   127  	if !bytes.Equal(pubBytes2, block.Bytes) {
   128  		t.Errorf("Reserialization of public key didn't match. got %x, want %x", pubBytes2, block.Bytes)
   129  	}
   130  	return
   131  }
   132  
   133  func TestParsePKIXPublicKey(t *testing.T) {
   134  	t.Run("RSA", func(t *testing.T) {
   135  		pub := testParsePKIXPublicKey(t, pemPublicKey)
   136  		_, ok := pub.(*rsa.PublicKey)
   137  		if !ok {
   138  			t.Errorf("Value returned from ParsePKIXPublicKey was not an RSA public key")
   139  		}
   140  	})
   141  	t.Run("Ed25519", func(t *testing.T) {
   142  		pub := testParsePKIXPublicKey(t, pemEd25519Key)
   143  		_, ok := pub.(ed25519.PublicKey)
   144  		if !ok {
   145  			t.Errorf("Value returned from ParsePKIXPublicKey was not an Ed25519 public key")
   146  		}
   147  	})
   148  	t.Run("X25519", func(t *testing.T) {
   149  		pub := testParsePKIXPublicKey(t, pemX25519Key)
   150  		k, ok := pub.(*ecdh.PublicKey)
   151  		if !ok || k.Curve() != ecdh.X25519() {
   152  			t.Errorf("Value returned from ParsePKIXPublicKey was not an X25519 public key")
   153  		}
   154  	})
   155  }
   156  
   157  var pemPublicKey = `-----BEGIN PUBLIC KEY-----
   158  MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA3VoPN9PKUjKFLMwOge6+
   159  wnDi8sbETGIx2FKXGgqtAKpzmem53kRGEQg8WeqRmp12wgp74TGpkEXsGae7RS1k
   160  enJCnma4fii+noGH7R0qKgHvPrI2Bwa9hzsH8tHxpyM3qrXslOmD45EH9SxIDUBJ
   161  FehNdaPbLP1gFyahKMsdfxFJLUvbUycuZSJ2ZnIgeVxwm4qbSvZInL9Iu4FzuPtg
   162  fINKcbbovy1qq4KvPIrXzhbY3PWDc6btxCf3SE0JdE1MCPThntB62/bLMSQ7xdDR
   163  FF53oIpvxe/SCOymfWq/LW849Ytv3Xwod0+wzAP8STXG4HSELS4UedPYeHJJJYcZ
   164  +QIDAQAB
   165  -----END PUBLIC KEY-----
   166  `
   167  
   168  var pemPrivateKey = testingKey(`
   169  -----BEGIN RSA TESTING KEY-----
   170  MIICXAIBAAKBgQCxoeCUW5KJxNPxMp+KmCxKLc1Zv9Ny+4CFqcUXVUYH69L3mQ7v
   171  IWrJ9GBfcaA7BPQqUlWxWM+OCEQZH1EZNIuqRMNQVuIGCbz5UQ8w6tS0gcgdeGX7
   172  J7jgCQ4RK3F/PuCM38QBLaHx988qG8NMc6VKErBjctCXFHQt14lerd5KpQIDAQAB
   173  AoGAYrf6Hbk+mT5AI33k2Jt1kcweodBP7UkExkPxeuQzRVe0KVJw0EkcFhywKpr1
   174  V5eLMrILWcJnpyHE5slWwtFHBG6a5fLaNtsBBtcAIfqTQ0Vfj5c6SzVaJv0Z5rOd
   175  7gQF6isy3t3w9IF3We9wXQKzT6q5ypPGdm6fciKQ8RnzREkCQQDZwppKATqQ41/R
   176  vhSj90fFifrGE6aVKC1hgSpxGQa4oIdsYYHwMzyhBmWW9Xv/R+fPyr8ZwPxp2c12
   177  33QwOLPLAkEA0NNUb+z4ebVVHyvSwF5jhfJxigim+s49KuzJ1+A2RaSApGyBZiwS
   178  rWvWkB471POAKUYt5ykIWVZ83zcceQiNTwJBAMJUFQZX5GDqWFc/zwGoKkeR49Yi
   179  MTXIvf7Wmv6E++eFcnT461FlGAUHRV+bQQXGsItR/opIG7mGogIkVXa3E1MCQARX
   180  AAA7eoZ9AEHflUeuLn9QJI/r0hyQQLEtrpwv6rDT1GCWaLII5HJ6NUFVf4TTcqxo
   181  6vdM4QGKTJoO+SaCyP0CQFdpcxSAuzpFcKv0IlJ8XzS/cy+mweCMwyJ1PFEc4FX6
   182  wg/HcAJWY60xZTJDFN+Qfx8ZQvBEin6c2/h+zZi5IVY=
   183  -----END RSA TESTING KEY-----
   184  `)
   185  
   186  // pemEd25519Key is the example from RFC 8410, Section 4.
   187  var pemEd25519Key = `
   188  -----BEGIN PUBLIC KEY-----
   189  MCowBQYDK2VwAyEAGb9ECWmEzf6FQbrBZ9w7lshQhqowtrbLDFw4rXAxZuE=
   190  -----END PUBLIC KEY-----
   191  `
   192  
   193  // pemX25519Key was generated from pemX25519Key with "openssl pkey -pubout".
   194  var pemX25519Key = `
   195  -----BEGIN PUBLIC KEY-----
   196  MCowBQYDK2VuAyEA5yGXrH/6OzxuWEhEWS01/f4OP+Of3Yrddy6/J1kDTVM=
   197  -----END PUBLIC KEY-----
   198  `
   199  
   200  func TestPKIXMismatchPublicKeyFormat(t *testing.T) {
   201  
   202  	const pkcs1PublicKey = "308201080282010100817cfed98bcaa2e2a57087451c7674e0c675686dc33ff1268b0c2a6ee0202dec710858ee1c31bdf5e7783582e8ca800be45f3275c6576adc35d98e26e95bb88ca5beb186f853b8745d88bc9102c5f38753bcda519fb05948d5c77ac429255ff8aaf27d9f45d1586e95e2e9ba8a7cb771b8a09dd8c8fed3f933fd9b439bc9f30c475953418ef25f71a2b6496f53d94d39ce850aa0cc75d445b5f5b4f4ee4db78ab197a9a8d8a852f44529a007ac0ac23d895928d60ba538b16b0b087a7f903ed29770e215019b77eaecc360f35f7ab11b6d735978795b2c4a74e5bdea4dc6594cd67ed752a108e666729a753ab36d6c4f606f8760f507e1765be8cd744007e629020103"
   203  	const errorContains = "use ParsePKCS1PublicKey instead"
   204  	derBytes, _ := hex.DecodeString(pkcs1PublicKey)
   205  	_, err := ParsePKIXPublicKey(derBytes)
   206  	if !strings.Contains(err.Error(), errorContains) {
   207  		t.Errorf("expected error containing %q, got %s", errorContains, err)
   208  	}
   209  }
   210  
   211  var testPrivateKey *rsa.PrivateKey
   212  
   213  func init() {
   214  	block, _ := pem.Decode([]byte(pemPrivateKey))
   215  
   216  	var err error
   217  	if testPrivateKey, err = ParsePKCS1PrivateKey(block.Bytes); err != nil {
   218  		panic("Failed to parse private key: " + err.Error())
   219  	}
   220  }
   221  
   222  func bigFromString(s string) *big.Int {
   223  	ret := new(big.Int)
   224  	ret.SetString(s, 10)
   225  	return ret
   226  }
   227  
   228  func fromBase10(base10 string) *big.Int {
   229  	i := new(big.Int)
   230  	i.SetString(base10, 10)
   231  	return i
   232  }
   233  
   234  func bigFromHexString(s string) *big.Int {
   235  	ret := new(big.Int)
   236  	ret.SetString(s, 16)
   237  	return ret
   238  }
   239  
   240  var rsaPrivateKey = &rsa.PrivateKey{
   241  	PublicKey: rsa.PublicKey{
   242  		N: bigFromString("124737666279038955318614287965056875799409043964547386061640914307192830334599556034328900586693254156136128122194531292927142396093148164407300419162827624945636708870992355233833321488652786796134504707628792159725681555822420087112284637501705261187690946267527866880072856272532711620639179596808018872997"),
   243  		E: 65537,
   244  	},
   245  	D: bigFromString("69322600686866301945688231018559005300304807960033948687567105312977055197015197977971637657636780793670599180105424702854759606794705928621125408040473426339714144598640466128488132656829419518221592374964225347786430566310906679585739468938549035854760501049443920822523780156843263434219450229353270690889"),
   246  	Primes: []*big.Int{
   247  		bigFromString("11405025354575369741595561190164746858706645478381139288033759331174478411254205003127028642766986913445391069745480057674348716675323735886284176682955723"),
   248  		bigFromString("10937079261204603443118731009201819560867324167189758120988909645641782263430128449826989846631183550578761324239709121189827307416350485191350050332642639"),
   249  	},
   250  }
   251  
   252  func TestMarshalRSAPrivateKey(t *testing.T) {
   253  	priv := &rsa.PrivateKey{
   254  		PublicKey: rsa.PublicKey{
   255  			N: fromBase10("16346378922382193400538269749936049106320265317511766357599732575277382844051791096569333808598921852351577762718529818072849191122419410612033592401403764925096136759934497687765453905884149505175426053037420486697072448609022753683683718057795566811401938833367954642951433473337066311978821180526439641496973296037000052546108507805269279414789035461158073156772151892452251106173507240488993608650881929629163465099476849643165682709047462010581308719577053905787496296934240246311806555924593059995202856826239801816771116902778517096212527979497399966526283516447337775509777558018145573127308919204297111496233"),
   256  			E: 3,
   257  		},
   258  		D: fromBase10("10897585948254795600358846499957366070880176878341177571733155050184921896034527397712889205732614568234385175145686545381899460748279607074689061600935843283397424506622998458510302603922766336783617368686090042765718290914099334449154829375179958369993407724946186243249568928237086215759259909861748642124071874879861299389874230489928271621259294894142840428407196932444474088857746123104978617098858619445675532587787023228852383149557470077802718705420275739737958953794088728369933811184572620857678792001136676902250566845618813972833750098806496641114644760255910789397593428910198080271317419213080834885003"),
   259  		Primes: []*big.Int{
   260  			fromBase10("1025363189502892836833747188838978207017355117492483312747347695538428729137306368764177201532277413433182799108299960196606011786562992097313508180436744488171474690412562218914213688661311117337381958560443"),
   261  			fromBase10("3467903426626310123395340254094941045497208049900750380025518552334536945536837294961497712862519984786362199788654739924501424784631315081391467293694361474867825728031147665777546570788493758372218019373"),
   262  			fromBase10("4597024781409332673052708605078359346966325141767460991205742124888960305710298765592730135879076084498363772408626791576005136245060321874472727132746643162385746062759369754202494417496879741537284589047"),
   263  		},
   264  	}
   265  
   266  	derBytes := MarshalPKCS1PrivateKey(priv)
   267  
   268  	priv2, err := ParsePKCS1PrivateKey(derBytes)
   269  	if err != nil {
   270  		t.Errorf("error parsing serialized key: %s", err)
   271  		return
   272  	}
   273  	if priv.PublicKey.N.Cmp(priv2.PublicKey.N) != 0 ||
   274  		priv.PublicKey.E != priv2.PublicKey.E ||
   275  		priv.D.Cmp(priv2.D) != 0 ||
   276  		len(priv2.Primes) != 3 ||
   277  		priv.Primes[0].Cmp(priv2.Primes[0]) != 0 ||
   278  		priv.Primes[1].Cmp(priv2.Primes[1]) != 0 ||
   279  		priv.Primes[2].Cmp(priv2.Primes[2]) != 0 {
   280  		t.Errorf("wrong priv:\ngot  %+v\nwant %+v", priv2, priv)
   281  	}
   282  
   283  	if priv.Precomputed.Dp == nil {
   284  		t.Fatalf("Precomputed.Dp is nil")
   285  	}
   286  }
   287  
   288  func TestMarshalRSAPrivateKeyInvalid(t *testing.T) {
   289  	block, _ := pem.Decode([]byte(strings.ReplaceAll(
   290  		`-----BEGIN RSA TESTING KEY-----
   291  MIIEowIBAAKCAQEAsPnoGUOnrpiSqt4XynxA+HRP7S+BSObI6qJ7fQAVSPtRkqso
   292  tWxQYLEYzNEx5ZSHTGypibVsJylvCfuToDTfMul8b/CZjP2Ob0LdpYrNH6l5hvFE
   293  89FU1nZQF15oVLOpUgA7wGiHuEVawrGfey92UE68mOyUVXGweJIVDdxqdMoPvNNU
   294  l86BU02vlBiESxOuox+dWmuVV7vfYZ79Toh/LUK43YvJh+rhv4nKuF7iHjVjBd9s
   295  B6iDjj70HFldzOQ9r8SRI+9NirupPTkF5AKNe6kUhKJ1luB7S27ZkvB3tSTT3P59
   296  3VVJvnzOjaA1z6Cz+4+eRvcysqhrRgFlwI9TEwIDAQABAoIBAEEYiyDP29vCzx/+
   297  dS3LqnI5BjUuJhXUnc6AWX/PCgVAO+8A+gZRgvct7PtZb0sM6P9ZcLrweomlGezI
   298  FrL0/6xQaa8bBr/ve/a8155OgcjFo6fZEw3Dz7ra5fbSiPmu4/b/kvrg+Br1l77J
   299  aun6uUAs1f5B9wW+vbR7tzbT/mxaUeDiBzKpe15GwcvbJtdIVMa2YErtRjc1/5B2
   300  BGVXyvlJv0SIlcIEMsHgnAFOp1ZgQ08aDzvilLq8XVMOahAhP1O2A3X8hKdXPyrx
   301  IVWE9bS9ptTo+eF6eNl+d7htpKGEZHUxinoQpWEBTv+iOoHsVunkEJ3vjLP3lyI/
   302  fY0NQ1ECgYEA3RBXAjgvIys2gfU3keImF8e/TprLge1I2vbWmV2j6rZCg5r/AS0u
   303  pii5CvJ5/T5vfJPNgPBy8B/yRDs+6PJO1GmnlhOkG9JAIPkv0RBZvR0PMBtbp6nT
   304  Y3yo1lwamBVBfY6rc0sLTzosZh2aGoLzrHNMQFMGaauORzBFpY5lU50CgYEAzPHl
   305  u5DI6Xgep1vr8QvCUuEesCOgJg8Yh1UqVoY/SmQh6MYAv1I9bLGwrb3WW/7kqIoD
   306  fj0aQV5buVZI2loMomtU9KY5SFIsPV+JuUpy7/+VE01ZQM5FdY8wiYCQiVZYju9X
   307  Wz5LxMNoz+gT7pwlLCsC4N+R8aoBk404aF1gum8CgYAJ7VTq7Zj4TFV7Soa/T1eE
   308  k9y8a+kdoYk3BASpCHJ29M5R2KEA7YV9wrBklHTz8VzSTFTbKHEQ5W5csAhoL5Fo
   309  qoHzFFi3Qx7MHESQb9qHyolHEMNx6QdsHUn7rlEnaTTyrXh3ifQtD6C0yTmFXUIS
   310  CW9wKApOrnyKJ9nI0HcuZQKBgQCMtoV6e9VGX4AEfpuHvAAnMYQFgeBiYTkBKltQ
   311  XwozhH63uMMomUmtSG87Sz1TmrXadjAhy8gsG6I0pWaN7QgBuFnzQ/HOkwTm+qKw
   312  AsrZt4zeXNwsH7QXHEJCFnCmqw9QzEoZTrNtHJHpNboBuVnYcoueZEJrP8OnUG3r
   313  UjmopwKBgAqB2KYYMUqAOvYcBnEfLDmyZv9BTVNHbR2lKkMYqv5LlvDaBxVfilE0
   314  2riO4p6BaAdvzXjKeRrGNEKoHNBpOSfYCOM16NjL8hIZB1CaV3WbT5oY+jp7Mzd5
   315  7d56RZOE+ERK2uz/7JX9VSsM/LbH9pJibd4e8mikDS9ntciqOH/3
   316  -----END RSA TESTING KEY-----`, "TESTING KEY", "PRIVATE KEY")))
   317  	testRSA2048, _ := ParsePKCS1PrivateKey(block.Bytes)
   318  
   319  	broken := *testRSA2048
   320  	broken.Precomputed.Dp = new(big.Int).SetUint64(42)
   321  
   322  	parsed, err := ParsePKCS1PrivateKey(MarshalPKCS1PrivateKey(&broken))
   323  	if err == nil {
   324  		t.Errorf("expected error, got success")
   325  	}
   326  
   327  	t.Setenv("GODEBUG", "x509rsacrt=0")
   328  
   329  	parsed, err = ParsePKCS1PrivateKey(MarshalPKCS1PrivateKey(&broken))
   330  	if err != nil {
   331  		t.Fatalf("expected success, got error: %v", err)
   332  	}
   333  	// Dp should have been recomputed.
   334  	if parsed.Precomputed.Dp.Cmp(testRSA2048.Precomputed.Dp) != 0 {
   335  		t.Errorf("Dp recomputation failed: got %v, want %v", parsed.Precomputed.Dp, testRSA2048.Precomputed.Dp)
   336  	}
   337  }
   338  
   339  func TestMarshalRSAPublicKey(t *testing.T) {
   340  	pub := &rsa.PublicKey{
   341  		N: fromBase10("16346378922382193400538269749936049106320265317511766357599732575277382844051791096569333808598921852351577762718529818072849191122419410612033592401403764925096136759934497687765453905884149505175426053037420486697072448609022753683683718057795566811401938833367954642951433473337066311978821180526439641496973296037000052546108507805269279414789035461158073156772151892452251106173507240488993608650881929629163465099476849643165682709047462010581308719577053905787496296934240246311806555924593059995202856826239801816771116902778517096212527979497399966526283516447337775509777558018145573127308919204297111496233"),
   342  		E: 3,
   343  	}
   344  	derBytes := MarshalPKCS1PublicKey(pub)
   345  	pub2, err := ParsePKCS1PublicKey(derBytes)
   346  	if err != nil {
   347  		t.Errorf("ParsePKCS1PublicKey: %s", err)
   348  	}
   349  	if pub.N.Cmp(pub2.N) != 0 || pub.E != pub2.E {
   350  		t.Errorf("ParsePKCS1PublicKey = %+v, want %+v", pub, pub2)
   351  	}
   352  
   353  	// It's never been documented that asn1.Marshal/Unmarshal on rsa.PublicKey works,
   354  	// but it does, and we know of code that depends on it.
   355  	// Lock that in, even though we'd prefer that people use MarshalPKCS1PublicKey and ParsePKCS1PublicKey.
   356  	derBytes2, err := asn1.Marshal(*pub)
   357  	if err != nil {
   358  		t.Errorf("Marshal(rsa.PublicKey): %v", err)
   359  	} else if !bytes.Equal(derBytes, derBytes2) {
   360  		t.Errorf("Marshal(rsa.PublicKey) = %x, want %x", derBytes2, derBytes)
   361  	}
   362  	pub3 := new(rsa.PublicKey)
   363  	rest, err := asn1.Unmarshal(derBytes, pub3)
   364  	if err != nil {
   365  		t.Errorf("Unmarshal(rsa.PublicKey): %v", err)
   366  	}
   367  	if len(rest) != 0 || pub.N.Cmp(pub3.N) != 0 || pub.E != pub3.E {
   368  		t.Errorf("Unmarshal(rsa.PublicKey) = %+v, %q want %+v, %q", pub, rest, pub2, []byte(nil))
   369  	}
   370  
   371  	publicKeys := []struct {
   372  		derBytes          []byte
   373  		expectedErrSubstr string
   374  	}{
   375  		{
   376  			derBytes: []byte{
   377  				0x30, 6, // SEQUENCE, 6 bytes
   378  				0x02, 1, // INTEGER, 1 byte
   379  				17,
   380  				0x02, 1, // INTEGER, 1 byte
   381  				3, // 3
   382  			},
   383  		}, {
   384  			derBytes: []byte{
   385  				0x30, 6, // SEQUENCE
   386  				0x02, 1, // INTEGER, 1 byte
   387  				0xff,    // -1
   388  				0x02, 1, // INTEGER, 1 byte
   389  				3,
   390  			},
   391  			expectedErrSubstr: "zero or negative",
   392  		}, {
   393  			derBytes: []byte{
   394  				0x30, 6, // SEQUENCE
   395  				0x02, 1, // INTEGER, 1 byte
   396  				17,
   397  				0x02, 1, // INTEGER, 1 byte
   398  				0xff, // -1
   399  			},
   400  			expectedErrSubstr: "zero or negative",
   401  		}, {
   402  			derBytes: []byte{
   403  				0x30, 6, // SEQUENCE
   404  				0x02, 1, // INTEGER, 1 byte
   405  				17,
   406  				0x02, 1, // INTEGER, 1 byte
   407  				3,
   408  				1,
   409  			},
   410  			expectedErrSubstr: "trailing data",
   411  		}, {
   412  			derBytes: []byte{
   413  				0x30, 9, // SEQUENCE
   414  				0x02, 1, // INTEGER, 1 byte
   415  				17,
   416  				0x02, 4, // INTEGER, 4 bytes
   417  				0x7f, 0xff, 0xff, 0xff,
   418  			},
   419  		}, {
   420  			derBytes: []byte{
   421  				0x30, 10, // SEQUENCE
   422  				0x02, 1, // INTEGER, 1 byte
   423  				17,
   424  				0x02, 5, // INTEGER, 5 bytes
   425  				0x00, 0x80, 0x00, 0x00, 0x00,
   426  			},
   427  			// On 64-bit systems, encoding/asn1 will accept the
   428  			// public exponent, but ParsePKCS1PublicKey will return
   429  			// an error. On 32-bit systems, encoding/asn1 will
   430  			// return the error. The common substring of both error
   431  			// is the word “large”.
   432  			expectedErrSubstr: "large",
   433  		},
   434  	}
   435  
   436  	for i, test := range publicKeys {
   437  		shouldFail := len(test.expectedErrSubstr) > 0
   438  		pub, err := ParsePKCS1PublicKey(test.derBytes)
   439  		if shouldFail {
   440  			if err == nil {
   441  				t.Errorf("#%d: unexpected success, got %#v", i, pub)
   442  			} else if !strings.Contains(err.Error(), test.expectedErrSubstr) {
   443  				t.Errorf("#%d: expected error containing %q, got %s", i, test.expectedErrSubstr, err)
   444  			}
   445  		} else {
   446  			if err != nil {
   447  				t.Errorf("#%d: unexpected failure: %s", i, err)
   448  				continue
   449  			}
   450  			reserialized := MarshalPKCS1PublicKey(pub)
   451  			if !bytes.Equal(reserialized, test.derBytes) {
   452  				t.Errorf("#%d: failed to reserialize: got %x, expected %x", i, reserialized, test.derBytes)
   453  			}
   454  		}
   455  	}
   456  }
   457  
   458  type matchHostnamesTest struct {
   459  	pattern, host string
   460  	ok            bool
   461  }
   462  
   463  var matchHostnamesTests = []matchHostnamesTest{
   464  	{"a.b.c", "a.b.c", true},
   465  	{"a.b.c", "b.b.c", false},
   466  	{"", "b.b.c", false},
   467  	{"a.b.c", "", false},
   468  	{"example.com", "example.com", true},
   469  	{"example.com", "www.example.com", false},
   470  	{"*.example.com", "example.com", false},
   471  	{"*.example.com", "www.example.com", true},
   472  	{"*.example.com", "www.example.com.", true},
   473  	{"*.example.com", "xyz.www.example.com", false},
   474  	{"*.example.com", "https://www.example.com", false}, // Issue 27591
   475  	{"*.example..com", "www.example..com", false},
   476  	{"www.example..com", "www.example..com", true},
   477  	{"*.*.example.com", "xyz.www.example.com", false},
   478  	{"*.www.*.com", "xyz.www.example.com", false},
   479  	{"*bar.example.com", "foobar.example.com", false},
   480  	{"f*.example.com", "foobar.example.com", false},
   481  	{"www.example.com", "*.example.com", false},
   482  	{"", ".", false},
   483  	{".", "", false},
   484  	{".", ".", false},
   485  	{"example.com", "example.com.", true},
   486  	{"example.com.", "example.com", false},
   487  	{"example.com.", "example.com.", true}, // perfect matches allow trailing dots in patterns
   488  	{"*.com.", "example.com.", false},
   489  	{"*.com.", "example.com", false},
   490  	{"*.com", "example.com", true},
   491  	{"*.com", "example.com.", true},
   492  	{"foo:bar", "foo:bar", true},
   493  	{"*.foo:bar", "xxx.foo:bar", false},
   494  	{"*.2.3.4", "1.2.3.4", false},
   495  	{"*.2.3.4", "[1.2.3.4]", false},
   496  	{"*:4860:4860::8888", "2001:4860:4860::8888", false},
   497  	{"*:4860:4860::8888", "[2001:4860:4860::8888]", false},
   498  	{"2001:4860:4860::8888", "2001:4860:4860::8888", false},
   499  	{"2001:4860:4860::8888", "[2001:4860:4860::8888]", false},
   500  	{"[2001:4860:4860::8888]", "2001:4860:4860::8888", false},
   501  	{"[2001:4860:4860::8888]", "[2001:4860:4860::8888]", false},
   502  }
   503  
   504  func TestMatchHostnames(t *testing.T) {
   505  	for i, test := range matchHostnamesTests {
   506  		c := &Certificate{DNSNames: []string{test.pattern}}
   507  		r := c.VerifyHostname(test.host) == nil
   508  		if r != test.ok {
   509  			t.Errorf("#%d mismatch got: %t want: %t when matching '%s' against '%s'", i, r, test.ok, test.host, test.pattern)
   510  		}
   511  	}
   512  }
   513  
   514  func TestMatchIP(t *testing.T) {
   515  	// Check that pattern matching is working.
   516  	c := &Certificate{
   517  		DNSNames: []string{"*.foo.bar.baz"},
   518  		Subject: pkix.Name{
   519  			CommonName: "*.foo.bar.baz",
   520  		},
   521  	}
   522  	err := c.VerifyHostname("quux.foo.bar.baz")
   523  	if err != nil {
   524  		t.Fatalf("VerifyHostname(quux.foo.bar.baz): %v", err)
   525  	}
   526  
   527  	// But check that if we change it to be matching against an IP address,
   528  	// it is rejected.
   529  	c = &Certificate{
   530  		DNSNames: []string{"*.2.3.4"},
   531  		Subject: pkix.Name{
   532  			CommonName: "*.2.3.4",
   533  		},
   534  	}
   535  	err = c.VerifyHostname("1.2.3.4")
   536  	if err == nil {
   537  		t.Fatalf("VerifyHostname(1.2.3.4) should have failed, did not")
   538  	}
   539  
   540  	c = &Certificate{
   541  		IPAddresses: []net.IP{net.ParseIP("127.0.0.1"), net.ParseIP("::1")},
   542  	}
   543  	err = c.VerifyHostname("127.0.0.1")
   544  	if err != nil {
   545  		t.Fatalf("VerifyHostname(127.0.0.1): %v", err)
   546  	}
   547  	err = c.VerifyHostname("::1")
   548  	if err != nil {
   549  		t.Fatalf("VerifyHostname(::1): %v", err)
   550  	}
   551  	err = c.VerifyHostname("[::1]")
   552  	if err != nil {
   553  		t.Fatalf("VerifyHostname([::1]): %v", err)
   554  	}
   555  }
   556  
   557  func TestCertificateParse(t *testing.T) {
   558  	s, _ := base64.StdEncoding.DecodeString(certBytes)
   559  	certs, err := ParseCertificates(s)
   560  	if err != nil {
   561  		t.Error(err)
   562  	}
   563  	if len(certs) != 2 {
   564  		t.Errorf("Wrong number of certs: got %d want 2", len(certs))
   565  		return
   566  	}
   567  
   568  	err = certs[0].CheckSignatureFrom(certs[1])
   569  	if err != nil {
   570  		t.Error(err)
   571  	}
   572  
   573  	if err := certs[0].VerifyHostname("mail.google.com"); err != nil {
   574  		t.Error(err)
   575  	}
   576  
   577  	const expectedExtensions = 10
   578  	if n := len(certs[0].Extensions); n != expectedExtensions {
   579  		t.Errorf("want %d extensions, got %d", expectedExtensions, n)
   580  	}
   581  }
   582  
   583  func TestCertificateEqualOnNil(t *testing.T) {
   584  	cNonNil := new(Certificate)
   585  	var cNil1, cNil2 *Certificate
   586  	if !cNil1.Equal(cNil2) {
   587  		t.Error("Nil certificates: cNil1 is not equal to cNil2")
   588  	}
   589  	if !cNil2.Equal(cNil1) {
   590  		t.Error("Nil certificates: cNil2 is not equal to cNil1")
   591  	}
   592  	if cNil1.Equal(cNonNil) {
   593  		t.Error("Unexpectedly cNil1 is equal to cNonNil")
   594  	}
   595  	if cNonNil.Equal(cNil1) {
   596  		t.Error("Unexpectedly cNonNil is equal to cNil1")
   597  	}
   598  }
   599  
   600  func TestMismatchedSignatureAlgorithm(t *testing.T) {
   601  	der, _ := pem.Decode([]byte(rsaPSSSelfSignedPEM))
   602  	if der == nil {
   603  		t.Fatal("Failed to find PEM block")
   604  	}
   605  
   606  	cert, err := ParseCertificate(der.Bytes)
   607  	if err != nil {
   608  		t.Fatal(err)
   609  	}
   610  
   611  	if err = cert.CheckSignature(ECDSAWithSHA256, nil, nil); err == nil {
   612  		t.Fatal("CheckSignature unexpectedly return no error")
   613  	}
   614  
   615  	const expectedSubstring = " but have public key of type "
   616  	if !strings.Contains(err.Error(), expectedSubstring) {
   617  		t.Errorf("Expected error containing %q, but got %q", expectedSubstring, err)
   618  	}
   619  }
   620  
   621  var certBytes = "MIIE0jCCA7qgAwIBAgIQWcvS+TTB3GwCAAAAAGEAWzANBgkqhkiG9w0BAQsFADBCMQswCQYD" +
   622  	"VQQGEwJVUzEeMBwGA1UEChMVR29vZ2xlIFRydXN0IFNlcnZpY2VzMRMwEQYDVQQDEwpHVFMg" +
   623  	"Q0EgMU8xMB4XDTIwMDQwMTEyNTg1NloXDTIwMDYyNDEyNTg1NlowaTELMAkGA1UEBhMCVVMx" +
   624  	"EzARBgNVBAgTCkNhbGlmb3JuaWExFjAUBgNVBAcTDU1vdW50YWluIFZpZXcxEzARBgNVBAoT" +
   625  	"Ckdvb2dsZSBMTEMxGDAWBgNVBAMTD21haWwuZ29vZ2xlLmNvbTBZMBMGByqGSM49AgEGCCqG" +
   626  	"SM49AwEHA0IABO+dYiPnkFl+cZVf6mrWeNp0RhQcJSBGH+sEJxjvc+cYlW3QJCnm57qlpFdd" +
   627  	"pz3MPyVejvXQdM6iI1mEWP4C2OujggJmMIICYjAOBgNVHQ8BAf8EBAMCB4AwEwYDVR0lBAww" +
   628  	"CgYIKwYBBQUHAwEwDAYDVR0TAQH/BAIwADAdBgNVHQ4EFgQUI6pZhnQ/lQgmPDwSKR2A54G7" +
   629  	"AS4wHwYDVR0jBBgwFoAUmNH4bhDrz5vsYJ8YkBug630J/SswZAYIKwYBBQUHAQEEWDBWMCcG" +
   630  	"CCsGAQUFBzABhhtodHRwOi8vb2NzcC5wa2kuZ29vZy9ndHMxbzEwKwYIKwYBBQUHMAKGH2h0" +
   631  	"dHA6Ly9wa2kuZ29vZy9nc3IyL0dUUzFPMS5jcnQwLAYDVR0RBCUwI4IPbWFpbC5nb29nbGUu" +
   632  	"Y29tghBpbmJveC5nb29nbGUuY29tMCEGA1UdIAQaMBgwCAYGZ4EMAQICMAwGCisGAQQB1nkC" +
   633  	"BQMwLwYDVR0fBCgwJjAkoCKgIIYeaHR0cDovL2NybC5wa2kuZ29vZy9HVFMxTzEuY3JsMIIB" +
   634  	"AwYKKwYBBAHWeQIEAgSB9ASB8QDvAHYAsh4FzIuizYogTodm+Su5iiUgZ2va+nDnsklTLe+L" +
   635  	"kF4AAAFxNgmxKgAABAMARzBFAiEA12/OHdTGXQ3qHHC3NvYCyB8aEz/+ZFOLCAI7lhqj28sC" +
   636  	"IG2/7Yz2zK6S6ai+dH7cTMZmoFGo39gtaTqtZAqEQX7nAHUAXqdz+d9WwOe1Nkh90EngMnqR" +
   637  	"mgyEoRIShBh1loFxRVgAAAFxNgmxTAAABAMARjBEAiA7PNq+MFfv6O9mBkxFViS2TfU66yRB" +
   638  	"/njcebWglLQjZQIgOyRKhxlEizncFRml7yn4Bg48ktXKGjo+uiw6zXEINb0wDQYJKoZIhvcN" +
   639  	"AQELBQADggEBADM2Rh306Q10PScsolYMxH1B/K4Nb2WICvpY0yDPJFdnGjqCYym196TjiEvs" +
   640  	"R6etfeHdyzlZj6nh82B4TVyHjiWM02dQgPalOuWQcuSy0OvLh7F1E7CeHzKlczdFPBTOTdM1" +
   641  	"RDTxlvw1bAqc0zueM8QIAyEy3opd7FxAcGQd5WRIJhzLBL+dbbMOW/LTeW7cm/Xzq8cgCybN" +
   642  	"BSZAvhjseJ1L29OlCTZL97IfnX0IlFQzWuvvHy7V2B0E3DHlzM0kjwkkCKDUUp/wajv2NZKC" +
   643  	"TkhEyERacZRKc9U0ADxwsAzHrdz5+5zfD2usEV/MQ5V6d8swLXs+ko0X6swrd4YCiB8wggRK" +
   644  	"MIIDMqADAgECAg0B47SaoY2KqYElaVC4MA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0ds" +
   645  	"b2JhbFNpZ24gUm9vdCBDQSAtIFIyMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpH" +
   646  	"bG9iYWxTaWduMB4XDTE3MDYxNTAwMDA0MloXDTIxMTIxNTAwMDA0MlowQjELMAkGA1UEBhMC" +
   647  	"VVMxHjAcBgNVBAoTFUdvb2dsZSBUcnVzdCBTZXJ2aWNlczETMBEGA1UEAxMKR1RTIENBIDFP" +
   648  	"MTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBANAYz0XUi83TnORA73603WkhG8nP" +
   649  	"PI5MdbkPMRmEPZ48Ke9QDRCTbwWAgJ8qoL0SSwLhPZ9YFiT+MJ8LdHdVkx1L903hkoIQ9lGs" +
   650  	"DMOyIpQPNGuYEEnnC52DOd0gxhwt79EYYWXnI4MgqCMS/9Ikf9Qv50RqW03XUGawr55CYwX7" +
   651  	"4BzEY2Gvn2oz/2KXvUjZ03wUZ9x13C5p6PhteGnQtxAFuPExwjsk/RozdPgj4OxrGYoWxuPN" +
   652  	"pM0L27OkWWA4iDutHbnGjKdTG/y82aSrvN08YdeTFZjugb2P4mRHIEAGTtesl+i5wFkSoUkl" +
   653  	"I+TtcDQspbRjfPmjPYPRzW0krAcCAwEAAaOCATMwggEvMA4GA1UdDwEB/wQEAwIBhjAdBgNV" +
   654  	"HSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwEgYDVR0TAQH/BAgwBgEB/wIBADAdBgNVHQ4E" +
   655  	"FgQUmNH4bhDrz5vsYJ8YkBug630J/SswHwYDVR0jBBgwFoAUm+IHV2ccHsBqBt5ZtJot39wZ" +
   656  	"hi4wNQYIKwYBBQUHAQEEKTAnMCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC5wa2kuZ29vZy9n" +
   657  	"c3IyMDIGA1UdHwQrMCkwJ6AloCOGIWh0dHA6Ly9jcmwucGtpLmdvb2cvZ3NyMi9nc3IyLmNy" +
   658  	"bDA/BgNVHSAEODA2MDQGBmeBDAECAjAqMCgGCCsGAQUFBwIBFhxodHRwczovL3BraS5nb29n" +
   659  	"L3JlcG9zaXRvcnkvMA0GCSqGSIb3DQEBCwUAA4IBAQAagD42efvzLqlGN31eVBY1rsdOCJn+" +
   660  	"vdE0aSZSZgc9CrpJy2L08RqO/BFPaJZMdCvTZ96yo6oFjYRNTCBlD6WW2g0W+Gw7228EI4hr" +
   661  	"OmzBYL1on3GO7i1YNAfw1VTphln9e14NIZT1jMmo+NjyrcwPGvOap6kEJ/mjybD/AnhrYbrH" +
   662  	"NSvoVvpPwxwM7bY8tEvq7czhPOzcDYzWPpvKQliLzBYhF0C8otZm79rEFVvNiaqbCSbnMtIN" +
   663  	"bmcgAlsQsJAJnAwfnq3YO+qh/GzoEFwIUhlRKnG7rHq13RXtK8kIKiyKtKYhq2P/11JJUNCJ" +
   664  	"t63yr/tQri/hlQ3zRq2dnPXK"
   665  
   666  func parseCIDR(s string) *net.IPNet {
   667  	_, net, err := net.ParseCIDR(s)
   668  	if err != nil {
   669  		panic(err)
   670  	}
   671  	return net
   672  }
   673  
   674  func parseURI(s string) *url.URL {
   675  	uri, err := url.Parse(s)
   676  	if err != nil {
   677  		panic(err)
   678  	}
   679  	return uri
   680  }
   681  
   682  func TestCreateSelfSignedCertificate(t *testing.T) {
   683  	random := rand.Reader
   684  
   685  	ecdsaPriv, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
   686  	if err != nil {
   687  		t.Fatalf("Failed to generate ECDSA key: %s", err)
   688  	}
   689  
   690  	ed25519Pub, ed25519Priv, err := ed25519.GenerateKey(random)
   691  	if err != nil {
   692  		t.Fatalf("Failed to generate Ed25519 key: %s", err)
   693  	}
   694  
   695  	tests := []struct {
   696  		name      string
   697  		pub, priv any
   698  		checkSig  bool
   699  		sigAlgo   SignatureAlgorithm
   700  	}{
   701  		{"RSA/RSA", &testPrivateKey.PublicKey, testPrivateKey, true, SHA384WithRSA},
   702  		{"RSA/ECDSA", &testPrivateKey.PublicKey, ecdsaPriv, false, ECDSAWithSHA384},
   703  		{"ECDSA/RSA", &ecdsaPriv.PublicKey, testPrivateKey, false, SHA256WithRSA},
   704  		{"ECDSA/ECDSA", &ecdsaPriv.PublicKey, ecdsaPriv, true, ECDSAWithSHA256},
   705  		{"RSAPSS/RSAPSS", &testPrivateKey.PublicKey, testPrivateKey, true, SHA256WithRSAPSS},
   706  		{"ECDSA/RSAPSS", &ecdsaPriv.PublicKey, testPrivateKey, false, SHA256WithRSAPSS},
   707  		{"RSAPSS/ECDSA", &testPrivateKey.PublicKey, ecdsaPriv, false, ECDSAWithSHA384},
   708  		{"Ed25519", ed25519Pub, ed25519Priv, true, PureEd25519},
   709  	}
   710  
   711  	testExtKeyUsage := []ExtKeyUsage{ExtKeyUsageClientAuth, ExtKeyUsageServerAuth}
   712  	testUnknownExtKeyUsage := []asn1.ObjectIdentifier{[]int{1, 2, 3}, []int{2, 59, 1}}
   713  	extraExtensionData := []byte("extra extension")
   714  
   715  	for _, test := range tests {
   716  		commonName := "test.example.com"
   717  		template := Certificate{
   718  			SerialNumber: big.NewInt(1),
   719  			Subject: pkix.Name{
   720  				CommonName:   commonName,
   721  				Organization: []string{"Σ Acme Co"},
   722  				Country:      []string{"US"},
   723  				ExtraNames: []pkix.AttributeTypeAndValue{
   724  					{
   725  						Type:  []int{2, 5, 4, 42},
   726  						Value: "Gopher",
   727  					},
   728  					// This should override the Country, above.
   729  					{
   730  						Type:  []int{2, 5, 4, 6},
   731  						Value: "NL",
   732  					},
   733  				},
   734  			},
   735  			NotBefore: time.Unix(1000, 0),
   736  			NotAfter:  time.Unix(100000, 0),
   737  
   738  			SignatureAlgorithm: test.sigAlgo,
   739  
   740  			SubjectKeyId: []byte{1, 2, 3, 4},
   741  			KeyUsage:     KeyUsageCertSign,
   742  
   743  			ExtKeyUsage:        testExtKeyUsage,
   744  			UnknownExtKeyUsage: testUnknownExtKeyUsage,
   745  
   746  			BasicConstraintsValid: true,
   747  			IsCA:                  true,
   748  
   749  			OCSPServer:            []string{"http://ocsp.example.com"},
   750  			IssuingCertificateURL: []string{"http://crt.example.com/ca1.crt"},
   751  
   752  			DNSNames:       []string{"test.example.com"},
   753  			EmailAddresses: []string{"gopher@golang.org"},
   754  			IPAddresses:    []net.IP{net.IPv4(127, 0, 0, 1).To4(), net.ParseIP("2001:4860:0:2001::68")},
   755  			URIs:           []*url.URL{parseURI("https://foo.com/wibble#foo")},
   756  
   757  			Policies:                []OID{mustNewOIDFromInts([]uint64{1, 2, 3, math.MaxUint32, math.MaxUint64})},
   758  			PermittedDNSDomains:     []string{".example.com", "example.com"},
   759  			ExcludedDNSDomains:      []string{"bar.example.com"},
   760  			PermittedIPRanges:       []*net.IPNet{parseCIDR("192.168.1.1/16"), parseCIDR("1.2.3.4/8")},
   761  			ExcludedIPRanges:        []*net.IPNet{parseCIDR("2001:db8::/48")},
   762  			PermittedEmailAddresses: []string{"foo@example.com"},
   763  			ExcludedEmailAddresses:  []string{".example.com", "example.com"},
   764  			PermittedURIDomains:     []string{".bar.com", "bar.com"},
   765  			ExcludedURIDomains:      []string{".bar2.com", "bar2.com"},
   766  
   767  			CRLDistributionPoints: []string{"http://crl1.example.com/ca1.crl", "http://crl2.example.com/ca1.crl"},
   768  
   769  			ExtraExtensions: []pkix.Extension{
   770  				{
   771  					Id:    []int{1, 2, 3, 4},
   772  					Value: extraExtensionData,
   773  				},
   774  				// This extension should override the SubjectKeyId, above.
   775  				{
   776  					Id:       oidExtensionSubjectKeyId,
   777  					Critical: false,
   778  					Value:    []byte{0x04, 0x04, 4, 3, 2, 1},
   779  				},
   780  			},
   781  		}
   782  
   783  		derBytes, err := CreateCertificate(random, &template, &template, test.pub, test.priv)
   784  		if err != nil {
   785  			t.Errorf("%s: failed to create certificate: %s", test.name, err)
   786  			continue
   787  		}
   788  
   789  		cert, err := ParseCertificate(derBytes)
   790  		if err != nil {
   791  			t.Errorf("%s: failed to parse certificate: %s", test.name, err)
   792  			continue
   793  		}
   794  
   795  		if len(cert.Policies) != 1 || !cert.Policies[0].Equal(template.Policies[0]) {
   796  			t.Errorf("%s: failed to parse policy identifiers: got:%#v want:%#v", test.name, cert.PolicyIdentifiers, template.Policies)
   797  		}
   798  
   799  		if len(cert.PermittedDNSDomains) != 2 || cert.PermittedDNSDomains[0] != ".example.com" || cert.PermittedDNSDomains[1] != "example.com" {
   800  			t.Errorf("%s: failed to parse name constraints: %#v", test.name, cert.PermittedDNSDomains)
   801  		}
   802  
   803  		if len(cert.ExcludedDNSDomains) != 1 || cert.ExcludedDNSDomains[0] != "bar.example.com" {
   804  			t.Errorf("%s: failed to parse name constraint exclusions: %#v", test.name, cert.ExcludedDNSDomains)
   805  		}
   806  
   807  		if len(cert.PermittedIPRanges) != 2 || cert.PermittedIPRanges[0].String() != "192.168.0.0/16" || cert.PermittedIPRanges[1].String() != "1.0.0.0/8" {
   808  			t.Errorf("%s: failed to parse IP constraints: %#v", test.name, cert.PermittedIPRanges)
   809  		}
   810  
   811  		if len(cert.ExcludedIPRanges) != 1 || cert.ExcludedIPRanges[0].String() != "2001:db8::/48" {
   812  			t.Errorf("%s: failed to parse IP constraint exclusions: %#v", test.name, cert.ExcludedIPRanges)
   813  		}
   814  
   815  		if len(cert.PermittedEmailAddresses) != 1 || cert.PermittedEmailAddresses[0] != "foo@example.com" {
   816  			t.Errorf("%s: failed to parse permitted email addresses: %#v", test.name, cert.PermittedEmailAddresses)
   817  		}
   818  
   819  		if len(cert.ExcludedEmailAddresses) != 2 || cert.ExcludedEmailAddresses[0] != ".example.com" || cert.ExcludedEmailAddresses[1] != "example.com" {
   820  			t.Errorf("%s: failed to parse excluded email addresses: %#v", test.name, cert.ExcludedEmailAddresses)
   821  		}
   822  
   823  		if len(cert.PermittedURIDomains) != 2 || cert.PermittedURIDomains[0] != ".bar.com" || cert.PermittedURIDomains[1] != "bar.com" {
   824  			t.Errorf("%s: failed to parse permitted URIs: %#v", test.name, cert.PermittedURIDomains)
   825  		}
   826  
   827  		if len(cert.ExcludedURIDomains) != 2 || cert.ExcludedURIDomains[0] != ".bar2.com" || cert.ExcludedURIDomains[1] != "bar2.com" {
   828  			t.Errorf("%s: failed to parse excluded URIs: %#v", test.name, cert.ExcludedURIDomains)
   829  		}
   830  
   831  		if cert.Subject.CommonName != commonName {
   832  			t.Errorf("%s: subject wasn't correctly copied from the template. Got %s, want %s", test.name, cert.Subject.CommonName, commonName)
   833  		}
   834  
   835  		if len(cert.Subject.Country) != 1 || cert.Subject.Country[0] != "NL" {
   836  			t.Errorf("%s: ExtraNames didn't override Country", test.name)
   837  		}
   838  
   839  		for _, ext := range cert.Extensions {
   840  			if ext.Id.Equal(oidExtensionSubjectAltName) {
   841  				if ext.Critical {
   842  					t.Fatal("SAN extension is marked critical")
   843  				}
   844  			}
   845  		}
   846  
   847  		found := false
   848  		for _, atv := range cert.Subject.Names {
   849  			if atv.Type.Equal([]int{2, 5, 4, 42}) {
   850  				found = true
   851  				break
   852  			}
   853  		}
   854  		if !found {
   855  			t.Errorf("%s: Names didn't contain oid 2.5.4.42 from ExtraNames", test.name)
   856  		}
   857  
   858  		if cert.Issuer.CommonName != commonName {
   859  			t.Errorf("%s: issuer wasn't correctly copied from the template. Got %s, want %s", test.name, cert.Issuer.CommonName, commonName)
   860  		}
   861  
   862  		if cert.SignatureAlgorithm != test.sigAlgo {
   863  			t.Errorf("%s: SignatureAlgorithm wasn't copied from template. Got %v, want %v", test.name, cert.SignatureAlgorithm, test.sigAlgo)
   864  		}
   865  
   866  		if !slices.Equal(cert.ExtKeyUsage, testExtKeyUsage) {
   867  			t.Errorf("%s: extkeyusage wasn't correctly copied from the template. Got %v, want %v", test.name, cert.ExtKeyUsage, testExtKeyUsage)
   868  		}
   869  
   870  		if !slices.EqualFunc(cert.UnknownExtKeyUsage, testUnknownExtKeyUsage, asn1.ObjectIdentifier.Equal) {
   871  			t.Errorf("%s: unknown extkeyusage wasn't correctly copied from the template. Got %v, want %v", test.name, cert.UnknownExtKeyUsage, testUnknownExtKeyUsage)
   872  		}
   873  
   874  		if !slices.Equal(cert.OCSPServer, template.OCSPServer) {
   875  			t.Errorf("%s: OCSP servers differ from template. Got %v, want %v", test.name, cert.OCSPServer, template.OCSPServer)
   876  		}
   877  
   878  		if !slices.Equal(cert.IssuingCertificateURL, template.IssuingCertificateURL) {
   879  			t.Errorf("%s: Issuing certificate URLs differ from template. Got %v, want %v", test.name, cert.IssuingCertificateURL, template.IssuingCertificateURL)
   880  		}
   881  
   882  		if !slices.Equal(cert.DNSNames, template.DNSNames) {
   883  			t.Errorf("%s: SAN DNS names differ from template. Got %v, want %v", test.name, cert.DNSNames, template.DNSNames)
   884  		}
   885  
   886  		if !slices.Equal(cert.EmailAddresses, template.EmailAddresses) {
   887  			t.Errorf("%s: SAN emails differ from template. Got %v, want %v", test.name, cert.EmailAddresses, template.EmailAddresses)
   888  		}
   889  
   890  		if len(cert.URIs) != 1 || cert.URIs[0].String() != "https://foo.com/wibble#foo" {
   891  			t.Errorf("%s: URIs differ from template. Got %v, want %v", test.name, cert.URIs, template.URIs)
   892  		}
   893  
   894  		if !slices.EqualFunc(cert.IPAddresses, template.IPAddresses, net.IP.Equal) {
   895  			t.Errorf("%s: SAN IPs differ from template. Got %v, want %v", test.name, cert.IPAddresses, template.IPAddresses)
   896  		}
   897  
   898  		if !slices.Equal(cert.CRLDistributionPoints, template.CRLDistributionPoints) {
   899  			t.Errorf("%s: CRL distribution points differ from template. Got %v, want %v", test.name, cert.CRLDistributionPoints, template.CRLDistributionPoints)
   900  		}
   901  
   902  		if !bytes.Equal(cert.SubjectKeyId, []byte{4, 3, 2, 1}) {
   903  			t.Errorf("%s: ExtraExtensions didn't override SubjectKeyId", test.name)
   904  		}
   905  
   906  		if !bytes.Contains(derBytes, extraExtensionData) {
   907  			t.Errorf("%s: didn't find extra extension in DER output", test.name)
   908  		}
   909  
   910  		if test.checkSig {
   911  			err = cert.CheckSignatureFrom(cert)
   912  			if err != nil {
   913  				t.Errorf("%s: signature verification failed: %s", test.name, err)
   914  			}
   915  		}
   916  	}
   917  }
   918  
   919  // Self-signed certificate using ECDSA with SHA1 & secp256r1
   920  var ecdsaSHA1CertPem = `
   921  -----BEGIN CERTIFICATE-----
   922  MIICDjCCAbUCCQDF6SfN0nsnrjAJBgcqhkjOPQQBMIGPMQswCQYDVQQGEwJVUzET
   923  MBEGA1UECAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzEVMBMG
   924  A1UECgwMR29vZ2xlLCBJbmMuMRcwFQYDVQQDDA53d3cuZ29vZ2xlLmNvbTEjMCEG
   925  CSqGSIb3DQEJARYUZ29sYW5nLWRldkBnbWFpbC5jb20wHhcNMTIwNTIwMjAyMDUw
   926  WhcNMjIwNTE4MjAyMDUwWjCBjzELMAkGA1UEBhMCVVMxEzARBgNVBAgMCkNhbGlm
   927  b3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxFTATBgNVBAoMDEdvb2dsZSwg
   928  SW5jLjEXMBUGA1UEAwwOd3d3Lmdvb2dsZS5jb20xIzAhBgkqhkiG9w0BCQEWFGdv
   929  bGFuZy1kZXZAZ21haWwuY29tMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE/Wgn
   930  WQDo5+bz71T0327ERgd5SDDXFbXLpzIZDXTkjpe8QTEbsF+ezsQfrekrpDPC4Cd3
   931  P9LY0tG+aI8IyVKdUjAJBgcqhkjOPQQBA0gAMEUCIGlsqMcRqWVIWTD6wXwe6Jk2
   932  DKxL46r/FLgJYnzBEH99AiEA3fBouObsvV1R3oVkb4BQYnD4/4LeId6lAT43YvyV
   933  a/A=
   934  -----END CERTIFICATE-----
   935  `
   936  
   937  // Self-signed certificate using ECDSA with SHA256 & secp256r1
   938  var ecdsaSHA256p256CertPem = `
   939  -----BEGIN CERTIFICATE-----
   940  MIICDzCCAbYCCQDlsuMWvgQzhTAKBggqhkjOPQQDAjCBjzELMAkGA1UEBhMCVVMx
   941  EzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxFTAT
   942  BgNVBAoMDEdvb2dsZSwgSW5jLjEXMBUGA1UEAwwOd3d3Lmdvb2dsZS5jb20xIzAh
   943  BgkqhkiG9w0BCQEWFGdvbGFuZy1kZXZAZ21haWwuY29tMB4XDTEyMDUyMTAwMTkx
   944  NloXDTIyMDUxOTAwMTkxNlowgY8xCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApDYWxp
   945  Zm9ybmlhMRYwFAYDVQQHDA1Nb3VudGFpbiBWaWV3MRUwEwYDVQQKDAxHb29nbGUs
   946  IEluYy4xFzAVBgNVBAMMDnd3dy5nb29nbGUuY29tMSMwIQYJKoZIhvcNAQkBFhRn
   947  b2xhbmctZGV2QGdtYWlsLmNvbTBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABPMt
   948  2ErhxAty5EJRu9yM+MTy+hUXm3pdW1ensAv382KoGExSXAFWP7pjJnNtHO+XSwVm
   949  YNtqjcAGFKpweoN//kQwCgYIKoZIzj0EAwIDRwAwRAIgIYSaUA/IB81gjbIw/hUV
   950  70twxJr5EcgOo0hLp3Jm+EYCIFDO3NNcgmURbJ1kfoS3N/0O+irUtoPw38YoNkqJ
   951  h5wi
   952  -----END CERTIFICATE-----
   953  `
   954  
   955  // Self-signed certificate using ECDSA with SHA256 & secp384r1
   956  var ecdsaSHA256p384CertPem = `
   957  -----BEGIN CERTIFICATE-----
   958  MIICSjCCAdECCQDje/no7mXkVzAKBggqhkjOPQQDAjCBjjELMAkGA1UEBhMCVVMx
   959  EzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxFDAS
   960  BgNVBAoMC0dvb2dsZSwgSW5jMRcwFQYDVQQDDA53d3cuZ29vZ2xlLmNvbTEjMCEG
   961  CSqGSIb3DQEJARYUZ29sYW5nLWRldkBnbWFpbC5jb20wHhcNMTIwNTIxMDYxMDM0
   962  WhcNMjIwNTE5MDYxMDM0WjCBjjELMAkGA1UEBhMCVVMxEzARBgNVBAgMCkNhbGlm
   963  b3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxFDASBgNVBAoMC0dvb2dsZSwg
   964  SW5jMRcwFQYDVQQDDA53d3cuZ29vZ2xlLmNvbTEjMCEGCSqGSIb3DQEJARYUZ29s
   965  YW5nLWRldkBnbWFpbC5jb20wdjAQBgcqhkjOPQIBBgUrgQQAIgNiAARRuzRNIKRK
   966  jIktEmXanNmrTR/q/FaHXLhWRZ6nHWe26Fw7Rsrbk+VjGy4vfWtNn7xSFKrOu5ze
   967  qxKnmE0h5E480MNgrUiRkaGO2GMJJVmxx20aqkXOk59U8yGA4CghE6MwCgYIKoZI
   968  zj0EAwIDZwAwZAIwBZEN8gvmRmfeP/9C1PRLzODIY4JqWub2PLRT4mv9GU+yw3Gr
   969  PU9A3CHMdEcdw/MEAjBBO1lId8KOCh9UZunsSMfqXiVurpzmhWd6VYZ/32G+M+Mh
   970  3yILeYQzllt/g0rKVRk=
   971  -----END CERTIFICATE-----
   972  `
   973  
   974  // Self-signed certificate using ECDSA with SHA384 & secp521r1
   975  var ecdsaSHA384p521CertPem = `
   976  -----BEGIN CERTIFICATE-----
   977  MIICljCCAfcCCQDhp1AFD/ahKjAKBggqhkjOPQQDAzCBjjELMAkGA1UEBhMCVVMx
   978  EzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxFDAS
   979  BgNVBAoMC0dvb2dsZSwgSW5jMRcwFQYDVQQDDA53d3cuZ29vZ2xlLmNvbTEjMCEG
   980  CSqGSIb3DQEJARYUZ29sYW5nLWRldkBnbWFpbC5jb20wHhcNMTIwNTIxMTUwNDI5
   981  WhcNMjIwNTE5MTUwNDI5WjCBjjELMAkGA1UEBhMCVVMxEzARBgNVBAgMCkNhbGlm
   982  b3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxFDASBgNVBAoMC0dvb2dsZSwg
   983  SW5jMRcwFQYDVQQDDA53d3cuZ29vZ2xlLmNvbTEjMCEGCSqGSIb3DQEJARYUZ29s
   984  YW5nLWRldkBnbWFpbC5jb20wgZswEAYHKoZIzj0CAQYFK4EEACMDgYYABACqx9Rv
   985  IssRs1LWYcNN+WffwlHw4Tv3y8/LIAA9MF1ZScIonU9nRMxt4a2uGJVCPDw6JHpz
   986  PaYc0E9puLoE9AfKpwFr59Jkot7dBg55SKPEFkddoip/rvmN7NPAWjMBirOwjOkm
   987  8FPthvPhGPqsu9AvgVuHu3PosWiHGNrhh379pva8MzAKBggqhkjOPQQDAwOBjAAw
   988  gYgCQgEHNmswkUdPpHqrVxp9PvLVl+xxPuHBkT+75z9JizyxtqykHQo9Uh6SWCYH
   989  BF9KLolo01wMt8DjoYP5Fb3j5MH7xwJCAbWZzTOp4l4DPkIvAh4LeC4VWbwPPyqh
   990  kBg71w/iEcSY3wUKgHGcJJrObZw7wys91I5kENljqw/Samdr3ka+jBJa
   991  -----END CERTIFICATE-----
   992  `
   993  
   994  var ecdsaTests = []struct {
   995  	sigAlgo SignatureAlgorithm
   996  	pemCert string
   997  }{
   998  	{ECDSAWithSHA256, ecdsaSHA256p256CertPem},
   999  	{ECDSAWithSHA256, ecdsaSHA256p384CertPem},
  1000  	{ECDSAWithSHA384, ecdsaSHA384p521CertPem},
  1001  }
  1002  
  1003  func TestECDSA(t *testing.T) {
  1004  	for i, test := range ecdsaTests {
  1005  		pemBlock, _ := pem.Decode([]byte(test.pemCert))
  1006  		cert, err := ParseCertificate(pemBlock.Bytes)
  1007  		if err != nil {
  1008  			t.Errorf("%d: failed to parse certificate: %s", i, err)
  1009  			continue
  1010  		}
  1011  		if sa := cert.SignatureAlgorithm; sa != test.sigAlgo {
  1012  			t.Errorf("%d: signature algorithm is %v, want %v", i, sa, test.sigAlgo)
  1013  		}
  1014  		if parsedKey, ok := cert.PublicKey.(*ecdsa.PublicKey); !ok {
  1015  			t.Errorf("%d: wanted an ECDSA public key but found: %#v", i, parsedKey)
  1016  		}
  1017  		if pka := cert.PublicKeyAlgorithm; pka != ECDSA {
  1018  			t.Errorf("%d: public key algorithm is %v, want ECDSA", i, pka)
  1019  		}
  1020  		if err = cert.CheckSignatureFrom(cert); err != nil {
  1021  			t.Errorf("%d: certificate verification failed: %s", i, err)
  1022  		}
  1023  	}
  1024  }
  1025  
  1026  // Self-signed certificate using DSA with SHA1
  1027  var dsaCertPem = `-----BEGIN CERTIFICATE-----
  1028  MIIEDTCCA82gAwIBAgIJALHPghaoxeDhMAkGByqGSM44BAMweTELMAkGA1UEBhMC
  1029  VVMxCzAJBgNVBAgTAk5DMQ8wDQYDVQQHEwZOZXd0b24xFDASBgNVBAoTC0dvb2ds
  1030  ZSwgSW5jMRIwEAYDVQQDEwlKb24gQWxsaWUxIjAgBgkqhkiG9w0BCQEWE2pvbmFs
  1031  bGllQGdvb2dsZS5jb20wHhcNMTEwNTE0MDMwMTQ1WhcNMTEwNjEzMDMwMTQ1WjB5
  1032  MQswCQYDVQQGEwJVUzELMAkGA1UECBMCTkMxDzANBgNVBAcTBk5ld3RvbjEUMBIG
  1033  A1UEChMLR29vZ2xlLCBJbmMxEjAQBgNVBAMTCUpvbiBBbGxpZTEiMCAGCSqGSIb3
  1034  DQEJARYTam9uYWxsaWVAZ29vZ2xlLmNvbTCCAbcwggEsBgcqhkjOOAQBMIIBHwKB
  1035  gQC8hLUnQ7FpFYu4WXTj6DKvXvz8QrJkNJCVMTpKAT7uBpobk32S5RrPKXocd4gN
  1036  8lyGB9ggS03EVlEwXvSmO0DH2MQtke2jl9j1HLydClMf4sbx5V6TV9IFw505U1iW
  1037  jL7awRMgxge+FsudtJK254FjMFo03ZnOQ8ZJJ9E6AEDrlwIVAJpnBn9moyP11Ox5
  1038  Asc/5dnjb6dPAoGBAJFHd4KVv1iTVCvEG6gGiYop5DJh28hUQcN9kul+2A0yPUSC
  1039  X93oN00P8Vh3eYgSaCWZsha7zDG53MrVJ0Zf6v/X/CoZNhLldeNOepivTRAzn+Rz
  1040  kKUYy5l1sxYLHQKF0UGNCXfFKZT0PCmgU+PWhYNBBMn6/cIh44vp85ideo5CA4GE
  1041  AAKBgFmifCafzeRaohYKXJgMGSEaggCVCRq5xdyDCat+wbOkjC4mfG01/um3G8u5
  1042  LxasjlWRKTR/tcAL7t0QuokVyQaYdVypZXNaMtx1db7YBuHjj3aP+8JOQRI9xz8c
  1043  bp5NDJ5pISiFOv4p3GZfqZPcqckDt78AtkQrmnal2txhhjF6o4HeMIHbMB0GA1Ud
  1044  DgQWBBQVyyr7hO11ZFFpWX50298Sa3V+rzCBqwYDVR0jBIGjMIGggBQVyyr7hO11
  1045  ZFFpWX50298Sa3V+r6F9pHsweTELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAk5DMQ8w
  1046  DQYDVQQHEwZOZXd0b24xFDASBgNVBAoTC0dvb2dsZSwgSW5jMRIwEAYDVQQDEwlK
  1047  b24gQWxsaWUxIjAgBgkqhkiG9w0BCQEWE2pvbmFsbGllQGdvb2dsZS5jb22CCQCx
  1048  z4IWqMXg4TAMBgNVHRMEBTADAQH/MAkGByqGSM44BAMDLwAwLAIUPtn/5j8Q1jJI
  1049  7ggOIsgrhgUdjGQCFCsmDq1H11q9+9Wp9IMeGrTSKHIM
  1050  -----END CERTIFICATE-----
  1051  `
  1052  
  1053  func TestParseCertificateWithDsaPublicKey(t *testing.T) {
  1054  	expectedKey := &dsa.PublicKey{
  1055  		Parameters: dsa.Parameters{
  1056  			P: bigFromHexString("00BC84B52743B169158BB85974E3E832AF5EFCFC42B264349095313A4A013EEE069A1B937D92E51ACF297A1C77880DF25C8607D8204B4DC45651305EF4A63B40C7D8C42D91EDA397D8F51CBC9D0A531FE2C6F1E55E9357D205C39D395358968CBEDAC11320C607BE16CB9DB492B6E78163305A34DD99CE43C64927D13A0040EB97"),
  1057  			Q: bigFromHexString("009A67067F66A323F5D4EC7902C73FE5D9E36FA74F"),
  1058  			G: bigFromHexString("009147778295BF5893542BC41BA806898A29E43261DBC85441C37D92E97ED80D323D44825FDDE8374D0FF15877798812682599B216BBCC31B9DCCAD527465FEAFFD7FC2A193612E575E34E7A98AF4D10339FE47390A518CB9975B3160B1D0285D1418D0977C52994F43C29A053E3D685834104C9FAFDC221E38BE9F3989D7A8E42"),
  1059  		},
  1060  		Y: bigFromHexString("59A27C269FCDE45AA2160A5C980C19211A820095091AB9C5DC8309AB7EC1B3A48C2E267C6D35FEE9B71BCBB92F16AC8E559129347FB5C00BEEDD10BA8915C90698755CA965735A32DC7575BED806E1E38F768FFBC24E41123DC73F1C6E9E4D0C9E692128853AFE29DC665FA993DCA9C903B7BF00B6442B9A76A5DADC6186317A"),
  1061  	}
  1062  	pemBlock, _ := pem.Decode([]byte(dsaCertPem))
  1063  	cert, err := ParseCertificate(pemBlock.Bytes)
  1064  	if err != nil {
  1065  		t.Fatalf("Failed to parse certificate: %s", err)
  1066  	}
  1067  	if cert.PublicKeyAlgorithm != DSA {
  1068  		t.Errorf("Parsed key algorithm was not DSA")
  1069  	}
  1070  	parsedKey, ok := cert.PublicKey.(*dsa.PublicKey)
  1071  	if !ok {
  1072  		t.Fatalf("Parsed key was not a DSA key: %s", err)
  1073  	}
  1074  	if expectedKey.Y.Cmp(parsedKey.Y) != 0 ||
  1075  		expectedKey.P.Cmp(parsedKey.P) != 0 ||
  1076  		expectedKey.Q.Cmp(parsedKey.Q) != 0 ||
  1077  		expectedKey.G.Cmp(parsedKey.G) != 0 {
  1078  		t.Fatal("Parsed key differs from expected key")
  1079  	}
  1080  }
  1081  
  1082  func TestParseCertificateWithDSASignatureAlgorithm(t *testing.T) {
  1083  	pemBlock, _ := pem.Decode([]byte(dsaCertPem))
  1084  	cert, err := ParseCertificate(pemBlock.Bytes)
  1085  	if err != nil {
  1086  		t.Fatalf("Failed to parse certificate: %s", err)
  1087  	}
  1088  	if cert.SignatureAlgorithm != DSAWithSHA1 {
  1089  		t.Errorf("Parsed signature algorithm was not DSAWithSHA1")
  1090  	}
  1091  }
  1092  
  1093  func TestVerifyCertificateWithDSASignature(t *testing.T) {
  1094  	pemBlock, _ := pem.Decode([]byte(dsaCertPem))
  1095  	cert, err := ParseCertificate(pemBlock.Bytes)
  1096  	if err != nil {
  1097  		t.Fatalf("Failed to parse certificate: %s", err)
  1098  	}
  1099  	// test cert is self-signed
  1100  	if err = cert.CheckSignatureFrom(cert); err == nil {
  1101  		t.Fatalf("Expected error verifying DSA certificate")
  1102  	}
  1103  }
  1104  
  1105  var rsaPSSSelfSignedPEM = `-----BEGIN CERTIFICATE-----
  1106  MIIGHjCCA9KgAwIBAgIBdjBBBgkqhkiG9w0BAQowNKAPMA0GCWCGSAFlAwQCAQUA
  1107  oRwwGgYJKoZIhvcNAQEIMA0GCWCGSAFlAwQCAQUAogMCASAwbjELMAkGA1UEBhMC
  1108  SlAxHDAaBgNVBAoME0phcGFuZXNlIEdvdmVybm1lbnQxKDAmBgNVBAsMH1RoZSBN
  1109  aW5pc3RyeSBvZiBGb3JlaWduIEFmZmFpcnMxFzAVBgNVBAMMDmUtcGFzc3BvcnRD
  1110  U0NBMB4XDTEzMDUxNDA1MDczMFoXDTI5MDUxNDA1MDczMFowbjELMAkGA1UEBhMC
  1111  SlAxHDAaBgNVBAoME0phcGFuZXNlIEdvdmVybm1lbnQxKDAmBgNVBAsMH1RoZSBN
  1112  aW5pc3RyeSBvZiBGb3JlaWduIEFmZmFpcnMxFzAVBgNVBAMMDmUtcGFzc3BvcnRD
  1113  U0NBMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEAx/E3WRVxcCDXhoST
  1114  8nVSLjW6hwM4Ni99AegWzcGtfGFo0zjFA1Cl5URqxauvYu3gQgQHBGA1CovWeGrl
  1115  yVSRzOL1imcYsSgLOcnhVYB3Xcrof4ebv9+W+TwNdc9YzAwcj8rNd5nP6PKXIQ+W
  1116  PCkEOXdyb80YEnxuT+NPjkVfFSPBS7QYZpvT2fwy4fZ0eh48253+7VleSmTO0mqj
  1117  7TlzaG56q150SLZbhpOd8jD8bM/wACnLCPR88wj4hCcDLEwoLyY85HJCTIQQMnoT
  1118  UpqyzEeupPREIm6yi4d8C9YqIWFn2YTnRcWcmMaJLzq+kYwKoudfnoC6RW2vzZXn
  1119  defQs68IZuK+uALu9G3JWGPgu0CQGj0JNDT8zkiDV++4eNrZczWKjr1YnAL+VbLK
  1120  bApwL2u19l2WDpfUklimhWfraqHNIUKU6CjZOG31RzXcplIj0mtqs0E1r7r357Es
  1121  yFoB28iNo4cz1lCulh0E4WJzWzLZcT4ZspHHRCFyvYnXoibXEV1nULq8ByKKG0FS
  1122  7nn4SseoV+8PvjHLPhmHGMvi4mxkbcXdV3wthHT1/HXdqY84A4xHWt1+sB/TpTek
  1123  tDhFlEfcUygvTu58UtOnysomOVVeERmi7WSujfzKsGJAJYeetiA5R+zX7BxeyFVE
  1124  qW0zh1Tkwh0S8LRe5diJh4+6FG0CAwEAAaNfMF0wHQYDVR0OBBYEFD+oahaikBTV
  1125  Urk81Uz7kRS2sx0aMA4GA1UdDwEB/wQEAwIBBjAYBgNVHSAEETAPMA0GCyqDCIaP
  1126  fgYFAQEBMBIGA1UdEwEB/wQIMAYBAf8CAQAwQQYJKoZIhvcNAQEKMDSgDzANBglg
  1127  hkgBZQMEAgEFAKEcMBoGCSqGSIb3DQEBCDANBglghkgBZQMEAgEFAKIDAgEgA4IC
  1128  AQAaxWBQn5CZuNBfyzL57mn31ukHUFd61OMROSX3PT7oCv1Dy+C2AdRlxOcbN3/n
  1129  li0yfXUUqiY3COlLAHKRlkr97mLtxEFoJ0R8nVN2IQdChNQM/XSCzSGyY8NVa1OR
  1130  TTpEWLnexJ9kvIdbFXwUqdTnAkOI0m7Rg8j+E+lRRHg1xDAA1qKttrtUj3HRQWf3
  1131  kNTu628SiMvap6aIdncburaK56MP7gkR1Wr/ichOfjIA3Jgw2PapI31i0GqeMd66
  1132  U1+lC9FeyMAJpuSVp/SoiYzYo+79SFcVoM2yw3yAnIKg7q9GLYYqzncdykT6C06c
  1133  15gWFI6igmReAsD9ITSvYh0jLrLHfEYcPTOD3ZXJ4EwwHtWSoO3gq1EAtOYKu/Lv
  1134  C8zfBsZcFdsHvsSiYeBU8Oioe42mguky3Ax9O7D805Ek6R68ra07MW/G4YxvV7IN
  1135  2BfSaYy8MX9IG0ZMIOcoc0FeF5xkFmJ7kdrlTaJzC0IE9PNxNaH5QnOAFB8vxHcO
  1136  FioUxb6UKdHcPLR1VZtAdTdTMjSJxUqD/35Cdfqs7oDJXz8f6TXO2Tdy6G++YUs9
  1137  qsGZWxzFvvkXUkQSl0dQQ5jO/FtUJcAVXVVp20LxPemfatAHpW31WdJYeWSQWky2
  1138  +f9b5TXKXVyjlUL7uHxowWrT2AtTchDH22wTEtqLEF9Z3Q==
  1139  -----END CERTIFICATE-----`
  1140  
  1141  // openssl req -newkey rsa:2048 -keyout test.key -sha256 -sigopt \
  1142  // rsa_padding_mode:pss -sigopt rsa_pss_saltlen:32 -sigopt rsa_mgf1_md:sha256 \
  1143  // -x509 -days 3650 -nodes -subj '/C=US/ST=CA/L=SF/O=Test/CN=Test' -out \
  1144  // test.pem
  1145  var rsaPSSSelfSignedOpenSSL110PEM = `-----BEGIN CERTIFICATE-----
  1146  MIIDwDCCAnigAwIBAgIJAM9LAMHTE5xpMD0GCSqGSIb3DQEBCjAwoA0wCwYJYIZI
  1147  AWUDBAIBoRowGAYJKoZIhvcNAQEIMAsGCWCGSAFlAwQCAaIDAgEgMEUxCzAJBgNV
  1148  BAYTAlVTMQswCQYDVQQIDAJDQTELMAkGA1UEBwwCU0YxDTALBgNVBAoMBFRlc3Qx
  1149  DTALBgNVBAMMBFRlc3QwHhcNMTgwMjIyMjIxMzE4WhcNMjgwMjIwMjIxMzE4WjBF
  1150  MQswCQYDVQQGEwJVUzELMAkGA1UECAwCQ0ExCzAJBgNVBAcMAlNGMQ0wCwYDVQQK
  1151  DARUZXN0MQ0wCwYDVQQDDARUZXN0MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB
  1152  CgKCAQEA4Zrsydod+GoTAJLLutWNF87qhhVPBsK1zB1Gj+NAAe4+VbrZ1E41H1wp
  1153  qITx7DA8DRtJEf+NqrTAnAdZWBG/tAOA5LfXVax0ZSQtLnYLSeylLoMtDyY3eFAj
  1154  TmuTOoyVy6raktowCnHCh01NsstqqTfrx6SbmzOmDmKTkq/I+7K0MCVsn41xRDVM
  1155  +ShD0WGFGioEGoiWnFSWupxJDA3Q6jIDEygVwNKHwnhv/2NgG2kqZzrZSQA67en0
  1156  iKAXtoDNPpmyD5oS9YbEJ+2Nbm7oLeON30i6kZvXKIzJXx+UWViazHZqnsi5rQ8G
  1157  RHF+iVFXsqd0MzDKmkKOT5FDhrsbKQIDAQABo1MwUTAdBgNVHQ4EFgQU9uFY/nlg
  1158  gLH00NBnr/o7QvpN9ugwHwYDVR0jBBgwFoAU9uFY/nlggLH00NBnr/o7QvpN9ugw
  1159  DwYDVR0TAQH/BAUwAwEB/zA9BgkqhkiG9w0BAQowMKANMAsGCWCGSAFlAwQCAaEa
  1160  MBgGCSqGSIb3DQEBCDALBglghkgBZQMEAgGiAwIBIAOCAQEAhJzpwxBNGKvzKWDe
  1161  WLqv6RMrl/q4GcH3b7M9wjxe0yOm4F+Tb2zJ7re4h+D39YkJf8cX1NV9UQVu6z4s
  1162  Fvo2kmlR0qZOXAg5augmCQ1xS0WHFoF6B52anNzHkZQbAIYJ3kGoFsUHzs7Sz7F/
  1163  656FsRpHA9UzJQ3avPPMrA4Y4aoJ7ANJ6XIwTrdWrhULOVuvYRLCl4CdTVztVFX6
  1164  wxX8nS1ISYd8jXPUMgsBKVbWufvLoIymMJW8CZbpprVZel5zFn0bmPrON8IHS30w
  1165  Gs+ITJjKEnZgXmAQ25SLKVzkZkBcGANs2GsdHNJ370Puisy0FIPD2NXR5uASAf7J
  1166  +w9fjQ==
  1167  -----END CERTIFICATE-----`
  1168  
  1169  func TestRSAPSSSelfSigned(t *testing.T) {
  1170  	for i, pemBlock := range []string{rsaPSSSelfSignedPEM, rsaPSSSelfSignedOpenSSL110PEM} {
  1171  		der, _ := pem.Decode([]byte(pemBlock))
  1172  		if der == nil {
  1173  			t.Errorf("#%d: failed to find PEM block", i)
  1174  			continue
  1175  		}
  1176  
  1177  		cert, err := ParseCertificate(der.Bytes)
  1178  		if err != nil {
  1179  			t.Errorf("#%d: failed to parse: %s", i, err)
  1180  			continue
  1181  		}
  1182  
  1183  		if err = cert.CheckSignatureFrom(cert); err != nil {
  1184  			t.Errorf("#%d: signature check failed: %s", i, err)
  1185  			continue
  1186  		}
  1187  	}
  1188  }
  1189  
  1190  const ed25519Certificate = `
  1191  Certificate:
  1192      Data:
  1193          Version: 3 (0x2)
  1194          Serial Number:
  1195              0c:83:d8:21:2b:82:cb:23:98:23:63:e2:f7:97:8a:43:5b:f3:bd:92
  1196          Signature Algorithm: ED25519
  1197          Issuer: CN = Ed25519 test certificate
  1198          Validity
  1199              Not Before: May  6 17:27:16 2019 GMT
  1200              Not After : Jun  5 17:27:16 2019 GMT
  1201          Subject: CN = Ed25519 test certificate
  1202          Subject Public Key Info:
  1203              Public Key Algorithm: ED25519
  1204                  ED25519 Public-Key:
  1205                  pub:
  1206                      36:29:c5:6c:0d:4f:14:6c:81:d0:ff:75:d3:6a:70:
  1207                      5f:69:cd:0f:4d:66:d5:da:98:7e:82:49:89:a3:8a:
  1208                      3c:fa
  1209          X509v3 extensions:
  1210              X509v3 Subject Key Identifier:
  1211                  09:3B:3A:9D:4A:29:D8:95:FF:68:BE:7B:43:54:72:E0:AD:A2:E3:AE
  1212              X509v3 Authority Key Identifier:
  1213                  keyid:09:3B:3A:9D:4A:29:D8:95:FF:68:BE:7B:43:54:72:E0:AD:A2:E3:AE
  1214  
  1215              X509v3 Basic Constraints: critical
  1216                  CA:TRUE
  1217      Signature Algorithm: ED25519
  1218           53:a5:58:1c:2c:3b:2a:9e:ac:9d:4e:a5:1d:5f:5d:6d:a6:b5:
  1219           08:de:12:82:f3:97:20:ae:fa:d8:98:f4:1a:83:32:6b:91:f5:
  1220           24:1d:c4:20:7f:2c:e2:4d:da:13:3b:6d:54:1a:d2:a8:28:dc:
  1221           60:b9:d4:f4:78:4b:3c:1c:91:00
  1222  -----BEGIN CERTIFICATE-----
  1223  MIIBWzCCAQ2gAwIBAgIUDIPYISuCyyOYI2Pi95eKQ1vzvZIwBQYDK2VwMCMxITAf
  1224  BgNVBAMMGEVkMjU1MTkgdGVzdCBjZXJ0aWZpY2F0ZTAeFw0xOTA1MDYxNzI3MTZa
  1225  Fw0xOTA2MDUxNzI3MTZaMCMxITAfBgNVBAMMGEVkMjU1MTkgdGVzdCBjZXJ0aWZp
  1226  Y2F0ZTAqMAUGAytlcAMhADYpxWwNTxRsgdD/ddNqcF9pzQ9NZtXamH6CSYmjijz6
  1227  o1MwUTAdBgNVHQ4EFgQUCTs6nUop2JX/aL57Q1Ry4K2i464wHwYDVR0jBBgwFoAU
  1228  CTs6nUop2JX/aL57Q1Ry4K2i464wDwYDVR0TAQH/BAUwAwEB/zAFBgMrZXADQQBT
  1229  pVgcLDsqnqydTqUdX11tprUI3hKC85cgrvrYmPQagzJrkfUkHcQgfyziTdoTO21U
  1230  GtKoKNxgudT0eEs8HJEA
  1231  -----END CERTIFICATE-----`
  1232  
  1233  func TestEd25519SelfSigned(t *testing.T) {
  1234  	der, _ := pem.Decode([]byte(ed25519Certificate))
  1235  	if der == nil {
  1236  		t.Fatalf("Failed to find PEM block")
  1237  	}
  1238  
  1239  	cert, err := ParseCertificate(der.Bytes)
  1240  	if err != nil {
  1241  		t.Fatalf("Failed to parse: %s", err)
  1242  	}
  1243  
  1244  	if cert.PublicKeyAlgorithm != Ed25519 {
  1245  		t.Fatalf("Parsed key algorithm was not Ed25519")
  1246  	}
  1247  	parsedKey, ok := cert.PublicKey.(ed25519.PublicKey)
  1248  	if !ok {
  1249  		t.Fatalf("Parsed key was not an Ed25519 key: %s", err)
  1250  	}
  1251  	if len(parsedKey) != ed25519.PublicKeySize {
  1252  		t.Fatalf("Invalid Ed25519 key")
  1253  	}
  1254  
  1255  	if err = cert.CheckSignatureFrom(cert); err != nil {
  1256  		t.Fatalf("Signature check failed: %s", err)
  1257  	}
  1258  }
  1259  
  1260  const pemCertificate = `-----BEGIN CERTIFICATE-----
  1261  MIIDATCCAemgAwIBAgIRAKQkkrFx1T/dgB/Go/xBM5swDQYJKoZIhvcNAQELBQAw
  1262  EjEQMA4GA1UEChMHQWNtZSBDbzAeFw0xNjA4MTcyMDM2MDdaFw0xNzA4MTcyMDM2
  1263  MDdaMBIxEDAOBgNVBAoTB0FjbWUgQ28wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw
  1264  ggEKAoIBAQDAoJtjG7M6InsWwIo+l3qq9u+g2rKFXNu9/mZ24XQ8XhV6PUR+5HQ4
  1265  jUFWC58ExYhottqK5zQtKGkw5NuhjowFUgWB/VlNGAUBHtJcWR/062wYrHBYRxJH
  1266  qVXOpYKbIWwFKoXu3hcpg/CkdOlDWGKoZKBCwQwUBhWE7MDhpVdQ+ZljUJWL+FlK
  1267  yQK5iRsJd5TGJ6VUzLzdT4fmN2DzeK6GLeyMpVpU3sWV90JJbxWQ4YrzkKzYhMmB
  1268  EcpXTG2wm+ujiHU/k2p8zlf8Sm7VBM/scmnMFt0ynNXop4FWvJzEm1G0xD2t+e2I
  1269  5Utr04dOZPCgkm++QJgYhtZvgW7ZZiGTAgMBAAGjUjBQMA4GA1UdDwEB/wQEAwIF
  1270  oDATBgNVHSUEDDAKBggrBgEFBQcDATAMBgNVHRMBAf8EAjAAMBsGA1UdEQQUMBKC
  1271  EHRlc3QuZXhhbXBsZS5jb20wDQYJKoZIhvcNAQELBQADggEBADpqKQxrthH5InC7
  1272  X96UP0OJCu/lLEMkrjoEWYIQaFl7uLPxKH5AmQPH4lYwF7u7gksR7owVG9QU9fs6
  1273  1fK7II9CVgCd/4tZ0zm98FmU4D0lHGtPARrrzoZaqVZcAvRnFTlPX5pFkPhVjjai
  1274  /mkxX9LpD8oK1445DFHxK5UjLMmPIIWd8EOi+v5a+hgGwnJpoW7hntSl8kHMtTmy
  1275  fnnktsblSUV4lRCit0ymC7Ojhe+gzCCwkgs5kDzVVag+tnl/0e2DloIjASwOhpbH
  1276  KVcg7fBd484ht/sS+l0dsB4KDOSpd8JzVDMF8OZqlaydizoJO0yWr9GbCN1+OKq5
  1277  EhLrEqU=
  1278  -----END CERTIFICATE-----`
  1279  
  1280  const ed25519CRLCertificate = `
  1281  Certificate:
  1282  Data:
  1283  	Version: 3 (0x2)
  1284  	Serial Number:
  1285  		7a:07:a0:9d:14:04:16:fc:1f:d8:e5:fe:d1:1d:1f:8d
  1286  	Signature Algorithm: ED25519
  1287  	Issuer: CN = Ed25519 CRL Test CA
  1288  	Validity
  1289  		Not Before: Oct 30 01:20:20 2019 GMT
  1290  		Not After : Dec 31 23:59:59 9999 GMT
  1291  	Subject: CN = Ed25519 CRL Test CA
  1292  	Subject Public Key Info:
  1293  		Public Key Algorithm: ED25519
  1294  			ED25519 Public-Key:
  1295  			pub:
  1296  				95:73:3b:b0:06:2a:31:5a:b6:a7:a6:6e:ef:71:df:
  1297  				ac:6f:6b:39:03:85:5e:63:4b:f8:a6:0f:68:c6:6f:
  1298  				75:21
  1299  	X509v3 extensions:
  1300  		X509v3 Key Usage: critical
  1301  			Digital Signature, Certificate Sign, CRL Sign
  1302  		X509v3 Extended Key Usage:
  1303  			TLS Web Client Authentication, TLS Web Server Authentication, OCSP Signing
  1304  		X509v3 Basic Constraints: critical
  1305  			CA:TRUE
  1306  		X509v3 Subject Key Identifier:
  1307  			B7:17:DA:16:EA:C5:ED:1F:18:49:44:D3:D2:E3:A0:35:0A:81:93:60
  1308  		X509v3 Authority Key Identifier:
  1309  			keyid:B7:17:DA:16:EA:C5:ED:1F:18:49:44:D3:D2:E3:A0:35:0A:81:93:60
  1310  
  1311  Signature Algorithm: ED25519
  1312  	 fc:3e:14:ea:bb:70:c2:6f:38:34:70:bc:c8:a7:f4:7c:0d:1e:
  1313  	 28:d7:2a:9f:22:8a:45:e8:02:76:84:1e:2d:64:2d:1e:09:b5:
  1314  	 29:71:1f:95:8a:4e:79:87:51:60:9a:e7:86:40:f6:60:c7:d1:
  1315  	 ee:68:76:17:1d:90:cc:92:93:07
  1316  -----BEGIN CERTIFICATE-----
  1317  MIIBijCCATygAwIBAgIQegegnRQEFvwf2OX+0R0fjTAFBgMrZXAwHjEcMBoGA1UE
  1318  AxMTRWQyNTUxOSBDUkwgVGVzdCBDQTAgFw0xOTEwMzAwMTIwMjBaGA85OTk5MTIz
  1319  MTIzNTk1OVowHjEcMBoGA1UEAxMTRWQyNTUxOSBDUkwgVGVzdCBDQTAqMAUGAytl
  1320  cAMhAJVzO7AGKjFatqembu9x36xvazkDhV5jS/imD2jGb3Uho4GNMIGKMA4GA1Ud
  1321  DwEB/wQEAwIBhjAnBgNVHSUEIDAeBggrBgEFBQcDAgYIKwYBBQUHAwEGCCsGAQUF
  1322  BwMJMA8GA1UdEwEB/wQFMAMBAf8wHQYDVR0OBBYEFLcX2hbqxe0fGElE09LjoDUK
  1323  gZNgMB8GA1UdIwQYMBaAFLcX2hbqxe0fGElE09LjoDUKgZNgMAUGAytlcANBAPw+
  1324  FOq7cMJvODRwvMin9HwNHijXKp8iikXoAnaEHi1kLR4JtSlxH5WKTnmHUWCa54ZA
  1325  9mDH0e5odhcdkMySkwc=
  1326  -----END CERTIFICATE-----`
  1327  
  1328  var ed25519CRLKey = testingKey(`-----BEGIN TEST KEY-----
  1329  MC4CAQAwBQYDK2VwBCIEINdKh2096vUBYu4EIFpjShsUSh3vimKya1sQ1YTT4RZG
  1330  -----END TEST KEY-----`)
  1331  
  1332  func TestCRLCreation(t *testing.T) {
  1333  	block, _ := pem.Decode([]byte(pemPrivateKey))
  1334  	privRSA, _ := ParsePKCS1PrivateKey(block.Bytes)
  1335  	block, _ = pem.Decode([]byte(pemCertificate))
  1336  	certRSA, _ := ParseCertificate(block.Bytes)
  1337  
  1338  	block, _ = pem.Decode([]byte(ed25519CRLKey))
  1339  	privEd25519, _ := ParsePKCS8PrivateKey(block.Bytes)
  1340  	block, _ = pem.Decode([]byte(ed25519CRLCertificate))
  1341  	certEd25519, _ := ParseCertificate(block.Bytes)
  1342  
  1343  	tests := []struct {
  1344  		name string
  1345  		priv any
  1346  		cert *Certificate
  1347  	}{
  1348  		{"RSA CA", privRSA, certRSA},
  1349  		{"Ed25519 CA", privEd25519, certEd25519},
  1350  	}
  1351  
  1352  	loc := time.FixedZone("Oz/Atlantis", int((2 * time.Hour).Seconds()))
  1353  
  1354  	now := time.Unix(1000, 0).In(loc)
  1355  	nowUTC := now.UTC()
  1356  	expiry := time.Unix(10000, 0)
  1357  
  1358  	revokedCerts := []pkix.RevokedCertificate{
  1359  		{
  1360  			SerialNumber:   big.NewInt(1),
  1361  			RevocationTime: nowUTC,
  1362  		},
  1363  		{
  1364  			SerialNumber: big.NewInt(42),
  1365  			// RevocationTime should be converted to UTC before marshaling.
  1366  			RevocationTime: now,
  1367  		},
  1368  	}
  1369  	expectedCerts := []pkix.RevokedCertificate{
  1370  		{
  1371  			SerialNumber:   big.NewInt(1),
  1372  			RevocationTime: nowUTC,
  1373  		},
  1374  		{
  1375  			SerialNumber:   big.NewInt(42),
  1376  			RevocationTime: nowUTC,
  1377  		},
  1378  	}
  1379  
  1380  	for _, test := range tests {
  1381  		crlBytes, err := test.cert.CreateCRL(rand.Reader, test.priv, revokedCerts, now, expiry)
  1382  		if err != nil {
  1383  			t.Errorf("%s: error creating CRL: %s", test.name, err)
  1384  			continue
  1385  		}
  1386  
  1387  		parsedCRL, err := ParseDERCRL(crlBytes)
  1388  		if err != nil {
  1389  			t.Errorf("%s: error reparsing CRL: %s", test.name, err)
  1390  			continue
  1391  		}
  1392  		if !reflect.DeepEqual(parsedCRL.TBSCertList.RevokedCertificates, expectedCerts) {
  1393  			t.Errorf("%s: RevokedCertificates mismatch: got %v; want %v.", test.name,
  1394  				parsedCRL.TBSCertList.RevokedCertificates, expectedCerts)
  1395  		}
  1396  	}
  1397  }
  1398  
  1399  func fromBase64(in string) []byte {
  1400  	out := make([]byte, base64.StdEncoding.DecodedLen(len(in)))
  1401  	n, err := base64.StdEncoding.Decode(out, []byte(in))
  1402  	if err != nil {
  1403  		panic("failed to base64 decode")
  1404  	}
  1405  	return out[:n]
  1406  }
  1407  
  1408  func TestParseDERCRL(t *testing.T) {
  1409  	derBytes := fromBase64(derCRLBase64)
  1410  	certList, err := ParseDERCRL(derBytes)
  1411  	if err != nil {
  1412  		t.Errorf("error parsing: %s", err)
  1413  		return
  1414  	}
  1415  	numCerts := len(certList.TBSCertList.RevokedCertificates)
  1416  	expected := 88
  1417  	if numCerts != expected {
  1418  		t.Errorf("bad number of revoked certificates. got: %d want: %d", numCerts, expected)
  1419  	}
  1420  
  1421  	if certList.HasExpired(time.Unix(1302517272, 0)) {
  1422  		t.Errorf("CRL has expired (but shouldn't have)")
  1423  	}
  1424  
  1425  	// Can't check the signature here without a package cycle.
  1426  }
  1427  
  1428  func TestCRLWithoutExpiry(t *testing.T) {
  1429  	derBytes := fromBase64("MIHYMIGZMAkGByqGSM44BAMwEjEQMA4GA1UEAxMHQ2FybERTUxcNOTkwODI3MDcwMDAwWjBpMBMCAgDIFw05OTA4MjIwNzAwMDBaMBMCAgDJFw05OTA4MjIwNzAwMDBaMBMCAgDTFw05OTA4MjIwNzAwMDBaMBMCAgDSFw05OTA4MjIwNzAwMDBaMBMCAgDUFw05OTA4MjQwNzAwMDBaMAkGByqGSM44BAMDLwAwLAIUfmVSdjP+NHMX0feW+aDU2G1cfT0CFAJ6W7fVWxjBz4fvftok8yqDnDWh")
  1430  	certList, err := ParseDERCRL(derBytes)
  1431  	if err != nil {
  1432  		t.Fatal(err)
  1433  	}
  1434  	if !certList.TBSCertList.NextUpdate.IsZero() {
  1435  		t.Errorf("NextUpdate is not the zero value")
  1436  	}
  1437  }
  1438  
  1439  func TestParsePEMCRL(t *testing.T) {
  1440  	pemBytes := fromBase64(pemCRLBase64)
  1441  	certList, err := ParseCRL(pemBytes)
  1442  	if err != nil {
  1443  		t.Errorf("error parsing: %s", err)
  1444  		return
  1445  	}
  1446  	numCerts := len(certList.TBSCertList.RevokedCertificates)
  1447  	expected := 2
  1448  	if numCerts != expected {
  1449  		t.Errorf("bad number of revoked certificates. got: %d want: %d", numCerts, expected)
  1450  	}
  1451  
  1452  	if certList.HasExpired(time.Unix(1302517272, 0)) {
  1453  		t.Errorf("CRL has expired (but shouldn't have)")
  1454  	}
  1455  
  1456  	// Can't check the signature here without a package cycle.
  1457  }
  1458  
  1459  func TestImports(t *testing.T) {
  1460  	if testing.Short() {
  1461  		t.Skip("skipping in -short mode")
  1462  	}
  1463  	if out, err := testenv.Command(t, testenv.GoToolPath(t), "run", "x509_test_import.go").CombinedOutput(); err != nil {
  1464  		t.Errorf("failed to run x509_test_import.go: %s\n%s", err, out)
  1465  	}
  1466  }
  1467  
  1468  const derCRLBase64 = "MIINqzCCDJMCAQEwDQYJKoZIhvcNAQEFBQAwVjEZMBcGA1UEAxMQUEtJIEZJTk1FQ0NBTklDQTEVMBMGA1UEChMMRklOTUVDQ0FOSUNBMRUwEwYDVQQLEwxGSU5NRUNDQU5JQ0ExCzAJBgNVBAYTAklUFw0xMTA1MDQxNjU3NDJaFw0xMTA1MDQyMDU3NDJaMIIMBzAhAg4Ze1od49Lt1qIXBydAzhcNMDkwNzE2MDg0MzIyWjAAMCECDl0HSL9bcZ1Ci/UHJ0DPFw0wOTA3MTYwODQzMTNaMAAwIQIOESB9tVAmX3cY7QcnQNAXDTA5MDcxNjA4NDUyMlowADAhAg4S1tGAQ3mHt8uVBydA1RcNMDkwODA0MTUyNTIyWjAAMCECDlQ249Y7vtC25ScHJ0DWFw0wOTA4MDQxNTI1MzdaMAAwIQIOISMop3NkA4PfYwcnQNkXDTA5MDgwNDExMDAzNFowADAhAg56/BMoS29KEShTBydA2hcNMDkwODA0MTEwMTAzWjAAMCECDnBp/22HPH5CSWoHJ0DbFw0wOTA4MDQxMDU0NDlaMAAwIQIOV9IP+8CD8bK+XAcnQNwXDTA5MDgwNDEwNTcxN1owADAhAg4v5aRz0IxWqYiXBydA3RcNMDkwODA0MTA1NzQ1WjAAMCECDlOU34VzvZAybQwHJ0DeFw0wOTA4MDQxMDU4MjFaMAAwIAINO4CD9lluIxcwBydBAxcNMDkwNzIyMTUzMTU5WjAAMCECDgOllfO8Y1QA7/wHJ0ExFw0wOTA3MjQxMTQxNDNaMAAwIQIOJBX7jbiCdRdyjgcnQUQXDTA5MDkxNjA5MzAwOFowADAhAg5iYSAgmDrlH/RZBydBRRcNMDkwOTE2MDkzMDE3WjAAMCECDmu6k6srP3jcMaQHJ0FRFw0wOTA4MDQxMDU2NDBaMAAwIQIOX8aHlO0V+WVH4QcnQVMXDTA5MDgwNDEwNTcyOVowADAhAg5flK2rg3NnsRgDBydBzhcNMTEwMjAxMTUzMzQ2WjAAMCECDg35yJDL1jOPTgoHJ0HPFw0xMTAyMDExNTM0MjZaMAAwIQIOMyFJ6+e9iiGVBQcnQdAXDTA5MDkxODEzMjAwNVowADAhAg5Emb/Oykucmn8fBydB1xcNMDkwOTIxMTAxMDQ3WjAAMCECDjQKCncV+MnUavMHJ0HaFw0wOTA5MjIwODE1MjZaMAAwIQIOaxiFUt3dpd+tPwcnQfQXDTEwMDYxODA4NDI1MVowADAhAg5G7P8nO0tkrMt7BydB9RcNMTAwNjE4MDg0MjMwWjAAMCECDmTCC3SXhmDRst4HJ0H2Fw0wOTA5MjgxMjA3MjBaMAAwIQIOHoGhUr/pRwzTKgcnQfcXDTA5MDkyODEyMDcyNFowADAhAg50wrcrCiw8mQmPBydCBBcNMTAwMjE2MTMwMTA2WjAAMCECDifWmkvwyhEqwEcHJ0IFFw0xMDAyMTYxMzAxMjBaMAAwIQIOfgPmlW9fg+osNgcnQhwXDTEwMDQxMzA5NTIwMFowADAhAg4YHAGuA6LgCk7tBydCHRcNMTAwNDEzMDk1MTM4WjAAMCECDi1zH1bxkNJhokAHJ0IsFw0xMDA0MTMwOTU5MzBaMAAwIQIOMipNccsb/wo2fwcnQi0XDTEwMDQxMzA5NTkwMFowADAhAg46lCmvPl4GpP6ABydCShcNMTAwMTE5MDk1MjE3WjAAMCECDjaTcaj+wBpcGAsHJ0JLFw0xMDAxMTkwOTUyMzRaMAAwIQIOOMC13EOrBuxIOQcnQloXDTEwMDIwMTA5NDcwNVowADAhAg5KmZl+krz4RsmrBydCWxcNMTAwMjAxMDk0NjQwWjAAMCECDmLG3zQJ/fzdSsUHJ0JiFw0xMDAzMDEwOTUxNDBaMAAwIQIOP39ksgHdojf4owcnQmMXDTEwMDMwMTA5NTExN1owADAhAg4LDQzvWNRlD6v9BydCZBcNMTAwMzAxMDk0NjIyWjAAMCECDkmNfeclaFhIaaUHJ0JlFw0xMDAzMDEwOTQ2MDVaMAAwIQIOT/qWWfpH/m8NTwcnQpQXDTEwMDUxMTA5MTgyMVowADAhAg5m/ksYxvCEgJSvBydClRcNMTAwNTExMDkxODAxWjAAMCECDgvf3Ohq6JOPU9AHJ0KWFw0xMDA1MTEwOTIxMjNaMAAwIQIOKSPas10z4jNVIQcnQpcXDTEwMDUxMTA5MjEwMlowADAhAg4mCWmhoZ3lyKCDBydCohcNMTEwNDI4MTEwMjI1WjAAMCECDkeiyRsBMK0Gvr4HJ0KjFw0xMTA0MjgxMTAyMDdaMAAwIQIOa09b/nH2+55SSwcnQq4XDTExMDQwMTA4Mjk0NlowADAhAg5O7M7iq7gGplr1BydCrxcNMTEwNDAxMDgzMDE3WjAAMCECDjlT6mJxUjTvyogHJ0K1Fw0xMTAxMjcxNTQ4NTJaMAAwIQIODS/l4UUFLe21NAcnQrYXDTExMDEyNzE1NDgyOFowADAhAg5lPRA0XdOUF6lSBydDHhcNMTEwMTI4MTQzNTA1WjAAMCECDixKX4fFGGpENwgHJ0MfFw0xMTAxMjgxNDM1MzBaMAAwIQIORNBkqsPnpKTtbAcnQ08XDTEwMDkwOTA4NDg0MlowADAhAg5QL+EMM3lohedEBydDUBcNMTAwOTA5MDg0ODE5WjAAMCECDlhDnHK+HiTRAXcHJ0NUFw0xMDEwMTkxNjIxNDBaMAAwIQIOdBFqAzq/INz53gcnQ1UXDTEwMTAxOTE2MjA0NFowADAhAg4OjR7s8MgKles1BydDWhcNMTEwMTI3MTY1MzM2WjAAMCECDmfR/elHee+d0SoHJ0NbFw0xMTAxMjcxNjUzNTZaMAAwIQIOBTKv2ui+KFMI+wcnQ5YXDTEwMDkxNTEwMjE1N1owADAhAg49F3c/GSah+oRUBydDmxcNMTEwMTI3MTczMjMzWjAAMCECDggv4I61WwpKFMMHJ0OcFw0xMTAxMjcxNzMyNTVaMAAwIQIOXx/Y8sEvwS10LAcnQ6UXDTExMDEyODExMjkzN1owADAhAg5LSLbnVrSKaw/9BydDphcNMTEwMTI4MTEyOTIwWjAAMCECDmFFoCuhKUeACQQHJ0PfFw0xMTAxMTExMDE3MzdaMAAwIQIOQTDdFh2fSPF6AAcnQ+AXDTExMDExMTEwMTcxMFowADAhAg5B8AOXX61FpvbbBydD5RcNMTAxMDA2MTAxNDM2WjAAMCECDh41P2Gmi7PkwI4HJ0PmFw0xMDEwMDYxMDE2MjVaMAAwIQIOWUHGLQCd+Ale9gcnQ/0XDTExMDUwMjA3NTYxMFowADAhAg5Z2c9AYkikmgWOBydD/hcNMTEwNTAyMDc1NjM0WjAAMCECDmf/UD+/h8nf+74HJ0QVFw0xMTA0MTUwNzI4MzNaMAAwIQIOICvj4epy3MrqfwcnRBYXDTExMDQxNTA3Mjg1NlowADAhAg4bouRMfOYqgv4xBydEHxcNMTEwMzA4MTYyNDI1WjAAMCECDhebWHGoKiTp7pEHJ0QgFw0xMTAzMDgxNjI0NDhaMAAwIQIOX+qnxxAqJ8LtawcnRDcXDTExMDEzMTE1MTIyOFowADAhAg4j0fICqZ+wkOdqBydEOBcNMTEwMTMxMTUxMTQxWjAAMCECDhmXjsV4SUpWtAMHJ0RLFw0xMTAxMjgxMTI0MTJaMAAwIQIODno/w+zG43kkTwcnREwXDTExMDEyODExMjM1MlowADAhAg4b1gc88767Fr+LBydETxcNMTEwMTI4MTEwMjA4WjAAMCECDn+M3Pa1w2nyFeUHJ0RQFw0xMTAxMjgxMDU4NDVaMAAwIQIOaduoyIH61tqybAcnRJUXDTEwMTIxNTA5NDMyMlowADAhAg4nLqQPkyi3ESAKBydElhcNMTAxMjE1MDk0MzM2WjAAMCECDi504NIMH8578gQHJ0SbFw0xMTAyMTQxNDA1NDFaMAAwIQIOGuaM8PDaC5u1egcnRJwXDTExMDIxNDE0MDYwNFowADAhAg4ehYq/BXGnB5PWBydEnxcNMTEwMjA0MDgwOTUxWjAAMCECDkSD4eS4FxW5H20HJ0SgFw0xMTAyMDQwODA5MjVaMAAwIQIOOCcb6ilYObt1egcnRKEXDTExMDEyNjEwNDEyOVowADAhAg58tISWCCwFnKGnBydEohcNMTEwMjA0MDgxMzQyWjAAMCECDn5rjtabY/L/WL0HJ0TJFw0xMTAyMDQxMTAzNDFaMAAwDQYJKoZIhvcNAQEFBQADggEBAGnF2Gs0+LNiYCW1Ipm83OXQYP/bd5tFFRzyz3iepFqNfYs4D68/QihjFoRHQoXEB0OEe1tvaVnnPGnEOpi6krwekquMxo4H88B5SlyiFIqemCOIss0SxlCFs69LmfRYvPPvPEhoXtQ3ZThe0UvKG83GOklhvGl6OaiRf4Mt+m8zOT4Wox/j6aOBK6cw6qKCdmD+Yj1rrNqFGg1CnSWMoD6S6mwNgkzwdBUJZ22BwrzAAo4RHa2Uy3ef1FjwD0XtU5N3uDSxGGBEDvOe5z82rps3E22FpAA8eYl8kaXtmWqyvYU0epp4brGuTxCuBMCAsxt/OjIjeNNQbBGkwxgfYA0="
  1469  
  1470  const pemCRLBase64 = "LS0tLS1CRUdJTiBYNTA5IENSTC0tLS0tDQpNSUlCOWpDQ0FWOENBUUV3RFFZSktvWklodmNOQVFFRkJRQXdiREVhTUJnR0ExVUVDaE1SVWxOQklGTmxZM1Z5DQphWFI1SUVsdVl5NHhIakFjQmdOVkJBTVRGVkpUUVNCUWRXSnNhV01nVW05dmRDQkRRU0IyTVRFdU1Dd0dDU3FHDQpTSWIzRFFFSkFSWWZjbk5oYTJWdmJuSnZiM1J6YVdkdVFISnpZWE5sWTNWeWFYUjVMbU52YlJjTk1URXdNakl6DQpNVGt5T0RNd1doY05NVEV3T0RJeU1Ua3lPRE13V2pDQmpEQktBaEVBckRxb2g5RkhKSFhUN09QZ3V1bjQrQmNODQpNRGt4TVRBeU1UUXlOekE1V2pBbU1Bb0dBMVVkRlFRRENnRUpNQmdHQTFVZEdBUVJHQTh5TURBNU1URXdNakUwDQpNalExTlZvd1BnSVJBTEd6blowOTVQQjVhQU9MUGc1N2ZNTVhEVEF5TVRBeU16RTBOVEF4TkZvd0dqQVlCZ05WDQpIUmdFRVJnUE1qQXdNakV3TWpNeE5EVXdNVFJhb0RBd0xqQWZCZ05WSFNNRUdEQVdnQlQxVERGNlVRTS9MTmVMDQpsNWx2cUhHUXEzZzltekFMQmdOVkhSUUVCQUlDQUlRd0RRWUpLb1pJaHZjTkFRRUZCUUFEZ1lFQUZVNUFzNk16DQpxNVBSc2lmYW9iUVBHaDFhSkx5QytNczVBZ2MwYld5QTNHQWR4dXI1U3BQWmVSV0NCamlQL01FSEJXSkNsQkhQDQpHUmNxNXlJZDNFakRrYUV5eFJhK2k2N0x6dmhJNmMyOUVlNks5cFNZd2ppLzdSVWhtbW5Qclh0VHhsTDBsckxyDQptUVFKNnhoRFJhNUczUUE0Q21VZHNITnZicnpnbUNZcHZWRT0NCi0tLS0tRU5EIFg1MDkgQ1JMLS0tLS0NCg0K"
  1471  
  1472  func TestCreateCertificateRequest(t *testing.T) {
  1473  	random := rand.Reader
  1474  
  1475  	ecdsa256Priv, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
  1476  	if err != nil {
  1477  		t.Fatalf("Failed to generate ECDSA key: %s", err)
  1478  	}
  1479  
  1480  	ecdsa384Priv, err := ecdsa.GenerateKey(elliptic.P384(), rand.Reader)
  1481  	if err != nil {
  1482  		t.Fatalf("Failed to generate ECDSA key: %s", err)
  1483  	}
  1484  
  1485  	ecdsa521Priv, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader)
  1486  	if err != nil {
  1487  		t.Fatalf("Failed to generate ECDSA key: %s", err)
  1488  	}
  1489  
  1490  	_, ed25519Priv, err := ed25519.GenerateKey(random)
  1491  	if err != nil {
  1492  		t.Fatalf("Failed to generate Ed25519 key: %s", err)
  1493  	}
  1494  
  1495  	tests := []struct {
  1496  		name    string
  1497  		priv    any
  1498  		sigAlgo SignatureAlgorithm
  1499  	}{
  1500  		{"RSA", testPrivateKey, SHA256WithRSA},
  1501  		{"RSA-PSS-SHA256", testPrivateKey, SHA256WithRSAPSS},
  1502  		{"ECDSA-256", ecdsa256Priv, ECDSAWithSHA256},
  1503  		{"ECDSA-384", ecdsa384Priv, ECDSAWithSHA256},
  1504  		{"ECDSA-521", ecdsa521Priv, ECDSAWithSHA256},
  1505  		{"Ed25519", ed25519Priv, PureEd25519},
  1506  	}
  1507  
  1508  	for _, test := range tests {
  1509  		template := CertificateRequest{
  1510  			Subject: pkix.Name{
  1511  				CommonName:   "test.example.com",
  1512  				Organization: []string{"Σ Acme Co"},
  1513  			},
  1514  			SignatureAlgorithm: test.sigAlgo,
  1515  			DNSNames:           []string{"test.example.com"},
  1516  			EmailAddresses:     []string{"gopher@golang.org"},
  1517  			IPAddresses:        []net.IP{net.IPv4(127, 0, 0, 1).To4(), net.ParseIP("2001:4860:0:2001::68")},
  1518  		}
  1519  
  1520  		derBytes, err := CreateCertificateRequest(random, &template, test.priv)
  1521  		if err != nil {
  1522  			t.Errorf("%s: failed to create certificate request: %s", test.name, err)
  1523  			continue
  1524  		}
  1525  
  1526  		out, err := ParseCertificateRequest(derBytes)
  1527  		if err != nil {
  1528  			t.Errorf("%s: failed to create certificate request: %s", test.name, err)
  1529  			continue
  1530  		}
  1531  
  1532  		err = out.CheckSignature()
  1533  		if err != nil {
  1534  			t.Errorf("%s: failed to check certificate request signature: %s", test.name, err)
  1535  			continue
  1536  		}
  1537  
  1538  		if out.Subject.CommonName != template.Subject.CommonName {
  1539  			t.Errorf("%s: output subject common name and template subject common name don't match", test.name)
  1540  		} else if len(out.Subject.Organization) != len(template.Subject.Organization) {
  1541  			t.Errorf("%s: output subject organisation and template subject organisation don't match", test.name)
  1542  		} else if len(out.DNSNames) != len(template.DNSNames) {
  1543  			t.Errorf("%s: output DNS names and template DNS names don't match", test.name)
  1544  		} else if len(out.EmailAddresses) != len(template.EmailAddresses) {
  1545  			t.Errorf("%s: output email addresses and template email addresses don't match", test.name)
  1546  		} else if len(out.IPAddresses) != len(template.IPAddresses) {
  1547  			t.Errorf("%s: output IP addresses and template IP addresses names don't match", test.name)
  1548  		}
  1549  	}
  1550  }
  1551  
  1552  func marshalAndParseCSR(t *testing.T, template *CertificateRequest) *CertificateRequest {
  1553  	t.Helper()
  1554  	derBytes, err := CreateCertificateRequest(rand.Reader, template, testPrivateKey)
  1555  	if err != nil {
  1556  		t.Fatal(err)
  1557  	}
  1558  
  1559  	csr, err := ParseCertificateRequest(derBytes)
  1560  	if err != nil {
  1561  		t.Fatal(err)
  1562  	}
  1563  
  1564  	return csr
  1565  }
  1566  
  1567  func TestCertificateRequestOverrides(t *testing.T) {
  1568  	sanContents, err := marshalSANs([]string{"foo.example.com"}, nil, nil, nil)
  1569  	if err != nil {
  1570  		t.Fatal(err)
  1571  	}
  1572  
  1573  	template := CertificateRequest{
  1574  		Subject: pkix.Name{
  1575  			CommonName:   "test.example.com",
  1576  			Organization: []string{"Σ Acme Co"},
  1577  		},
  1578  		DNSNames: []string{"test.example.com"},
  1579  
  1580  		// An explicit extension should override the DNSNames from the
  1581  		// template.
  1582  		ExtraExtensions: []pkix.Extension{
  1583  			{
  1584  				Id:       oidExtensionSubjectAltName,
  1585  				Value:    sanContents,
  1586  				Critical: true,
  1587  			},
  1588  		},
  1589  	}
  1590  
  1591  	csr := marshalAndParseCSR(t, &template)
  1592  
  1593  	if len(csr.DNSNames) != 1 || csr.DNSNames[0] != "foo.example.com" {
  1594  		t.Errorf("Extension did not override template. Got %v\n", csr.DNSNames)
  1595  	}
  1596  
  1597  	if len(csr.Extensions) != 1 || !csr.Extensions[0].Id.Equal(oidExtensionSubjectAltName) || !csr.Extensions[0].Critical {
  1598  		t.Errorf("SAN extension was not faithfully copied, got %#v", csr.Extensions)
  1599  	}
  1600  
  1601  	// If there is already an attribute with X.509 extensions then the
  1602  	// extra extensions should be added to it rather than creating a CSR
  1603  	// with two extension attributes.
  1604  
  1605  	template.Attributes = []pkix.AttributeTypeAndValueSET{
  1606  		{
  1607  			Type: oidExtensionRequest,
  1608  			Value: [][]pkix.AttributeTypeAndValue{
  1609  				{
  1610  					{
  1611  						Type:  oidExtensionAuthorityInfoAccess,
  1612  						Value: []byte("foo"),
  1613  					},
  1614  				},
  1615  			},
  1616  		},
  1617  	}
  1618  
  1619  	csr = marshalAndParseCSR(t, &template)
  1620  	if l := len(csr.Attributes); l != 1 {
  1621  		t.Errorf("incorrect number of attributes: %d\n", l)
  1622  	}
  1623  
  1624  	if !csr.Attributes[0].Type.Equal(oidExtensionRequest) ||
  1625  		len(csr.Attributes[0].Value) != 1 ||
  1626  		len(csr.Attributes[0].Value[0]) != 2 {
  1627  		t.Errorf("bad attributes: %#v\n", csr.Attributes)
  1628  	}
  1629  
  1630  	sanContents2, err := marshalSANs([]string{"foo2.example.com"}, nil, nil, nil)
  1631  	if err != nil {
  1632  		t.Fatal(err)
  1633  	}
  1634  
  1635  	// Extensions in Attributes should override those in ExtraExtensions.
  1636  	template.Attributes[0].Value[0] = append(template.Attributes[0].Value[0], pkix.AttributeTypeAndValue{
  1637  		Type:  oidExtensionSubjectAltName,
  1638  		Value: sanContents2,
  1639  	})
  1640  
  1641  	csr = marshalAndParseCSR(t, &template)
  1642  
  1643  	if len(csr.DNSNames) != 1 || csr.DNSNames[0] != "foo2.example.com" {
  1644  		t.Errorf("Attributes did not override ExtraExtensions. Got %v\n", csr.DNSNames)
  1645  	}
  1646  }
  1647  
  1648  func TestParseCertificateRequest(t *testing.T) {
  1649  	for _, csrBase64 := range csrBase64Array {
  1650  		csrBytes := fromBase64(csrBase64)
  1651  		csr, err := ParseCertificateRequest(csrBytes)
  1652  		if err != nil {
  1653  			t.Fatalf("failed to parse CSR: %s", err)
  1654  		}
  1655  
  1656  		if len(csr.EmailAddresses) != 1 || csr.EmailAddresses[0] != "gopher@golang.org" {
  1657  			t.Errorf("incorrect email addresses found: %v", csr.EmailAddresses)
  1658  		}
  1659  
  1660  		if len(csr.DNSNames) != 1 || csr.DNSNames[0] != "test.example.com" {
  1661  			t.Errorf("incorrect DNS names found: %v", csr.DNSNames)
  1662  		}
  1663  
  1664  		if len(csr.Subject.Country) != 1 || csr.Subject.Country[0] != "AU" {
  1665  			t.Errorf("incorrect Subject name: %v", csr.Subject)
  1666  		}
  1667  
  1668  		found := false
  1669  		for _, e := range csr.Extensions {
  1670  			if e.Id.Equal(oidExtensionBasicConstraints) {
  1671  				found = true
  1672  				break
  1673  			}
  1674  		}
  1675  		if !found {
  1676  			t.Errorf("basic constraints extension not found in CSR")
  1677  		}
  1678  	}
  1679  }
  1680  
  1681  func TestCriticalFlagInCSRRequestedExtensions(t *testing.T) {
  1682  	// This CSR contains an extension request where the extensions have a
  1683  	// critical flag in them. In the past we failed to handle this.
  1684  	const csrBase64 = "MIICrTCCAZUCAQIwMzEgMB4GA1UEAwwXU0NFUCBDQSBmb3IgRGV2ZWxlciBTcmwxDzANBgNVBAsMBjQzNTk3MTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALFMAJ7Zy9YyfgbNlbUWAW0LalNRMPs7aXmLANsCpjhnw3lLlfDPaLeWyKh1nK5I5ojaJOW6KIOSAcJkDUe3rrE0wR0RVt3UxArqs0R/ND3u5Q+bDQY2X1HAFUHzUzcdm5JRAIA355v90teMckaWAIlkRQjDE22Lzc6NAl64KOd1rqOUNj8+PfX6fSo20jm94Pp1+a6mfk3G/RUWVuSm7owO5DZI/Fsi2ijdmb4NUar6K/bDKYTrDFkzcqAyMfP3TitUtBp19Mp3B1yAlHjlbp/r5fSSXfOGHZdgIvp0WkLuK2u5eQrX5l7HMB/5epgUs3HQxKY6ljhh5wAjDwz//LsCAwEAAaA1MDMGCSqGSIb3DQEJDjEmMCQwEgYDVR0TAQH/BAgwBgEB/wIBADAOBgNVHQ8BAf8EBAMCAoQwDQYJKoZIhvcNAQEFBQADggEBAAMq3bxJSPQEgzLYR/yaVvgjCDrc3zUbIwdOis6Go06Q4RnjH5yRaSZAqZQTDsPurQcnz2I39VMGEiSkFJFavf4QHIZ7QFLkyXadMtALc87tm17Ej719SbHcBSSZayR9VYJUNXRLayI6HvyUrmqcMKh+iX3WY3ICr59/wlM0tYa8DYN4yzmOa2Onb29gy3YlaF5A2AKAMmk003cRT9gY26mjpv7d21czOSSeNyVIoZ04IR9ee71vWTMdv0hu/af5kSjQ+ZG5/Qgc0+mnECLz/1gtxt1srLYbtYQ/qAY8oX1DCSGFS61tN/vl+4cxGMD/VGcGzADRLRHSlVqy2Qgss6Q="
  1685  
  1686  	csrBytes := fromBase64(csrBase64)
  1687  	csr, err := ParseCertificateRequest(csrBytes)
  1688  	if err != nil {
  1689  		t.Fatalf("failed to parse CSR: %s", err)
  1690  	}
  1691  
  1692  	expected := []struct {
  1693  		Id    asn1.ObjectIdentifier
  1694  		Value []byte
  1695  	}{
  1696  		{oidExtensionBasicConstraints, fromBase64("MAYBAf8CAQA=")},
  1697  		{oidExtensionKeyUsage, fromBase64("AwIChA==")},
  1698  	}
  1699  
  1700  	if n := len(csr.Extensions); n != len(expected) {
  1701  		t.Fatalf("expected to find %d extensions but found %d", len(expected), n)
  1702  	}
  1703  
  1704  	for i, extension := range csr.Extensions {
  1705  		if !extension.Id.Equal(expected[i].Id) {
  1706  			t.Fatalf("extension #%d has unexpected type %v (expected %v)", i, extension.Id, expected[i].Id)
  1707  		}
  1708  
  1709  		if !bytes.Equal(extension.Value, expected[i].Value) {
  1710  			t.Fatalf("extension #%d has unexpected contents %x (expected %x)", i, extension.Value, expected[i].Value)
  1711  		}
  1712  	}
  1713  }
  1714  
  1715  // serialiseAndParse generates a self-signed certificate from template and
  1716  // returns a parsed version of it.
  1717  func serialiseAndParse(t *testing.T, template *Certificate) *Certificate {
  1718  	t.Helper()
  1719  	derBytes, err := CreateCertificate(rand.Reader, template, template, &testPrivateKey.PublicKey, testPrivateKey)
  1720  	if err != nil {
  1721  		t.Fatalf("failed to create certificate: %s", err)
  1722  		return nil
  1723  	}
  1724  
  1725  	cert, err := ParseCertificate(derBytes)
  1726  	if err != nil {
  1727  		t.Fatalf("failed to parse certificate: %s", err)
  1728  		return nil
  1729  	}
  1730  
  1731  	return cert
  1732  }
  1733  
  1734  func TestMaxPathLenNotCA(t *testing.T) {
  1735  	template := &Certificate{
  1736  		SerialNumber: big.NewInt(1),
  1737  		Subject: pkix.Name{
  1738  			CommonName: "Σ Acme Co",
  1739  		},
  1740  		NotBefore: time.Unix(1000, 0),
  1741  		NotAfter:  time.Unix(100000, 0),
  1742  
  1743  		BasicConstraintsValid: true,
  1744  		IsCA:                  false,
  1745  	}
  1746  	if m := serialiseAndParse(t, template).MaxPathLen; m != -1 {
  1747  		t.Errorf("MaxPathLen should be -1 when IsCa is false, got %d", m)
  1748  	}
  1749  
  1750  	template.MaxPathLen = -1
  1751  	if m := serialiseAndParse(t, template).MaxPathLen; m != -1 {
  1752  		t.Errorf("MaxPathLen should be -1 when IsCa is false and MaxPathLen set to -1, got %d", m)
  1753  	}
  1754  
  1755  	template.MaxPathLen = 5
  1756  	if _, err := CreateCertificate(rand.Reader, template, template, &testPrivateKey.PublicKey, testPrivateKey); err == nil {
  1757  		t.Error("specifying a MaxPathLen when IsCA is false should fail")
  1758  	}
  1759  
  1760  	template.MaxPathLen = 0
  1761  	template.MaxPathLenZero = true
  1762  	if _, err := CreateCertificate(rand.Reader, template, template, &testPrivateKey.PublicKey, testPrivateKey); err == nil {
  1763  		t.Error("setting MaxPathLenZero when IsCA is false should fail")
  1764  	}
  1765  
  1766  	template.BasicConstraintsValid = false
  1767  	if m := serialiseAndParse(t, template).MaxPathLen; m != 0 {
  1768  		t.Errorf("Bad MaxPathLen should be ignored if BasicConstraintsValid is false, got %d", m)
  1769  	}
  1770  }
  1771  
  1772  func TestMaxPathLen(t *testing.T) {
  1773  	template := &Certificate{
  1774  		SerialNumber: big.NewInt(1),
  1775  		Subject: pkix.Name{
  1776  			CommonName: "Σ Acme Co",
  1777  		},
  1778  		NotBefore: time.Unix(1000, 0),
  1779  		NotAfter:  time.Unix(100000, 0),
  1780  
  1781  		BasicConstraintsValid: true,
  1782  		IsCA:                  true,
  1783  	}
  1784  
  1785  	cert1 := serialiseAndParse(t, template)
  1786  	if m := cert1.MaxPathLen; m != -1 {
  1787  		t.Errorf("Omitting MaxPathLen didn't turn into -1, got %d", m)
  1788  	}
  1789  	if cert1.MaxPathLenZero {
  1790  		t.Errorf("Omitting MaxPathLen resulted in MaxPathLenZero")
  1791  	}
  1792  
  1793  	template.MaxPathLen = 1
  1794  	cert2 := serialiseAndParse(t, template)
  1795  	if m := cert2.MaxPathLen; m != 1 {
  1796  		t.Errorf("Setting MaxPathLen didn't work. Got %d but set 1", m)
  1797  	}
  1798  	if cert2.MaxPathLenZero {
  1799  		t.Errorf("Setting MaxPathLen resulted in MaxPathLenZero")
  1800  	}
  1801  
  1802  	template.MaxPathLen = 0
  1803  	template.MaxPathLenZero = true
  1804  	cert3 := serialiseAndParse(t, template)
  1805  	if m := cert3.MaxPathLen; m != 0 {
  1806  		t.Errorf("Setting MaxPathLenZero didn't work, got %d", m)
  1807  	}
  1808  	if !cert3.MaxPathLenZero {
  1809  		t.Errorf("Setting MaxPathLen to zero didn't result in MaxPathLenZero")
  1810  	}
  1811  }
  1812  
  1813  func TestNoAuthorityKeyIdInSelfSignedCert(t *testing.T) {
  1814  	template := &Certificate{
  1815  		SerialNumber: big.NewInt(1),
  1816  		Subject: pkix.Name{
  1817  			CommonName: "Σ Acme Co",
  1818  		},
  1819  		NotBefore: time.Unix(1000, 0),
  1820  		NotAfter:  time.Unix(100000, 0),
  1821  
  1822  		BasicConstraintsValid: true,
  1823  		IsCA:                  true,
  1824  		SubjectKeyId:          []byte{1, 2, 3, 4},
  1825  	}
  1826  
  1827  	if cert := serialiseAndParse(t, template); len(cert.AuthorityKeyId) != 0 {
  1828  		t.Fatalf("self-signed certificate contained default authority key id")
  1829  	}
  1830  
  1831  	template.AuthorityKeyId = []byte{1, 2, 3, 4}
  1832  	if cert := serialiseAndParse(t, template); len(cert.AuthorityKeyId) == 0 {
  1833  		t.Fatalf("self-signed certificate erased explicit authority key id")
  1834  	}
  1835  }
  1836  
  1837  func TestNoSubjectKeyIdInCert(t *testing.T) {
  1838  	template := &Certificate{
  1839  		SerialNumber: big.NewInt(1),
  1840  		Subject: pkix.Name{
  1841  			CommonName: "Σ Acme Co",
  1842  		},
  1843  		NotBefore: time.Unix(1000, 0),
  1844  		NotAfter:  time.Unix(100000, 0),
  1845  
  1846  		BasicConstraintsValid: true,
  1847  		IsCA:                  true,
  1848  	}
  1849  	if cert := serialiseAndParse(t, template); len(cert.SubjectKeyId) == 0 {
  1850  		t.Fatalf("self-signed certificate did not generate subject key id using the public key")
  1851  	}
  1852  
  1853  	template.IsCA = false
  1854  	if cert := serialiseAndParse(t, template); len(cert.SubjectKeyId) != 0 {
  1855  		t.Fatalf("self-signed certificate generated subject key id when it isn't a CA")
  1856  	}
  1857  
  1858  	template.SubjectKeyId = []byte{1, 2, 3, 4}
  1859  	if cert := serialiseAndParse(t, template); len(cert.SubjectKeyId) == 0 {
  1860  		t.Fatalf("self-signed certificate erased explicit subject key id")
  1861  	}
  1862  }
  1863  
  1864  func TestASN1BitLength(t *testing.T) {
  1865  	tests := []struct {
  1866  		bytes  []byte
  1867  		bitLen int
  1868  	}{
  1869  		{nil, 0},
  1870  		{[]byte{0x00}, 0},
  1871  		{[]byte{0x00, 0x00}, 0},
  1872  		{[]byte{0xf0}, 4},
  1873  		{[]byte{0x88}, 5},
  1874  		{[]byte{0xff}, 8},
  1875  		{[]byte{0xff, 0x80}, 9},
  1876  		{[]byte{0xff, 0x81}, 16},
  1877  	}
  1878  
  1879  	for i, test := range tests {
  1880  		if got := asn1BitLength(test.bytes); got != test.bitLen {
  1881  			t.Errorf("#%d: calculated bit-length of %d for %x, wanted %d", i, got, test.bytes, test.bitLen)
  1882  		}
  1883  	}
  1884  }
  1885  
  1886  func TestVerifyEmptyCertificate(t *testing.T) {
  1887  	if _, err := new(Certificate).Verify(VerifyOptions{}); err != errNotParsed {
  1888  		t.Errorf("Verifying empty certificate resulted in unexpected error: %q (wanted %q)", err, errNotParsed)
  1889  	}
  1890  }
  1891  
  1892  func TestInsecureAlgorithmErrorString(t *testing.T) {
  1893  	tests := []struct {
  1894  		sa   SignatureAlgorithm
  1895  		want string
  1896  	}{
  1897  		{MD5WithRSA, "x509: cannot verify signature: insecure algorithm MD5-RSA"},
  1898  		{SHA1WithRSA, "x509: cannot verify signature: insecure algorithm SHA1-RSA"},
  1899  		{ECDSAWithSHA1, "x509: cannot verify signature: insecure algorithm ECDSA-SHA1"},
  1900  		{MD2WithRSA, "x509: cannot verify signature: insecure algorithm 1"},
  1901  		{-1, "x509: cannot verify signature: insecure algorithm -1"},
  1902  		{0, "x509: cannot verify signature: insecure algorithm 0"},
  1903  		{9999, "x509: cannot verify signature: insecure algorithm 9999"},
  1904  	}
  1905  	for i, tt := range tests {
  1906  		if got := fmt.Sprint(InsecureAlgorithmError(tt.sa)); got != tt.want {
  1907  			t.Errorf("%d. mismatch.\n got: %s\nwant: %s\n", i, got, tt.want)
  1908  		}
  1909  	}
  1910  }
  1911  
  1912  // These CSR was generated with OpenSSL:
  1913  //
  1914  //	openssl req -out CSR.csr -new -sha256 -nodes -keyout privateKey.key -config openssl.cnf
  1915  //
  1916  // With openssl.cnf containing the following sections:
  1917  //
  1918  //	[ v3_req ]
  1919  //	basicConstraints = CA:FALSE
  1920  //	keyUsage = nonRepudiation, digitalSignature, keyEncipherment
  1921  //	subjectAltName = email:gopher@golang.org,DNS:test.example.com
  1922  //	[ req_attributes ]
  1923  //	challengePassword = ignored challenge
  1924  //	unstructuredName  = ignored unstructured name
  1925  var csrBase64Array = [...]string{
  1926  	// Just [ v3_req ]
  1927  	"MIIDHDCCAgQCAQAwfjELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDEUMBIGA1UEAwwLQ29tbW9uIE5hbWUxITAfBgkqhkiG9w0BCQEWEnRlc3RAZW1haWwuYWRkcmVzczCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAK1GY4YFx2ujlZEOJxQVYmsjUnLsd5nFVnNpLE4cV+77sgv9NPNlB8uhn3MXt5leD34rm/2BisCHOifPucYlSrszo2beuKhvwn4+2FxDmWtBEMu/QA16L5IvoOfYZm/gJTsPwKDqvaR0tTU67a9OtxwNTBMI56YKtmwd/o8d3hYv9cg+9ZGAZ/gKONcg/OWYx/XRh6bd0g8DMbCikpWgXKDsvvK1Nk+VtkDO1JxuBaj4Lz/p/MifTfnHoqHxWOWl4EaTs4Ychxsv34/rSj1KD1tJqorIv5Xv2aqv4sjxfbrYzX4kvS5SC1goIovLnhj5UjmQ3Qy8u65eow/LLWw+YFcCAwEAAaBZMFcGCSqGSIb3DQEJDjFKMEgwCQYDVR0TBAIwADALBgNVHQ8EBAMCBeAwLgYDVR0RBCcwJYERZ29waGVyQGdvbGFuZy5vcmeCEHRlc3QuZXhhbXBsZS5jb20wDQYJKoZIhvcNAQELBQADggEBAB6VPMRrchvNW61Tokyq3ZvO6/NoGIbuwUn54q6l5VZW0Ep5Nq8juhegSSnaJ0jrovmUgKDN9vEo2KxuAtwG6udS6Ami3zP+hRd4k9Q8djJPb78nrjzWiindLK5Fps9U5mMoi1ER8ViveyAOTfnZt/jsKUaRsscY2FzE9t9/o5moE6LTcHUS4Ap1eheR+J72WOnQYn3cifYaemsA9MJuLko+kQ6xseqttbh9zjqd9fiCSh/LNkzos9c+mg2yMADitaZinAh+HZi50ooEbjaT3erNq9O6RqwJlgD00g6MQdoz9bTAryCUhCQfkIaepmQ7BxS0pqWNW3MMwfDwx/Snz6g=",
  1928  	// Both [ v3_req ] and [ req_attributes ]
  1929  	"MIIDaTCCAlECAQAwfjELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDEUMBIGA1UEAwwLQ29tbW9uIE5hbWUxITAfBgkqhkiG9w0BCQEWEnRlc3RAZW1haWwuYWRkcmVzczCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAK1GY4YFx2ujlZEOJxQVYmsjUnLsd5nFVnNpLE4cV+77sgv9NPNlB8uhn3MXt5leD34rm/2BisCHOifPucYlSrszo2beuKhvwn4+2FxDmWtBEMu/QA16L5IvoOfYZm/gJTsPwKDqvaR0tTU67a9OtxwNTBMI56YKtmwd/o8d3hYv9cg+9ZGAZ/gKONcg/OWYx/XRh6bd0g8DMbCikpWgXKDsvvK1Nk+VtkDO1JxuBaj4Lz/p/MifTfnHoqHxWOWl4EaTs4Ychxsv34/rSj1KD1tJqorIv5Xv2aqv4sjxfbrYzX4kvS5SC1goIovLnhj5UjmQ3Qy8u65eow/LLWw+YFcCAwEAAaCBpTAgBgkqhkiG9w0BCQcxEwwRaWdub3JlZCBjaGFsbGVuZ2UwKAYJKoZIhvcNAQkCMRsMGWlnbm9yZWQgdW5zdHJ1Y3R1cmVkIG5hbWUwVwYJKoZIhvcNAQkOMUowSDAJBgNVHRMEAjAAMAsGA1UdDwQEAwIF4DAuBgNVHREEJzAlgRFnb3BoZXJAZ29sYW5nLm9yZ4IQdGVzdC5leGFtcGxlLmNvbTANBgkqhkiG9w0BAQsFAAOCAQEAgxe2N5O48EMsYE7o0rZBB0wi3Ov5/yYfnmmVI22Y3sP6VXbLDW0+UWIeSccOhzUCcZ/G4qcrfhhx6gTZTeA01nP7TdTJURvWAH5iFqj9sQ0qnLq6nEcVHij3sG6M5+BxAIVClQBk6lTCzgphc835Fjj6qSLuJ20XHdL5UfUbiJxx299CHgyBRL+hBUIPfz8p+ZgamyAuDLfnj54zzcRVyLlrmMLNPZNll1Q70RxoU6uWvLH8wB8vQe3Q/guSGubLyLRTUQVPh+dw1L4t8MKFWfX/48jwRM4gIRHFHPeAAE9D9YAoqdIvj/iFm/eQ++7DP8MDwOZWsXeB6jjwHuLmkQ==",
  1930  }
  1931  
  1932  var md5cert = `
  1933  -----BEGIN CERTIFICATE-----
  1934  MIIB4TCCAUoCCQCfmw3vMgPS5TANBgkqhkiG9w0BAQQFADA1MQswCQYDVQQGEwJB
  1935  VTETMBEGA1UECBMKU29tZS1TdGF0ZTERMA8GA1UEChMITUQ1IEluYy4wHhcNMTUx
  1936  MjAzMTkyOTMyWhcNMjkwODEyMTkyOTMyWjA1MQswCQYDVQQGEwJBVTETMBEGA1UE
  1937  CBMKU29tZS1TdGF0ZTERMA8GA1UEChMITUQ1IEluYy4wgZ8wDQYJKoZIhvcNAQEB
  1938  BQADgY0AMIGJAoGBANrq2nhLQj5mlXbpVX3QUPhfEm/vdEqPkoWtR/jRZIWm4WGf
  1939  Wpq/LKHJx2Pqwn+t117syN8l4U5unyAi1BJSXjBwPZNd7dXjcuJ+bRLV7FZ/iuvs
  1940  cfYyQQFTxan4TaJMd0x1HoNDbNbjHa02IyjjYE/r3mb/PIg+J2t5AZEh80lPAgMB
  1941  AAEwDQYJKoZIhvcNAQEEBQADgYEAjGzp3K3ey/YfKHohf33yHHWd695HQxDAP+wY
  1942  cs9/TAyLR+gJzJP7d18EcDDLJWVi7bhfa4EAD86di05azOh9kWSn4b3o9QYRGCSw
  1943  GNnI3Zk0cwNKA49hZntKKiy22DhRk7JAHF01d6Bu3KkHkmENrtJ+zj/+159WAnUa
  1944  qViorq4=
  1945  -----END CERTIFICATE-----
  1946  `
  1947  
  1948  func TestMD5(t *testing.T) {
  1949  	pemBlock, _ := pem.Decode([]byte(md5cert))
  1950  	cert, err := ParseCertificate(pemBlock.Bytes)
  1951  	if err != nil {
  1952  		t.Fatalf("failed to parse certificate: %s", err)
  1953  	}
  1954  	if sa := cert.SignatureAlgorithm; sa != MD5WithRSA {
  1955  		t.Errorf("signature algorithm is %v, want %v", sa, MD5WithRSA)
  1956  	}
  1957  	if err = cert.CheckSignatureFrom(cert); err == nil {
  1958  		t.Fatalf("certificate verification succeeded incorrectly")
  1959  	}
  1960  	if _, ok := err.(InsecureAlgorithmError); !ok {
  1961  		t.Fatalf("certificate verification returned %v (%T), wanted InsecureAlgorithmError", err, err)
  1962  	}
  1963  }
  1964  
  1965  func TestSHA1(t *testing.T) {
  1966  	pemBlock, _ := pem.Decode([]byte(ecdsaSHA1CertPem))
  1967  	cert, err := ParseCertificate(pemBlock.Bytes)
  1968  	if err != nil {
  1969  		t.Fatalf("failed to parse certificate: %s", err)
  1970  	}
  1971  	if sa := cert.SignatureAlgorithm; sa != ECDSAWithSHA1 {
  1972  		t.Errorf("signature algorithm is %v, want %v", sa, ECDSAWithSHA1)
  1973  	}
  1974  	if err = cert.CheckSignatureFrom(cert); err == nil {
  1975  		t.Fatalf("certificate verification succeeded incorrectly")
  1976  	}
  1977  	if _, ok := err.(InsecureAlgorithmError); !ok {
  1978  		t.Fatalf("certificate verification returned %v (%T), wanted InsecureAlgorithmError", err, err)
  1979  	}
  1980  }
  1981  
  1982  // certMissingRSANULL contains an RSA public key where the AlgorithmIdentifier
  1983  // parameters are omitted rather than being an ASN.1 NULL.
  1984  const certMissingRSANULL = `
  1985  -----BEGIN CERTIFICATE-----
  1986  MIIB7TCCAVigAwIBAgIBADALBgkqhkiG9w0BAQUwJjEQMA4GA1UEChMHQWNtZSBD
  1987  bzESMBAGA1UEAxMJMTI3LjAuMC4xMB4XDTExMTIwODA3NTUxMloXDTEyMTIwNzA4
  1988  MDAxMlowJjEQMA4GA1UEChMHQWNtZSBDbzESMBAGA1UEAxMJMTI3LjAuMC4xMIGc
  1989  MAsGCSqGSIb3DQEBAQOBjAAwgYgCgYBO0Hsx44Jk2VnAwoekXh6LczPHY1PfZpIG
  1990  hPZk1Y/kNqcdK+izIDZFI7Xjla7t4PUgnI2V339aEu+H5Fto5OkOdOwEin/ekyfE
  1991  ARl6vfLcPRSr0FTKIQzQTW6HLlzF0rtNS0/Otiz3fojsfNcCkXSmHgwa2uNKWi7e
  1992  E5xMQIhZkwIDAQABozIwMDAOBgNVHQ8BAf8EBAMCAKAwDQYDVR0OBAYEBAECAwQw
  1993  DwYDVR0jBAgwBoAEAQIDBDALBgkqhkiG9w0BAQUDgYEANh+zegx1yW43RmEr1b3A
  1994  p0vMRpqBWHyFeSnIyMZn3TJWRSt1tukkqVCavh9a+hoV2cxVlXIWg7nCto/9iIw4
  1995  hB2rXZIxE0/9gzvGnfERYraL7KtnvshksBFQRlgXa5kc0x38BvEO5ZaoDPl4ILdE
  1996  GFGNEH5PlGffo05wc46QkYU=
  1997  -----END CERTIFICATE-----`
  1998  
  1999  func TestRSAMissingNULLParameters(t *testing.T) {
  2000  	block, _ := pem.Decode([]byte(certMissingRSANULL))
  2001  	if _, err := ParseCertificate(block.Bytes); err == nil {
  2002  		t.Error("unexpected success when parsing certificate with missing RSA NULL parameter")
  2003  	} else if !strings.Contains(err.Error(), "missing NULL") {
  2004  		t.Errorf("unrecognised error when parsing certificate with missing RSA NULL parameter: %s", err)
  2005  	}
  2006  }
  2007  
  2008  const certISOOID = `-----BEGIN CERTIFICATE-----
  2009  MIIB5TCCAVKgAwIBAgIQNwyL3RPWV7dJQp34HwZG9DAJBgUrDgMCHQUAMBExDzAN
  2010  BgNVBAMTBm15dGVzdDAeFw0xNjA4MDkyMjExMDVaFw0zOTEyMzEyMzU5NTlaMBEx
  2011  DzANBgNVBAMTBm15dGVzdDCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEArzIH
  2012  GsyDB3ohIGkkvijF2PTRUX1bvOtY1eUUpjwHyu0twpAKSuaQv2Ha+/63+aHe8O86
  2013  BT+98wjXFX6RFSagtAujo80rIF2dSm33BGt18pDN8v6zp93dnAm0jRaSQrHJ75xw
  2014  5O+S1oEYR1LtUoFJy6qB104j6aINBAgOiLIKiMkCAwEAAaNGMEQwQgYDVR0BBDsw
  2015  OYAQVuYVQ/WDjdGSkZRlTtJDNKETMBExDzANBgNVBAMTBm15dGVzdIIQtwyL3RPW
  2016  V7dJQp34HwZG9DAJBgUrDgMCHQUAA4GBABngrSkH7vG5lY4sa4AZF59lAAXqBVJE
  2017  J4TBiKC62hCdZv18rBleP6ETfhbPg7pTs8p4ebQbpmtNxRS9Lw3MzQ8Ya5Ybwzj2
  2018  NwBSyCtCQl7mrEg4nJqJl4A2EUhnET/oVxU0oTV/SZ3ziGXcY1oG1s6vidV7TZTu
  2019  MCRtdSdaM7g3
  2020  -----END CERTIFICATE-----`
  2021  
  2022  func TestISOOIDInCertificate(t *testing.T) {
  2023  	block, _ := pem.Decode([]byte(certISOOID))
  2024  	if cert, err := ParseCertificate(block.Bytes); err != nil {
  2025  		t.Errorf("certificate with ISO OID failed to parse: %s", err)
  2026  	} else if cert.SignatureAlgorithm == UnknownSignatureAlgorithm {
  2027  		t.Errorf("ISO OID not recognised in certificate")
  2028  	}
  2029  }
  2030  
  2031  // certMultipleRDN contains a RelativeDistinguishedName with two elements (the
  2032  // common name and serial number). This particular certificate was the first
  2033  // such certificate in the “Pilot” Certificate Transparency log.
  2034  const certMultipleRDN = `
  2035  -----BEGIN CERTIFICATE-----
  2036  MIIFRzCCBC+gAwIBAgIEOl59NTANBgkqhkiG9w0BAQUFADA9MQswCQYDVQQGEwJz
  2037  aTEbMBkGA1UEChMSc3RhdGUtaW5zdGl0dXRpb25zMREwDwYDVQQLEwhzaWdvdi1j
  2038  YTAeFw0xMjExMTYxMDUyNTdaFw0xNzExMTYxMjQ5MDVaMIGLMQswCQYDVQQGEwJz
  2039  aTEbMBkGA1UEChMSc3RhdGUtaW5zdGl0dXRpb25zMRkwFwYDVQQLExB3ZWItY2Vy
  2040  dGlmaWNhdGVzMRAwDgYDVQQLEwdTZXJ2ZXJzMTIwFAYDVQQFEw0xMjM2NDg0MDEw
  2041  MDEwMBoGA1UEAxMTZXBvcnRhbC5tc3MuZWR1cy5zaTCCASIwDQYJKoZIhvcNAQEB
  2042  BQADggEPADCCAQoCggEBAMrNkZH9MPuBTjMGNk3sJX8V+CkFx/4ru7RTlLS6dlYM
  2043  098dtSfJ3s2w0p/1NB9UmR8j0yS0Kg6yoZ3ShsSO4DWBtcQD8820a6BYwqxxQTNf
  2044  HSRZOc+N/4TQrvmK6t4k9Aw+YEYTMrWOU4UTeyhDeCcUsBdh7HjfWsVaqNky+2sv
  2045  oic3zP5gF+2QfPkvOoHT3FLR8olNhViIE6Kk3eFIEs4dkq/ZzlYdLb8pHQoj/sGI
  2046  zFmA5AFvm1HURqOmJriFjBwaCtn8AVEYOtQrnUCzJYu1ex8azyS2ZgYMX0u8A5Z/
  2047  y2aMS/B2W+H79WcgLpK28vPwe7vam0oFrVytAd+u65ECAwEAAaOCAf4wggH6MA4G
  2048  A1UdDwEB/wQEAwIFoDBABgNVHSAEOTA3MDUGCisGAQQBr1kBAwMwJzAlBggrBgEF
  2049  BQcCARYZaHR0cDovL3d3dy5jYS5nb3Yuc2kvY3BzLzAfBgNVHREEGDAWgRRwb2Rw
  2050  b3JhLm1pemtzQGdvdi5zaTCB8QYDVR0fBIHpMIHmMFWgU6BRpE8wTTELMAkGA1UE
  2051  BhMCc2kxGzAZBgNVBAoTEnN0YXRlLWluc3RpdHV0aW9uczERMA8GA1UECxMIc2ln
  2052  b3YtY2ExDjAMBgNVBAMTBUNSTDM5MIGMoIGJoIGGhldsZGFwOi8veDUwMC5nb3Yu
  2053  c2kvb3U9c2lnb3YtY2Esbz1zdGF0ZS1pbnN0aXR1dGlvbnMsYz1zaT9jZXJ0aWZp
  2054  Y2F0ZVJldm9jYXRpb25MaXN0P2Jhc2WGK2h0dHA6Ly93d3cuc2lnb3YtY2EuZ292
  2055  LnNpL2NybC9zaWdvdi1jYS5jcmwwKwYDVR0QBCQwIoAPMjAxMjExMTYxMDUyNTda
  2056  gQ8yMDE3MTExNjEyNDkwNVowHwYDVR0jBBgwFoAUHvjUU2uzgwbpBAZXAvmlv8ZY
  2057  PHIwHQYDVR0OBBYEFGI1Duuu+wTGDZka/xHNbwcbM69ZMAkGA1UdEwQCMAAwGQYJ
  2058  KoZIhvZ9B0EABAwwChsEVjcuMQMCA6gwDQYJKoZIhvcNAQEFBQADggEBAHny0K1y
  2059  BQznrzDu3DDpBcGYguKU0dvU9rqsV1ua4nxkriSMWjgsX6XJFDdDW60I3P4VWab5
  2060  ag5fZzbGqi8kva/CzGgZh+CES0aWCPy+4Gb8lwOTt+854/laaJvd6kgKTER7z7U9
  2061  9C86Ch2y4sXNwwwPJ1A9dmrZJZOcJjS/WYZgwaafY2Hdxub5jqPE5nehwYUPVu9R
  2062  uH6/skk4OEKcfOtN0hCnISOVuKYyS4ANARWRG5VGHIH06z3lGUVARFRJ61gtAprd
  2063  La+fgSS+LVZ+kU2TkeoWAKvGq8MAgDq4D4Xqwekg7WKFeuyusi/NI5rm40XgjBMF
  2064  DF72IUofoVt7wo0=
  2065  -----END CERTIFICATE-----`
  2066  
  2067  func TestMultipleRDN(t *testing.T) {
  2068  	block, _ := pem.Decode([]byte(certMultipleRDN))
  2069  	cert, err := ParseCertificate(block.Bytes)
  2070  	if err != nil {
  2071  		t.Fatalf("certificate with two elements in an RDN failed to parse: %v", err)
  2072  	}
  2073  
  2074  	if want := "eportal.mss.edus.si"; cert.Subject.CommonName != want {
  2075  		t.Errorf("got common name of %q, but want %q", cert.Subject.CommonName, want)
  2076  	}
  2077  
  2078  	if want := "1236484010010"; cert.Subject.SerialNumber != want {
  2079  		t.Errorf("got serial number of %q, but want %q", cert.Subject.SerialNumber, want)
  2080  	}
  2081  }
  2082  
  2083  func TestSystemCertPool(t *testing.T) {
  2084  	if runtime.GOOS == "windows" || runtime.GOOS == "darwin" || runtime.GOOS == "ios" {
  2085  		t.Skip("not implemented on Windows (Issue 16736, 18609) or darwin (Issue 46287)")
  2086  	}
  2087  	a, err := SystemCertPool()
  2088  	if err != nil {
  2089  		t.Fatal(err)
  2090  	}
  2091  	b, err := SystemCertPool()
  2092  	if err != nil {
  2093  		t.Fatal(err)
  2094  	}
  2095  	if !certPoolEqual(a, b) {
  2096  		t.Fatal("two calls to SystemCertPool had different results")
  2097  	}
  2098  	if ok := b.AppendCertsFromPEM([]byte(`
  2099  -----BEGIN CERTIFICATE-----
  2100  MIIDBjCCAe6gAwIBAgIRANXM5I3gjuqDfTp/PYrs+u8wDQYJKoZIhvcNAQELBQAw
  2101  EjEQMA4GA1UEChMHQWNtZSBDbzAeFw0xODAzMjcxOTU2MjFaFw0xOTAzMjcxOTU2
  2102  MjFaMBIxEDAOBgNVBAoTB0FjbWUgQ28wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw
  2103  ggEKAoIBAQDK+9m3rjsO2Djes6bIYQZ3eV29JF09ZrjOrEHLtaKrD6/acsoSoTsf
  2104  cQr+rzzztdB5ijWXCS64zo/0OiqBeZUNZ67jVdToa9qW5UYe2H0Y+ZNdfA5GYMFD
  2105  yk/l3/uBu3suTZPfXiW2TjEi27Q8ruNUIZ54DpTcs6y2rBRFzadPWwn/VQMlvRXM
  2106  jrzl8Y08dgnYmaAHprxVzwMXcQ/Brol+v9GvjaH1DooHqkn8O178wsPQNhdtvN01
  2107  IXL46cYdcUwWrE/GX5u+9DaSi+0KWxAPQ+NVD5qUI0CKl4714yGGh7feXMjJdHgl
  2108  VG4QJZlJvC4FsURgCHJT6uHGIelnSwhbAgMBAAGjVzBVMA4GA1UdDwEB/wQEAwIF
  2109  oDATBgNVHSUEDDAKBggrBgEFBQcDATAMBgNVHRMBAf8EAjAAMCAGA1UdEQQZMBeC
  2110  FVRlc3RTeXN0ZW1DZXJ0UG9vbC5nbzANBgkqhkiG9w0BAQsFAAOCAQEAwuSRx/VR
  2111  BKh2ICxZjL6jBwk/7UlU1XKbhQD96RqkidDNGEc6eLZ90Z5XXTurEsXqdm5jQYPs
  2112  1cdcSW+fOSMl7MfW9e5tM66FaIPZl9rKZ1r7GkOfgn93xdLAWe8XHd19xRfDreub
  2113  YC8DVqgLASOEYFupVSl76ktPfxkU5KCvmUf3P2PrRybk1qLGFytGxfyice2gHSNI
  2114  gify3K/+H/7wCkyFW4xYvzl7WW4mXxoqPRPjQt1J423DhnnQ4G1P8V/vhUpXNXOq
  2115  N9IEPnWuihC09cyx/WMQIUlWnaQLHdfpPS04Iez3yy2PdfXJzwfPrja7rNE+skK6
  2116  pa/O1nF0AfWOpw==
  2117  -----END CERTIFICATE-----
  2118  	`)); !ok {
  2119  		t.Fatal("AppendCertsFromPEM failed")
  2120  	}
  2121  	if reflect.DeepEqual(a, b) {
  2122  		t.Fatal("changing one pool modified the other")
  2123  	}
  2124  }
  2125  
  2126  const emptyNameConstraintsPEM = `
  2127  -----BEGIN CERTIFICATE-----
  2128  MIIC1jCCAb6gAwIBAgICEjQwDQYJKoZIhvcNAQELBQAwKDEmMCQGA1UEAxMdRW1w
  2129  dHkgbmFtZSBjb25zdHJhaW50cyBpc3N1ZXIwHhcNMTMwMjAxMDAwMDAwWhcNMjAw
  2130  NTMwMTA0ODM4WjAhMR8wHQYDVQQDExZFbXB0eSBuYW1lIGNvbnN0cmFpbnRzMIIB
  2131  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAwriElUIt3LCqmJObs+yDoWPD
  2132  F5IqgWk6moIobYjPfextZiYU6I3EfvAwoNxPDkN2WowcocUZMJbEeEq5ebBksFnx
  2133  f12gBxlIViIYwZAzu7aFvhDMyPKQI3C8CG0ZSC9ABZ1E3umdA3CEueNOmP/TChNq
  2134  Cl23+BG1Qb/PJkpAO+GfpWSVhTcV53Mf/cKvFHcjGNrxzdSoq9fyW7a6gfcGEQY0
  2135  LVkmwFWUfJ0wT8kaeLr0E0tozkIfo01KNWNzv6NcYP80QOBRDlApWu9ODmEVJHPD
  2136  blx4jzTQ3JLa+4DvBNOjVUOp+mgRmjiW0rLdrxwOxIqIOwNjweMCp/hgxX/hTQID
  2137  AQABoxEwDzANBgNVHR4EBjAEoAChADANBgkqhkiG9w0BAQsFAAOCAQEAWG+/zUMH
  2138  QhP8uNCtgSHyim/vh7wminwAvWgMKxlkLBFns6nZeQqsOV1lABY7U0Zuoqa1Z5nb
  2139  6L+iJa4ElREJOi/erLc9uLwBdDCAR0hUTKD7a6i4ooS39DTle87cUnj0MW1CUa6H
  2140  v5SsvpYW+1XleYJk/axQOOTcy4Es53dvnZsjXH0EA/QHnn7UV+JmlE3rtVxcYp6M
  2141  LYPmRhTioROA/drghicRkiu9hxdPyxkYS16M5g3Zj30jdm+k/6C6PeNtN9YmOOga
  2142  nCOSyFYfGhqOANYzpmuV+oIedAsPpIbfIzN8njYUs1zio+1IoI4o8ddM9sCbtPU8
  2143  o+WoY6IsCKXV/g==
  2144  -----END CERTIFICATE-----`
  2145  
  2146  func TestEmptyNameConstraints(t *testing.T) {
  2147  	block, _ := pem.Decode([]byte(emptyNameConstraintsPEM))
  2148  	_, err := ParseCertificate(block.Bytes)
  2149  	if err == nil {
  2150  		t.Fatal("unexpected success")
  2151  	}
  2152  
  2153  	const expected = "empty name constraints"
  2154  	if str := err.Error(); !strings.Contains(str, expected) {
  2155  		t.Errorf("expected %q in error but got %q", expected, str)
  2156  	}
  2157  }
  2158  
  2159  func TestPKIXNameString(t *testing.T) {
  2160  	der, err := base64.StdEncoding.DecodeString(certBytes)
  2161  	if err != nil {
  2162  		t.Fatal(err)
  2163  	}
  2164  	certs, err := ParseCertificates(der)
  2165  	if err != nil {
  2166  		t.Fatal(err)
  2167  	}
  2168  
  2169  	// Check that parsed non-standard attributes are printed.
  2170  	rdns := pkix.Name{
  2171  		Locality: []string{"Gophertown"},
  2172  		ExtraNames: []pkix.AttributeTypeAndValue{
  2173  			{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 5}), Value: "golang.org"}},
  2174  	}.ToRDNSequence()
  2175  	nn := pkix.Name{}
  2176  	nn.FillFromRDNSequence(&rdns)
  2177  
  2178  	// Check that zero-length non-nil ExtraNames hide Names.
  2179  	extra := []pkix.AttributeTypeAndValue{
  2180  		{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 5}), Value: "backing array"}}
  2181  	extraNotNil := pkix.Name{
  2182  		Locality:   []string{"Gophertown"},
  2183  		ExtraNames: extra[:0],
  2184  		Names: []pkix.AttributeTypeAndValue{
  2185  			{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 5}), Value: "golang.org"}},
  2186  	}
  2187  
  2188  	tests := []struct {
  2189  		dn   pkix.Name
  2190  		want string
  2191  	}{
  2192  		{nn, "L=Gophertown,1.2.3.4.5=golang.org"},
  2193  		{extraNotNil, "L=Gophertown"},
  2194  		{pkix.Name{
  2195  			CommonName:         "Steve Kille",
  2196  			Organization:       []string{"Isode Limited"},
  2197  			OrganizationalUnit: []string{"RFCs"},
  2198  			Locality:           []string{"Richmond"},
  2199  			Province:           []string{"Surrey"},
  2200  			StreetAddress:      []string{"The Square"},
  2201  			PostalCode:         []string{"TW9 1DT"},
  2202  			SerialNumber:       "RFC 2253",
  2203  			Country:            []string{"GB"},
  2204  		}, "SERIALNUMBER=RFC 2253,CN=Steve Kille,OU=RFCs,O=Isode Limited,POSTALCODE=TW9 1DT,STREET=The Square,L=Richmond,ST=Surrey,C=GB"},
  2205  		{certs[0].Subject,
  2206  			"CN=mail.google.com,O=Google LLC,L=Mountain View,ST=California,C=US"},
  2207  		{pkix.Name{
  2208  			Organization: []string{"#Google, Inc. \n-> 'Alphabet\" "},
  2209  			Country:      []string{"US"},
  2210  		}, "O=\\#Google\\, Inc. \n-\\> 'Alphabet\\\"\\ ,C=US"},
  2211  		{pkix.Name{
  2212  			CommonName:   "foo.com",
  2213  			Organization: []string{"Gopher Industries"},
  2214  			ExtraNames: []pkix.AttributeTypeAndValue{
  2215  				{Type: asn1.ObjectIdentifier([]int{2, 5, 4, 3}), Value: "bar.com"}},
  2216  		}, "CN=bar.com,O=Gopher Industries"},
  2217  		{pkix.Name{
  2218  			Locality: []string{"Gophertown"},
  2219  			ExtraNames: []pkix.AttributeTypeAndValue{
  2220  				{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 5}), Value: "golang.org"}},
  2221  		}, "1.2.3.4.5=golang.org,L=Gophertown"},
  2222  		// If there are no ExtraNames, the Names are printed instead.
  2223  		{pkix.Name{
  2224  			Locality: []string{"Gophertown"},
  2225  			Names: []pkix.AttributeTypeAndValue{
  2226  				{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 5}), Value: "golang.org"}},
  2227  		}, "L=Gophertown,1.2.3.4.5=golang.org"},
  2228  		// If there are both, print only the ExtraNames.
  2229  		{pkix.Name{
  2230  			Locality: []string{"Gophertown"},
  2231  			ExtraNames: []pkix.AttributeTypeAndValue{
  2232  				{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 5}), Value: "golang.org"}},
  2233  			Names: []pkix.AttributeTypeAndValue{
  2234  				{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4, 6}), Value: "example.com"}},
  2235  		}, "1.2.3.4.5=golang.org,L=Gophertown"},
  2236  		// Non-string value falls back to hex-encoded DER (issue 33093).
  2237  		{pkix.Name{
  2238  			CommonName: "foobar",
  2239  			ExtraNames: []pkix.AttributeTypeAndValue{
  2240  				{Type: asn1.ObjectIdentifier([]int{1, 2, 3, 4}), Value: 42}},
  2241  		}, "1.2.3.4=#02012a,CN=foobar"},
  2242  		// String containing non-PrintableString chars (here, UTF-8) is still
  2243  		// rendered as a string per RFC 2253 §2.4, not hex-encoded.
  2244  		{pkix.Name{
  2245  			CommonName: "foobar",
  2246  			ExtraNames: []pkix.AttributeTypeAndValue{
  2247  				{Type: asn1.ObjectIdentifier([]int{2, 3, 4, 5}), Value: "Lučić"}},
  2248  		}, "2.3.4.5=Lučić,CN=foobar"},
  2249  		// String beginning with '#' has the '#' escaped (RFC 2253 §2.4).
  2250  		{pkix.Name{
  2251  			CommonName: "foobar",
  2252  			ExtraNames: []pkix.AttributeTypeAndValue{
  2253  				{Type: asn1.ObjectIdentifier([]int{2, 3, 4, 5}), Value: "#abcdef"}},
  2254  		}, "2.3.4.5=\\#abcdef,CN=foobar"},
  2255  		// Printable string with an embedded RFC 2253 escapable character.
  2256  		{pkix.Name{
  2257  			CommonName: "foobar",
  2258  			ExtraNames: []pkix.AttributeTypeAndValue{
  2259  				{Type: asn1.ObjectIdentifier([]int{2, 3, 4, 5}), Value: "abcdef,GHI"}},
  2260  		}, "2.3.4.5=abcdef\\,GHI,CN=foobar"},
  2261  		// Printable string with leading and trailing space gets escaped.
  2262  		{pkix.Name{
  2263  			CommonName: "foobar",
  2264  			ExtraNames: []pkix.AttributeTypeAndValue{
  2265  				{Type: asn1.ObjectIdentifier([]int{2, 3, 4, 5}), Value: "   abcdef "}},
  2266  		}, "2.3.4.5=\\   abcdef\\ ,CN=foobar"},
  2267  	}
  2268  
  2269  	for i, test := range tests {
  2270  		if got := test.dn.String(); got != test.want {
  2271  			t.Errorf("#%d: String() = \n%s\n, want \n%s", i, got, test.want)
  2272  		}
  2273  	}
  2274  
  2275  	if extra[0].Value != "backing array" {
  2276  		t.Errorf("the backing array of an empty ExtraNames got modified by String")
  2277  	}
  2278  }
  2279  
  2280  func TestRDNSequenceString(t *testing.T) {
  2281  	// Test some extra cases that get lost in pkix.Name conversions such as
  2282  	// multi-valued attributes.
  2283  
  2284  	var (
  2285  		oidCountry            = []int{2, 5, 4, 6}
  2286  		oidOrganization       = []int{2, 5, 4, 10}
  2287  		oidOrganizationalUnit = []int{2, 5, 4, 11}
  2288  		oidCommonName         = []int{2, 5, 4, 3}
  2289  	)
  2290  
  2291  	tests := []struct {
  2292  		seq  pkix.RDNSequence
  2293  		want string
  2294  	}{
  2295  		{
  2296  			seq: pkix.RDNSequence{
  2297  				pkix.RelativeDistinguishedNameSET{
  2298  					pkix.AttributeTypeAndValue{Type: oidCountry, Value: "US"},
  2299  				},
  2300  				pkix.RelativeDistinguishedNameSET{
  2301  					pkix.AttributeTypeAndValue{Type: oidOrganization, Value: "Widget Inc."},
  2302  				},
  2303  				pkix.RelativeDistinguishedNameSET{
  2304  					pkix.AttributeTypeAndValue{Type: oidOrganizationalUnit, Value: "Sales"},
  2305  					pkix.AttributeTypeAndValue{Type: oidCommonName, Value: "J. Smith"},
  2306  				},
  2307  			},
  2308  			want: "OU=Sales+CN=J. Smith,O=Widget Inc.,C=US",
  2309  		},
  2310  	}
  2311  
  2312  	for i, test := range tests {
  2313  		if got := test.seq.String(); got != test.want {
  2314  			t.Errorf("#%d: String() = \n%s\n, want \n%s", i, got, test.want)
  2315  		}
  2316  	}
  2317  }
  2318  
  2319  const criticalNameConstraintWithUnknownTypePEM = `
  2320  -----BEGIN CERTIFICATE-----
  2321  MIIC/TCCAeWgAwIBAgICEjQwDQYJKoZIhvcNAQELBQAwKDEmMCQGA1UEAxMdRW1w
  2322  dHkgbmFtZSBjb25zdHJhaW50cyBpc3N1ZXIwHhcNMTMwMjAxMDAwMDAwWhcNMjAw
  2323  NTMwMTA0ODM4WjAhMR8wHQYDVQQDExZFbXB0eSBuYW1lIGNvbnN0cmFpbnRzMIIB
  2324  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAwriElUIt3LCqmJObs+yDoWPD
  2325  F5IqgWk6moIobYjPfextZiYU6I3EfvAwoNxPDkN2WowcocUZMJbEeEq5ebBksFnx
  2326  f12gBxlIViIYwZAzu7aFvhDMyPKQI3C8CG0ZSC9ABZ1E3umdA3CEueNOmP/TChNq
  2327  Cl23+BG1Qb/PJkpAO+GfpWSVhTcV53Mf/cKvFHcjGNrxzdSoq9fyW7a6gfcGEQY0
  2328  LVkmwFWUfJ0wT8kaeLr0E0tozkIfo01KNWNzv6NcYP80QOBRDlApWu9ODmEVJHPD
  2329  blx4jzTQ3JLa+4DvBNOjVUOp+mgRmjiW0rLdrxwOxIqIOwNjweMCp/hgxX/hTQID
  2330  AQABozgwNjA0BgNVHR4BAf8EKjAooCQwIokgIACrzQAAAAAAAAAAAAAAAP////8A
  2331  AAAAAAAAAAAAAAChADANBgkqhkiG9w0BAQsFAAOCAQEAWG+/zUMHQhP8uNCtgSHy
  2332  im/vh7wminwAvWgMKxlkLBFns6nZeQqsOV1lABY7U0Zuoqa1Z5nb6L+iJa4ElREJ
  2333  Oi/erLc9uLwBdDCAR0hUTKD7a6i4ooS39DTle87cUnj0MW1CUa6Hv5SsvpYW+1Xl
  2334  eYJk/axQOOTcy4Es53dvnZsjXH0EA/QHnn7UV+JmlE3rtVxcYp6MLYPmRhTioROA
  2335  /drghicRkiu9hxdPyxkYS16M5g3Zj30jdm+k/6C6PeNtN9YmOOganCOSyFYfGhqO
  2336  ANYzpmuV+oIedAsPpIbfIzN8njYUs1zio+1IoI4o8ddM9sCbtPU8o+WoY6IsCKXV
  2337  /g==
  2338  -----END CERTIFICATE-----`
  2339  
  2340  func TestCriticalNameConstraintWithUnknownType(t *testing.T) {
  2341  	block, _ := pem.Decode([]byte(criticalNameConstraintWithUnknownTypePEM))
  2342  	cert, err := ParseCertificate(block.Bytes)
  2343  	if err != nil {
  2344  		t.Fatalf("unexpected parsing failure: %s", err)
  2345  	}
  2346  
  2347  	if l := len(cert.UnhandledCriticalExtensions); l != 1 {
  2348  		t.Fatalf("expected one unhandled critical extension, but found %d", l)
  2349  	}
  2350  }
  2351  
  2352  const badIPMaskPEM = `
  2353  -----BEGIN CERTIFICATE-----
  2354  MIICzzCCAbegAwIBAgICEjQwDQYJKoZIhvcNAQELBQAwHTEbMBkGA1UEAxMSQmFk
  2355  IElQIG1hc2sgaXNzdWVyMB4XDTEzMDIwMTAwMDAwMFoXDTIwMDUzMDEwNDgzOFow
  2356  FjEUMBIGA1UEAxMLQmFkIElQIG1hc2swggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw
  2357  ggEKAoIBAQDCuISVQi3csKqYk5uz7IOhY8MXkiqBaTqagihtiM997G1mJhTojcR+
  2358  8DCg3E8OQ3ZajByhxRkwlsR4Srl5sGSwWfF/XaAHGUhWIhjBkDO7toW+EMzI8pAj
  2359  cLwIbRlIL0AFnUTe6Z0DcIS5406Y/9MKE2oKXbf4EbVBv88mSkA74Z+lZJWFNxXn
  2360  cx/9wq8UdyMY2vHN1Kir1/JbtrqB9wYRBjQtWSbAVZR8nTBPyRp4uvQTS2jOQh+j
  2361  TUo1Y3O/o1xg/zRA4FEOUCla704OYRUkc8NuXHiPNNDcktr7gO8E06NVQ6n6aBGa
  2362  OJbSst2vHA7Eiog7A2PB4wKn+GDFf+FNAgMBAAGjIDAeMBwGA1UdHgEB/wQSMBCg
  2363  DDAKhwgBAgME//8BAKEAMA0GCSqGSIb3DQEBCwUAA4IBAQBYb7/NQwdCE/y40K2B
  2364  IfKKb++HvCaKfAC9aAwrGWQsEWezqdl5Cqw5XWUAFjtTRm6iprVnmdvov6IlrgSV
  2365  EQk6L96stz24vAF0MIBHSFRMoPtrqLiihLf0NOV7ztxSePQxbUJRroe/lKy+lhb7
  2366  VeV5gmT9rFA45NzLgSznd2+dmyNcfQQD9AeeftRX4maUTeu1XFxinowtg+ZGFOKh
  2367  E4D92uCGJxGSK72HF0/LGRhLXozmDdmPfSN2b6T/oLo942031iY46BqcI5LIVh8a
  2368  Go4A1jOma5X6gh50Cw+kht8jM3yeNhSzXOKj7Uigjijx10z2wJu09Tyj5ahjoiwI
  2369  pdX+
  2370  -----END CERTIFICATE-----`
  2371  
  2372  func TestBadIPMask(t *testing.T) {
  2373  	block, _ := pem.Decode([]byte(badIPMaskPEM))
  2374  	_, err := ParseCertificate(block.Bytes)
  2375  	if err == nil {
  2376  		t.Fatalf("unexpected success")
  2377  	}
  2378  
  2379  	const expected = "contained invalid mask"
  2380  	if !strings.Contains(err.Error(), expected) {
  2381  		t.Fatalf("expected %q in error but got: %s", expected, err)
  2382  	}
  2383  }
  2384  
  2385  const additionalGeneralSubtreePEM = `
  2386  -----BEGIN CERTIFICATE-----
  2387  MIIG4TCCBMmgAwIBAgIRALss+4rLw2Ia7tFFhxE8g5cwDQYJKoZIhvcNAQELBQAw
  2388  bjELMAkGA1UEBhMCTkwxIDAeBgNVBAoMF01pbmlzdGVyaWUgdmFuIERlZmVuc2ll
  2389  MT0wOwYDVQQDDDRNaW5pc3RlcmllIHZhbiBEZWZlbnNpZSBDZXJ0aWZpY2F0aWUg
  2390  QXV0b3JpdGVpdCAtIEcyMB4XDTEzMDMwNjEyMDM0OVoXDTEzMTEzMDEyMDM1MFow
  2391  bDELMAkGA1UEBhMCVVMxFjAUBgNVBAoTDUNlcnRpUGF0aCBMTEMxIjAgBgNVBAsT
  2392  GUNlcnRpZmljYXRpb24gQXV0aG9yaXRpZXMxITAfBgNVBAMTGENlcnRpUGF0aCBC
  2393  cmlkZ2UgQ0EgLSBHMjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBANLW
  2394  4kXiRqvwBhJfN9uz12FA+P2D34MPxOt7TGXljm2plJ2CLzvaH8/ymsMdSWdJBS1M
  2395  8FmwvNL1w3A6ZuzksJjPikAu8kY3dcp3mrkk9eCPORDAwGtfsXwZysLiuEaDWpbD
  2396  dHOaHnI6qWU0N6OI+hNX58EjDpIGC1WQdho1tHOTPc5Hf5/hOpM/29v/wr7kySjs
  2397  Z+7nsvkm5rNhuJNzPsLsgzVaJ5/BVyOplZy24FKM8Y43MjR4osZm+a2e0zniqw6/
  2398  rvcjcGYabYaznZfQG1GXoyf2Vea+CCgpgUhlVafgkwEs8izl8rIpvBzXiFAgFQuG
  2399  Ituoy92PJbDs430fA/cCAwEAAaOCAnowggJ2MEUGCCsGAQUFBwEBBDkwNzA1Bggr
  2400  BgEFBQcwAoYpaHR0cDovL2NlcnRzLmNhLm1pbmRlZi5ubC9taW5kZWYtY2EtMi5w
  2401  N2MwHwYDVR0jBBgwFoAUzln9WSPz2M64Rl2HYf2/KD8StmQwDwYDVR0TAQH/BAUw
  2402  AwEB/zCB6QYDVR0gBIHhMIHeMEgGCmCEEAGHawECBQEwOjA4BggrBgEFBQcCARYs
  2403  aHR0cDovL2Nwcy5kcC5jYS5taW5kZWYubmwvbWluZGVmLWNhLWRwLWNwcy8wSAYK
  2404  YIQQAYdrAQIFAjA6MDgGCCsGAQUFBwIBFixodHRwOi8vY3BzLmRwLmNhLm1pbmRl
  2405  Zi5ubC9taW5kZWYtY2EtZHAtY3BzLzBIBgpghBABh2sBAgUDMDowOAYIKwYBBQUH
  2406  AgEWLGh0dHA6Ly9jcHMuZHAuY2EubWluZGVmLm5sL21pbmRlZi1jYS1kcC1jcHMv
  2407  MDkGA1UdHwQyMDAwLqAsoCqGKGh0dHA6Ly9jcmxzLmNhLm1pbmRlZi5ubC9taW5k
  2408  ZWYtY2EtMi5jcmwwDgYDVR0PAQH/BAQDAgEGMEYGA1UdHgEB/wQ8MDqhODA2pDEw
  2409  LzELMAkGA1UEBhMCTkwxIDAeBgNVBAoTF01pbmlzdGVyaWUgdmFuIERlZmVuc2ll
  2410  gQFjMF0GA1UdIQRWMFQwGgYKYIQQAYdrAQIFAQYMKwYBBAGBu1MBAQECMBoGCmCE
  2411  EAGHawECBQIGDCsGAQQBgbtTAQEBAjAaBgpghBABh2sBAgUDBgwrBgEEAYG7UwEB
  2412  AQIwHQYDVR0OBBYEFNDCjBM3M3ZKkag84ei3/aKc0d0UMA0GCSqGSIb3DQEBCwUA
  2413  A4ICAQAQXFn9jF90/DNFf15JhoGtta/0dNInb14PMu3PAjcdrXYCDPpQZOArTUng
  2414  5YT1WuzfmjnXiTsziT3my0r9Mxvz/btKK/lnVOMW4c2q/8sIsIPnnW5ZaRGrsANB
  2415  dNDZkzMYmeG2Pfgvd0AQSOrpE/TVgWfu/+MMRWwX9y6VbooBR7BLv7zMuVH0WqLn
  2416  6OMFth7fqsThlfMSzkE/RDSaU6n3wXAWT1SIqBITtccRjSUQUFm/q3xrb2cwcZA6
  2417  8vdS4hzNd+ttS905ay31Ks4/1Wrm1bH5RhEfRSH0VSXnc0b+z+RyBbmiwtVZqzxE
  2418  u3UQg/rAmtLDclLFEzjp8YDTIRYSLwstDbEXO/0ArdGrQm79HQ8i/3ZbP2357myW
  2419  i15qd6gMJIgGHS4b8Hc7R1K8LQ9Gm1aLKBEWVNGZlPK/cpXThpVmoEyslN2DHCrc
  2420  fbMbjNZpXlTMa+/b9z7Fa4X8dY8u/ELzZuJXJv5Rmqtg29eopFFYDCl0Nkh1XAjo
  2421  QejEoHHUvYV8TThHZr6Z6Ib8CECgTehU4QvepkgDXNoNrKRZBG0JhLjkwxh2whZq
  2422  nvWBfALC2VuNOM6C0rDY+HmhMlVt0XeqnybD9MuQALMit7Z00Cw2CIjNsBI9xBqD
  2423  xKK9CjUb7gzRUWSpB9jGHsvpEMHOzIFhufvH2Bz1XJw+Cl7khw==
  2424  -----END CERTIFICATE-----`
  2425  
  2426  func TestAdditionFieldsInGeneralSubtree(t *testing.T) {
  2427  	// Very rarely, certificates can include additional fields in the
  2428  	// GeneralSubtree structure. This tests that such certificates can be
  2429  	// parsed.
  2430  	block, _ := pem.Decode([]byte(additionalGeneralSubtreePEM))
  2431  	if _, err := ParseCertificate(block.Bytes); err != nil {
  2432  		t.Fatalf("failed to parse certificate: %s", err)
  2433  	}
  2434  }
  2435  
  2436  func TestEmptySerialNumber(t *testing.T) {
  2437  	template := Certificate{
  2438  		DNSNames: []string{"example.com"},
  2439  	}
  2440  
  2441  	for range 100 {
  2442  		derBytes, err := CreateCertificate(rand.Reader, &template, &template, &testPrivateKey.PublicKey, testPrivateKey)
  2443  		if err != nil {
  2444  			t.Fatalf("failed to create certificate: %s", err)
  2445  		}
  2446  
  2447  		cert, err := ParseCertificate(derBytes)
  2448  		if err != nil {
  2449  			t.Fatalf("failed to parse certificate: %s", err)
  2450  		}
  2451  
  2452  		if sign := cert.SerialNumber.Sign(); sign != 1 {
  2453  			t.Fatalf("generated a non positive serial, sign: %d", sign)
  2454  		}
  2455  
  2456  		b, err := asn1.Marshal(cert.SerialNumber)
  2457  		if err != nil {
  2458  			t.Fatalf("failed to marshal generated serial number: %s", err)
  2459  		}
  2460  		// subtract 2 for tag and length
  2461  		if l := len(b) - 2; l > 20 {
  2462  			t.Fatalf("generated serial number larger than 20 octets when encoded: %d", l)
  2463  		}
  2464  	}
  2465  }
  2466  
  2467  func TestEmptySubject(t *testing.T) {
  2468  	template := Certificate{
  2469  		SerialNumber: big.NewInt(1),
  2470  		DNSNames:     []string{"example.com"},
  2471  	}
  2472  
  2473  	derBytes, err := CreateCertificate(rand.Reader, &template, &template, &testPrivateKey.PublicKey, testPrivateKey)
  2474  	if err != nil {
  2475  		t.Fatalf("failed to create certificate: %s", err)
  2476  	}
  2477  
  2478  	cert, err := ParseCertificate(derBytes)
  2479  	if err != nil {
  2480  		t.Fatalf("failed to parse certificate: %s", err)
  2481  	}
  2482  
  2483  	for _, ext := range cert.Extensions {
  2484  		if ext.Id.Equal(oidExtensionSubjectAltName) {
  2485  			if !ext.Critical {
  2486  				t.Fatal("SAN extension is not critical")
  2487  			}
  2488  			return
  2489  		}
  2490  	}
  2491  
  2492  	t.Fatal("SAN extension is missing")
  2493  }
  2494  
  2495  // multipleURLsInCRLDPPEM contains two URLs in a single CRL DistributionPoint
  2496  // structure. It is taken from https://crt.sh/?id=12721534.
  2497  const multipleURLsInCRLDPPEM = `
  2498  -----BEGIN CERTIFICATE-----
  2499  MIIF4TCCBMmgAwIBAgIQc+6uFePfrahUGpXs8lhiTzANBgkqhkiG9w0BAQsFADCB
  2500  8zELMAkGA1UEBhMCRVMxOzA5BgNVBAoTMkFnZW5jaWEgQ2F0YWxhbmEgZGUgQ2Vy
  2501  dGlmaWNhY2lvIChOSUYgUS0wODAxMTc2LUkpMSgwJgYDVQQLEx9TZXJ2ZWlzIFB1
  2502  YmxpY3MgZGUgQ2VydGlmaWNhY2lvMTUwMwYDVQQLEyxWZWdldSBodHRwczovL3d3
  2503  dy5jYXRjZXJ0Lm5ldC92ZXJhcnJlbCAoYykwMzE1MDMGA1UECxMsSmVyYXJxdWlh
  2504  IEVudGl0YXRzIGRlIENlcnRpZmljYWNpbyBDYXRhbGFuZXMxDzANBgNVBAMTBkVD
  2505  LUFDQzAeFw0xNDA5MTgwODIxMDBaFw0zMDA5MTgwODIxMDBaMIGGMQswCQYDVQQG
  2506  EwJFUzEzMDEGA1UECgwqQ09OU09SQ0kgQURNSU5JU1RSQUNJTyBPQkVSVEEgREUg
  2507  Q0FUQUxVTllBMSowKAYDVQQLDCFTZXJ2ZWlzIFDDumJsaWNzIGRlIENlcnRpZmlj
  2508  YWNpw7MxFjAUBgNVBAMMDUVDLUNpdXRhZGFuaWEwggEiMA0GCSqGSIb3DQEBAQUA
  2509  A4IBDwAwggEKAoIBAQDFkHPRZPZlXTWZ5psJhbS/Gx+bxcTpGrlVQHHtIkgGz77y
  2510  TA7UZUFb2EQMncfbOhR0OkvQQn1aMvhObFJSR6nI+caf2D+h/m/InMl1MyH3S0Ak
  2511  YGZZsthnyC6KxqK2A/NApncrOreh70ULkQs45aOKsi1kR1W0zE+iFN+/P19P7AkL
  2512  Rl3bXBCVd8w+DLhcwRrkf1FCDw6cEqaFm3cGgf5cbBDMaVYAweWTxwBZAq2RbQAW
  2513  jE7mledcYghcZa4U6bUmCBPuLOnO8KMFAvH+aRzaf3ws5/ZoOVmryyLLJVZ54peZ
  2514  OwnP9EL4OuWzmXCjBifXR2IAblxs5JYj57tls45nAgMBAAGjggHaMIIB1jASBgNV
  2515  HRMBAf8ECDAGAQH/AgEAMA4GA1UdDwEB/wQEAwIBBjAdBgNVHQ4EFgQUC2hZPofI
  2516  oxUa4ECCIl+fHbLFNxUwHwYDVR0jBBgwFoAUoMOLRKo3pUW/l4Ba0fF4opvpXY0w
  2517  gdYGA1UdIASBzjCByzCByAYEVR0gADCBvzAxBggrBgEFBQcCARYlaHR0cHM6Ly93
  2518  d3cuYW9jLmNhdC9DQVRDZXJ0L1JlZ3VsYWNpbzCBiQYIKwYBBQUHAgIwfQx7QXF1
  2519  ZXN0IGNlcnRpZmljYXQgw6lzIGVtw6hzIMO6bmljYSBpIGV4Y2x1c2l2YW1lbnQg
  2520  YSBFbnRpdGF0cyBkZSBDZXJ0aWZpY2FjacOzLiBWZWdldSBodHRwczovL3d3dy5h
  2521  b2MuY2F0L0NBVENlcnQvUmVndWxhY2lvMDMGCCsGAQUFBwEBBCcwJTAjBggrBgEF
  2522  BQcwAYYXaHR0cDovL29jc3AuY2F0Y2VydC5jYXQwYgYDVR0fBFswWTBXoFWgU4Yn
  2523  aHR0cDovL2Vwc2NkLmNhdGNlcnQubmV0L2NybC9lYy1hY2MuY3JshihodHRwOi8v
  2524  ZXBzY2QyLmNhdGNlcnQubmV0L2NybC9lYy1hY2MuY3JsMA0GCSqGSIb3DQEBCwUA
  2525  A4IBAQChqFTjlAH5PyIhLjLgEs68CyNNC1+vDuZXRhy22TI83JcvGmQrZosPvVIL
  2526  PsUXx+C06Pfqmh48Q9S89X9K8w1SdJxP/rZeGEoRiKpwvQzM4ArD9QxyC8jirxex
  2527  3Umg9Ai/sXQ+1lBf6xw4HfUUr1WIp7pNHj0ZWLo106urqktcdeAFWme+/klis5fu
  2528  labCSVPuT/QpwakPrtqOhRms8vgpKiXa/eLtL9ZiA28X/Mker0zlAeTA7Z7uAnp6
  2529  oPJTlZu1Gg1ZDJueTWWsLlO+P+Wzm3MRRIbcgdRzm4mdO7ubu26SzX/aQXDhuih+
  2530  eVxXDTCfs7GUlxnjOp5j559X/N0A
  2531  -----END CERTIFICATE-----
  2532  `
  2533  
  2534  func TestMultipleURLsInCRLDP(t *testing.T) {
  2535  	block, _ := pem.Decode([]byte(multipleURLsInCRLDPPEM))
  2536  	cert, err := ParseCertificate(block.Bytes)
  2537  	if err != nil {
  2538  		t.Fatalf("failed to parse certificate: %s", err)
  2539  	}
  2540  
  2541  	want := []string{
  2542  		"http://epscd.catcert.net/crl/ec-acc.crl",
  2543  		"http://epscd2.catcert.net/crl/ec-acc.crl",
  2544  	}
  2545  	if got := cert.CRLDistributionPoints; !slices.Equal(got, want) {
  2546  		t.Errorf("CRL distribution points = %#v, want #%v", got, want)
  2547  	}
  2548  }
  2549  
  2550  const hexPKCS1TestPKCS8Key = "30820278020100300d06092a864886f70d0101010500048202623082025e02010002818100cfb1b5bf9685ffa97b4f99df4ff122b70e59ac9b992f3bc2b3dde17d53c1a34928719b02e8fd17839499bfbd515bd6ef99c7a1c47a239718fe36bfd824c0d96060084b5f67f0273443007a24dfaf5634f7772c9346e10eb294c2306671a5a5e719ae24b4de467291bc571014b0e02dec04534d66a9bb171d644b66b091780e8d020301000102818100b595778383c4afdbab95d2bfed12b3f93bb0a73a7ad952f44d7185fd9ec6c34de8f03a48770f2009c8580bcd275e9632714e9a5e3f32f29dc55474b2329ff0ebc08b3ffcb35bc96e6516b483df80a4a59cceb71918cbabf91564e64a39d7e35dce21cb3031824fdbc845dba6458852ec16af5dddf51a8397a8797ae0337b1439024100ea0eb1b914158c70db39031dd8904d6f18f408c85fbbc592d7d20dee7986969efbda081fdf8bc40e1b1336d6b638110c836bfdc3f314560d2e49cd4fbde1e20b024100e32a4e793b574c9c4a94c8803db5152141e72d03de64e54ef2c8ed104988ca780cd11397bc359630d01b97ebd87067c5451ba777cf045ca23f5912f1031308c702406dfcdbbd5a57c9f85abc4edf9e9e29153507b07ce0a7ef6f52e60dcfebe1b8341babd8b789a837485da6c8d55b29bbb142ace3c24a1f5b54b454d01b51e2ad03024100bd6a2b60dee01e1b3bfcef6a2f09ed027c273cdbbaf6ba55a80f6dcc64e4509ee560f84b4f3e076bd03b11e42fe71a3fdd2dffe7e0902c8584f8cad877cdc945024100aa512fa4ada69881f1d8bb8ad6614f192b83200aef5edf4811313d5ef30a86cbd0a90f7b025c71ea06ec6b34db6306c86b1040670fd8654ad7291d066d06d031"
  2551  const hexPKCS1TestECKey = "3081a40201010430bdb9839c08ee793d1157886a7a758a3c8b2a17a4df48f17ace57c72c56b4723cf21dcda21d4e1ad57ff034f19fcfd98ea00706052b81040022a16403620004feea808b5ee2429cfcce13c32160e1c960990bd050bb0fdf7222f3decd0a55008e32a6aa3c9062051c4cba92a7a3b178b24567412d43cdd2f882fa5addddd726fe3e208d2c26d733a773a597abb749714df7256ead5105fa6e7b3650de236b50"
  2552  
  2553  var pkcs1MismatchKeyTests = []struct {
  2554  	hexKey        string
  2555  	errorContains string
  2556  }{
  2557  	{hexKey: hexPKCS1TestPKCS8Key, errorContains: "use ParsePKCS8PrivateKey instead"},
  2558  	{hexKey: hexPKCS1TestECKey, errorContains: "use ParseECPrivateKey instead"},
  2559  }
  2560  
  2561  func TestPKCS1MismatchKeyFormat(t *testing.T) {
  2562  	for i, test := range pkcs1MismatchKeyTests {
  2563  		derBytes, _ := hex.DecodeString(test.hexKey)
  2564  		_, err := ParsePKCS1PrivateKey(derBytes)
  2565  		if !strings.Contains(err.Error(), test.errorContains) {
  2566  			t.Errorf("#%d: expected error containing %q, got %s", i, test.errorContains, err)
  2567  		}
  2568  	}
  2569  }
  2570  
  2571  func TestCreateRevocationList(t *testing.T) {
  2572  	ec256Priv, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
  2573  	if err != nil {
  2574  		t.Fatalf("Failed to generate ECDSA P256 key: %s", err)
  2575  	}
  2576  	_, ed25519Priv, err := ed25519.GenerateKey(rand.Reader)
  2577  	if err != nil {
  2578  		t.Fatalf("Failed to generate Ed25519 key: %s", err)
  2579  	}
  2580  
  2581  	// Generation command:
  2582  	// openssl req -x509 -newkey rsa -keyout key.pem -out cert.pem -days 365 -nodes -subj '/C=US/ST=California/L=San Francisco/O=Internet Widgets, Inc./OU=WWW/CN=Root/emailAddress=admin@example.com' -sha256 -addext basicConstraints=CA:TRUE -addext "keyUsage = digitalSignature, keyEncipherment, dataEncipherment, cRLSign, keyCertSign" -utf8
  2583  	utf8CAStr := "MIIEITCCAwmgAwIBAgIUXHXy7NdtDv+ClaHvIvlwCYiI4a4wDQYJKoZIhvcNAQELBQAwgZoxCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApDYWxpZm9ybmlhMRYwFAYDVQQHDA1TYW4gRnJhbmNpc2NvMR8wHQYDVQQKDBZJbnRlcm5ldCBXaWRnZXRzLCBJbmMuMQwwCgYDVQQLDANXV1cxDTALBgNVBAMMBFJvb3QxIDAeBgkqhkiG9w0BCQEWEWFkbWluQGV4YW1wbGUuY29tMB4XDTIyMDcwODE1MzgyMFoXDTIzMDcwODE1MzgyMFowgZoxCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApDYWxpZm9ybmlhMRYwFAYDVQQHDA1TYW4gRnJhbmNpc2NvMR8wHQYDVQQKDBZJbnRlcm5ldCBXaWRnZXRzLCBJbmMuMQwwCgYDVQQLDANXV1cxDTALBgNVBAMMBFJvb3QxIDAeBgkqhkiG9w0BCQEWEWFkbWluQGV4YW1wbGUuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAmXvp0WNjsZzySWT7Ce5zewQNKq8ujeZGphJ44Vdrwut/b6TcC4iYENds5+7/3PYwBllp3K5TRpCcafSxdhJsvA7/zWlHHNRcJhJLNt9qsKWP6ukI2Iw6OmFMg6kJQ8f67RXkT8HR3v0UqE+lWrA0g+oRuj4erLtfOtSpnl4nsE/Rs2qxbELFWAf7F5qMqH4dUyveWKrNT8eI6YQN+wBg0MAjoKRvDJnBhuo+IvvXX8Aq1QWUcBGPK3or/Ehxy5f/gEmSUXyEU1Ht/vATt2op+eRaEEpBdGRvO+DrKjlcQV2XMN18A9LAX6hCzH43sGye87dj7RZ9yj+waOYNaM7kFQIDAQABo10wWzAdBgNVHQ4EFgQUtbSlrW4hGL2kNjviM6wcCRwvOEEwHwYDVR0jBBgwFoAUtbSlrW4hGL2kNjviM6wcCRwvOEEwDAYDVR0TBAUwAwEB/zALBgNVHQ8EBAMCAbYwDQYJKoZIhvcNAQELBQADggEBAAko82YNNI2n/45L3ya21vufP6nZihIOIxgcRPUMX+IDJZk16qsFdcLgH3KAP8uiVLn8sULuCj35HpViR4IcAk2d+DqfG11l8kY+e5P7nYsViRfy0AatF59/sYlWf+3RdmPXfL70x4mE9OqlMdDm0kR2obps8rng83VLDNvj3R5sBnQwdw6LKLGzaE+RiCTmkH0+P6vnbOJ33su9+9al1+HvJUg3UM1Xq5Bw7TE8DQTetMV3c2Q35RQaJB9pQ4blJOnW9hfnt8yQzU6TU1bU4mRctTm1o1f8btPqUpi+/blhi5MUJK0/myj1XD00pmyfp8QAFl1EfqmTMIBMLg633A0="
  2584  	utf8CABytes, _ := base64.StdEncoding.DecodeString(utf8CAStr)
  2585  	utf8CA, _ := ParseCertificate(utf8CABytes)
  2586  
  2587  	utf8KeyStr := "MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQCZe+nRY2OxnPJJZPsJ7nN7BA0qry6N5kamEnjhV2vC639vpNwLiJgQ12zn7v/c9jAGWWncrlNGkJxp9LF2Emy8Dv/NaUcc1FwmEks232qwpY/q6QjYjDo6YUyDqQlDx/rtFeRPwdHe/RSoT6VasDSD6hG6Ph6su1861KmeXiewT9GzarFsQsVYB/sXmoyofh1TK95Yqs1Px4jphA37AGDQwCOgpG8MmcGG6j4i+9dfwCrVBZRwEY8reiv8SHHLl/+ASZJRfIRTUe3+8BO3ain55FoQSkF0ZG874OsqOVxBXZcw3XwD0sBfqELMfjewbJ7zt2PtFn3KP7Bo5g1ozuQVAgMBAAECggEAIscjKiD9PAe2Fs9c2tk/LYazfRKI1/pv072nylfGwToffCq8+ZgP7PEDamKLc4QNScME685MbFbkOlYJyBlQriQv7lmGlY/A+Zd3l410XWaGf9IiAP91Sjk13zd0M/micApf23qtlXt/LMwvSadXnvRw4+SjirxCTdBWRt5K2/ZAN550v7bHFk1EZc3UBF6sOoNsjQWh9Ek79UmQYJBPiZDBHO7O2fh2GSIbUutTma+Tb2i1QUZzg+AG3cseF3p1i3uhNrCh+p+01bJSzGTQsRod2xpD1tpWwR3kIftCOmD1XnhpaBQi7PXjEuNbfucaftnoYj2ShDdmgD5RkkbTAQKBgQC8Ghu5MQ/yIeqXg9IpcSxuWtUEAEfK33/cC/IvuntgbNEnWQm5Lif4D6a9zjkxiCS+9HhrUu5U2EV8NxOyaqmtub3Np1Z5mPuI9oiZ119bjUJd4X+jKOTaePWvOv/rL/pTHYqzXohVMrXy+DaTIq4lOcv3n72SuhuTcKU95rhKtQKBgQDQ4t+HsRZd5fJzoCgRQhlNK3EbXQDv2zXqMW3GfpF7GaDP18I530inRURSJa++rvi7/MCFg/TXVS3QC4HXtbzTYTqhE+VHzSr+/OcsqpLE8b0jKBDv/SBkz811PUJDs3LsX31DT3K0zUpMpNSd/5SYTyJKef9L6mxmwlC1S2Yv4QKBgQC57SiYDdnQIRwrtZ2nXvlm/xttAAX2jqJoU9qIuNA4yHaYaRcGVowlUvsiw9OelQ6VPTpGA0wWy0src5lhkrKzSFRHEe+U89U1VVJCljLoYKFIAJvUH5jOJh/am/vYca0COMIfeAJUDHLyfcwb9XyiyRVGZzvP62tUelSq8gIZvQKBgCAHeaDzzWsudCO4ngwvZ3PGwnwgoaElqrmzRJLYG3SVtGvKOJTpINnNLDGwZ6dEaw1gLyEJ38QY4oJxEULDMiXzVasXQuPkmMAqhUP7D7A1JPw8C4TQ+mOa3XUppHx/CpMl/S4SA5OnmsnvyE5Fv0IveCGVXUkFtAN5rihuXEfhAoGANUkuGU3A0Upk2mzv0JTGP4H95JFG93cqnyPNrYs30M6RkZNgTW27yyr+Nhs4/cMdrg1AYTB0+6ItQWSDmYLs7JEbBE/8L8fdD1irIcygjIHE9nJh96TgZCt61kVGLE8758lOdmoB2rZOpGwi16QIhdQb+IyozYqfX+lQUojL/W0="
  2588  	utf8KeyBytes, _ := base64.StdEncoding.DecodeString(utf8KeyStr)
  2589  	utf8KeyRaw, _ := ParsePKCS8PrivateKey(utf8KeyBytes)
  2590  	utf8Key := utf8KeyRaw.(crypto.Signer)
  2591  
  2592  	tests := []struct {
  2593  		name          string
  2594  		key           crypto.Signer
  2595  		issuer        *Certificate
  2596  		template      *RevocationList
  2597  		expectedError string
  2598  	}{
  2599  		{
  2600  			name:          "nil template",
  2601  			key:           ec256Priv,
  2602  			issuer:        nil,
  2603  			template:      nil,
  2604  			expectedError: "x509: template can not be nil",
  2605  		},
  2606  		{
  2607  			name:          "nil issuer",
  2608  			key:           ec256Priv,
  2609  			issuer:        nil,
  2610  			template:      &RevocationList{},
  2611  			expectedError: "x509: issuer can not be nil",
  2612  		},
  2613  		{
  2614  			name: "issuer doesn't have crlSign key usage bit set",
  2615  			key:  ec256Priv,
  2616  			issuer: &Certificate{
  2617  				KeyUsage: KeyUsageCertSign,
  2618  			},
  2619  			template:      &RevocationList{},
  2620  			expectedError: "x509: issuer must have the crlSign key usage bit set",
  2621  		},
  2622  		{
  2623  			name: "issuer missing SubjectKeyId",
  2624  			key:  ec256Priv,
  2625  			issuer: &Certificate{
  2626  				KeyUsage: KeyUsageCRLSign,
  2627  			},
  2628  			template:      &RevocationList{},
  2629  			expectedError: "x509: issuer certificate doesn't contain a subject key identifier",
  2630  		},
  2631  		{
  2632  			name: "nextUpdate before thisUpdate",
  2633  			key:  ec256Priv,
  2634  			issuer: &Certificate{
  2635  				KeyUsage: KeyUsageCRLSign,
  2636  				Subject: pkix.Name{
  2637  					CommonName: "testing",
  2638  				},
  2639  				SubjectKeyId: []byte{1, 2, 3},
  2640  			},
  2641  			template: &RevocationList{
  2642  				ThisUpdate: time.Time{}.Add(time.Hour),
  2643  				NextUpdate: time.Time{},
  2644  			},
  2645  			expectedError: "x509: template.ThisUpdate is after template.NextUpdate",
  2646  		},
  2647  		{
  2648  			name: "nil Number",
  2649  			key:  ec256Priv,
  2650  			issuer: &Certificate{
  2651  				KeyUsage: KeyUsageCRLSign,
  2652  				Subject: pkix.Name{
  2653  					CommonName: "testing",
  2654  				},
  2655  				SubjectKeyId: []byte{1, 2, 3},
  2656  			},
  2657  			template: &RevocationList{
  2658  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2659  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2660  			},
  2661  			expectedError: "x509: template contains nil Number field",
  2662  		},
  2663  		{
  2664  			name: "long Number",
  2665  			key:  ec256Priv,
  2666  			issuer: &Certificate{
  2667  				KeyUsage: KeyUsageCRLSign,
  2668  				Subject: pkix.Name{
  2669  					CommonName: "testing",
  2670  				},
  2671  				SubjectKeyId: []byte{1, 2, 3},
  2672  			},
  2673  			template: &RevocationList{
  2674  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2675  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2676  				Number:     big.NewInt(0).SetBytes(append([]byte{1}, make([]byte, 20)...)),
  2677  			},
  2678  			expectedError: "x509: CRL number exceeds 20 octets",
  2679  		},
  2680  		{
  2681  			name: "long Number (20 bytes, MSB set)",
  2682  			key:  ec256Priv,
  2683  			issuer: &Certificate{
  2684  				KeyUsage: KeyUsageCRLSign,
  2685  				Subject: pkix.Name{
  2686  					CommonName: "testing",
  2687  				},
  2688  				SubjectKeyId: []byte{1, 2, 3},
  2689  			},
  2690  			template: &RevocationList{
  2691  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2692  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2693  				Number:     big.NewInt(0).SetBytes(append([]byte{255}, make([]byte, 19)...)),
  2694  			},
  2695  			expectedError: "x509: CRL number exceeds 20 octets",
  2696  		},
  2697  		{
  2698  			name: "invalid signature algorithm",
  2699  			key:  ec256Priv,
  2700  			issuer: &Certificate{
  2701  				KeyUsage: KeyUsageCRLSign,
  2702  				Subject: pkix.Name{
  2703  					CommonName: "testing",
  2704  				},
  2705  				SubjectKeyId: []byte{1, 2, 3},
  2706  			},
  2707  			template: &RevocationList{
  2708  				SignatureAlgorithm: SHA256WithRSA,
  2709  				RevokedCertificates: []pkix.RevokedCertificate{
  2710  					{
  2711  						SerialNumber:   big.NewInt(2),
  2712  						RevocationTime: time.Time{}.Add(time.Hour),
  2713  					},
  2714  				},
  2715  				Number:     big.NewInt(5),
  2716  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2717  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2718  			},
  2719  			expectedError: "x509: requested SignatureAlgorithm does not match private key type",
  2720  		},
  2721  		{
  2722  			name: "valid",
  2723  			key:  ec256Priv,
  2724  			issuer: &Certificate{
  2725  				KeyUsage: KeyUsageCRLSign,
  2726  				Subject: pkix.Name{
  2727  					CommonName: "testing",
  2728  				},
  2729  				SubjectKeyId: []byte{1, 2, 3},
  2730  			},
  2731  			template: &RevocationList{
  2732  				RevokedCertificateEntries: []RevocationListEntry{
  2733  					{
  2734  						SerialNumber:   big.NewInt(2),
  2735  						RevocationTime: time.Time{}.Add(time.Hour),
  2736  					},
  2737  				},
  2738  				Number:     big.NewInt(5),
  2739  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2740  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2741  			},
  2742  		},
  2743  		{
  2744  			name: "valid, reason code",
  2745  			key:  ec256Priv,
  2746  			issuer: &Certificate{
  2747  				KeyUsage: KeyUsageCRLSign,
  2748  				Subject: pkix.Name{
  2749  					CommonName: "testing",
  2750  				},
  2751  				SubjectKeyId: []byte{1, 2, 3},
  2752  			},
  2753  			template: &RevocationList{
  2754  				RevokedCertificateEntries: []RevocationListEntry{
  2755  					{
  2756  						SerialNumber:   big.NewInt(2),
  2757  						RevocationTime: time.Time{}.Add(time.Hour),
  2758  						ReasonCode:     1,
  2759  					},
  2760  				},
  2761  				Number:     big.NewInt(5),
  2762  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2763  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2764  			},
  2765  		},
  2766  		{
  2767  			name: "valid, extra entry extension",
  2768  			key:  ec256Priv,
  2769  			issuer: &Certificate{
  2770  				KeyUsage: KeyUsageCRLSign,
  2771  				Subject: pkix.Name{
  2772  					CommonName: "testing",
  2773  				},
  2774  				SubjectKeyId: []byte{1, 2, 3},
  2775  			},
  2776  			template: &RevocationList{
  2777  				RevokedCertificateEntries: []RevocationListEntry{
  2778  					{
  2779  						SerialNumber:   big.NewInt(2),
  2780  						RevocationTime: time.Time{}.Add(time.Hour),
  2781  						ExtraExtensions: []pkix.Extension{
  2782  							{
  2783  								Id:    []int{2, 5, 29, 99},
  2784  								Value: []byte{5, 0},
  2785  							},
  2786  						},
  2787  					},
  2788  				},
  2789  				Number:     big.NewInt(5),
  2790  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2791  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2792  			},
  2793  		},
  2794  		{
  2795  			name: "valid, Ed25519 key",
  2796  			key:  ed25519Priv,
  2797  			issuer: &Certificate{
  2798  				KeyUsage: KeyUsageCRLSign,
  2799  				Subject: pkix.Name{
  2800  					CommonName: "testing",
  2801  				},
  2802  				SubjectKeyId: []byte{1, 2, 3},
  2803  			},
  2804  			template: &RevocationList{
  2805  				RevokedCertificateEntries: []RevocationListEntry{
  2806  					{
  2807  						SerialNumber:   big.NewInt(2),
  2808  						RevocationTime: time.Time{}.Add(time.Hour),
  2809  					},
  2810  				},
  2811  				Number:     big.NewInt(5),
  2812  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2813  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2814  			},
  2815  		},
  2816  		{
  2817  			name: "valid, non-default signature algorithm",
  2818  			key:  ec256Priv,
  2819  			issuer: &Certificate{
  2820  				KeyUsage: KeyUsageCRLSign,
  2821  				Subject: pkix.Name{
  2822  					CommonName: "testing",
  2823  				},
  2824  				SubjectKeyId: []byte{1, 2, 3},
  2825  			},
  2826  			template: &RevocationList{
  2827  				SignatureAlgorithm: ECDSAWithSHA512,
  2828  				RevokedCertificateEntries: []RevocationListEntry{
  2829  					{
  2830  						SerialNumber:   big.NewInt(2),
  2831  						RevocationTime: time.Time{}.Add(time.Hour),
  2832  					},
  2833  				},
  2834  				Number:     big.NewInt(5),
  2835  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2836  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2837  			},
  2838  		},
  2839  		{
  2840  			name: "valid, extra extension",
  2841  			key:  ec256Priv,
  2842  			issuer: &Certificate{
  2843  				KeyUsage: KeyUsageCRLSign,
  2844  				Subject: pkix.Name{
  2845  					CommonName: "testing",
  2846  				},
  2847  				SubjectKeyId: []byte{1, 2, 3},
  2848  			},
  2849  			template: &RevocationList{
  2850  				RevokedCertificateEntries: []RevocationListEntry{
  2851  					{
  2852  						SerialNumber:   big.NewInt(2),
  2853  						RevocationTime: time.Time{}.Add(time.Hour),
  2854  					},
  2855  				},
  2856  				Number:     big.NewInt(5),
  2857  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2858  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2859  				ExtraExtensions: []pkix.Extension{
  2860  					{
  2861  						Id:    []int{2, 5, 29, 99},
  2862  						Value: []byte{5, 0},
  2863  					},
  2864  				},
  2865  			},
  2866  		},
  2867  		{
  2868  			name: "valid, deprecated entries with extension",
  2869  			key:  ec256Priv,
  2870  			issuer: &Certificate{
  2871  				KeyUsage: KeyUsageCRLSign,
  2872  				Subject: pkix.Name{
  2873  					CommonName: "testing",
  2874  				},
  2875  				SubjectKeyId: []byte{1, 2, 3},
  2876  			},
  2877  			template: &RevocationList{
  2878  				RevokedCertificates: []pkix.RevokedCertificate{
  2879  					{
  2880  						SerialNumber:   big.NewInt(2),
  2881  						RevocationTime: time.Time{}.Add(time.Hour),
  2882  						Extensions: []pkix.Extension{
  2883  							{
  2884  								Id:    []int{2, 5, 29, 99},
  2885  								Value: []byte{5, 0},
  2886  							},
  2887  						},
  2888  					},
  2889  				},
  2890  				Number:     big.NewInt(5),
  2891  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2892  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2893  			},
  2894  		},
  2895  		{
  2896  			name: "valid, empty list",
  2897  			key:  ec256Priv,
  2898  			issuer: &Certificate{
  2899  				KeyUsage: KeyUsageCRLSign,
  2900  				Subject: pkix.Name{
  2901  					CommonName: "testing",
  2902  				},
  2903  				SubjectKeyId: []byte{1, 2, 3},
  2904  			},
  2905  			template: &RevocationList{
  2906  				Number:     big.NewInt(5),
  2907  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2908  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2909  			},
  2910  		},
  2911  		{
  2912  			name:   "valid CA with utf8 Subject fields including Email, empty list",
  2913  			key:    utf8Key,
  2914  			issuer: utf8CA,
  2915  			template: &RevocationList{
  2916  				Number:     big.NewInt(5),
  2917  				ThisUpdate: time.Time{}.Add(time.Hour * 24),
  2918  				NextUpdate: time.Time{}.Add(time.Hour * 48),
  2919  			},
  2920  		},
  2921  	}
  2922  
  2923  	for _, tc := range tests {
  2924  		t.Run(tc.name, func(t *testing.T) {
  2925  			crl, err := CreateRevocationList(rand.Reader, tc.template, tc.issuer, tc.key)
  2926  			if err != nil && tc.expectedError == "" {
  2927  				t.Fatalf("CreateRevocationList failed unexpectedly: %s", err)
  2928  			} else if err != nil && tc.expectedError != err.Error() {
  2929  				t.Fatalf("CreateRevocationList failed unexpectedly, wanted: %s, got: %s", tc.expectedError, err)
  2930  			} else if err == nil && tc.expectedError != "" {
  2931  				t.Fatalf("CreateRevocationList didn't fail, expected: %s", tc.expectedError)
  2932  			}
  2933  			if tc.expectedError != "" {
  2934  				return
  2935  			}
  2936  
  2937  			parsedCRL, err := ParseRevocationList(crl)
  2938  			if err != nil {
  2939  				t.Fatalf("Failed to parse generated CRL: %s", err)
  2940  			}
  2941  
  2942  			if tc.template.SignatureAlgorithm != UnknownSignatureAlgorithm &&
  2943  				parsedCRL.SignatureAlgorithm != tc.template.SignatureAlgorithm {
  2944  				t.Fatalf("SignatureAlgorithm mismatch: got %v; want %v.", parsedCRL.SignatureAlgorithm,
  2945  					tc.template.SignatureAlgorithm)
  2946  			}
  2947  
  2948  			if len(tc.template.RevokedCertificates) > 0 {
  2949  				if !reflect.DeepEqual(parsedCRL.RevokedCertificates, tc.template.RevokedCertificates) {
  2950  					t.Fatalf("RevokedCertificates mismatch: got %v; want %v.",
  2951  						parsedCRL.RevokedCertificates, tc.template.RevokedCertificates)
  2952  				}
  2953  			} else {
  2954  				if len(parsedCRL.RevokedCertificateEntries) != len(tc.template.RevokedCertificateEntries) {
  2955  					t.Fatalf("RevokedCertificateEntries length mismatch: got %d; want %d.",
  2956  						len(parsedCRL.RevokedCertificateEntries),
  2957  						len(tc.template.RevokedCertificateEntries))
  2958  				}
  2959  				for i, rce := range parsedCRL.RevokedCertificateEntries {
  2960  					expected := tc.template.RevokedCertificateEntries[i]
  2961  					if rce.SerialNumber.Cmp(expected.SerialNumber) != 0 {
  2962  						t.Fatalf("RevocationListEntry serial mismatch: got %d; want %d.",
  2963  							rce.SerialNumber, expected.SerialNumber)
  2964  					}
  2965  					if !rce.RevocationTime.Equal(expected.RevocationTime) {
  2966  						t.Fatalf("RevocationListEntry revocation time mismatch: got %v; want %v.",
  2967  							rce.RevocationTime, expected.RevocationTime)
  2968  					}
  2969  					if rce.ReasonCode != expected.ReasonCode {
  2970  						t.Fatalf("RevocationListEntry reason code mismatch: got %d; want %d.",
  2971  							rce.ReasonCode, expected.ReasonCode)
  2972  					}
  2973  				}
  2974  			}
  2975  
  2976  			if len(parsedCRL.Extensions) != 2+len(tc.template.ExtraExtensions) {
  2977  				t.Fatalf("Generated CRL has wrong number of extensions, wanted: %d, got: %d", 2+len(tc.template.ExtraExtensions), len(parsedCRL.Extensions))
  2978  			}
  2979  			expectedAKI, err := asn1.Marshal(authKeyId{Id: tc.issuer.SubjectKeyId})
  2980  			if err != nil {
  2981  				t.Fatalf("asn1.Marshal failed: %s", err)
  2982  			}
  2983  			akiExt := pkix.Extension{
  2984  				Id:    oidExtensionAuthorityKeyId,
  2985  				Value: expectedAKI,
  2986  			}
  2987  			if !reflect.DeepEqual(parsedCRL.Extensions[0], akiExt) {
  2988  				t.Fatalf("Unexpected first extension: got %v, want %v",
  2989  					parsedCRL.Extensions[0], akiExt)
  2990  			}
  2991  			expectedNum, err := asn1.Marshal(tc.template.Number)
  2992  			if err != nil {
  2993  				t.Fatalf("asn1.Marshal failed: %s", err)
  2994  			}
  2995  			crlExt := pkix.Extension{
  2996  				Id:    oidExtensionCRLNumber,
  2997  				Value: expectedNum,
  2998  			}
  2999  			if !reflect.DeepEqual(parsedCRL.Extensions[1], crlExt) {
  3000  				t.Fatalf("Unexpected second extension: got %v, want %v",
  3001  					parsedCRL.Extensions[1], crlExt)
  3002  			}
  3003  
  3004  			// With Go 1.19's updated RevocationList, we can now directly compare
  3005  			// the RawSubject of the certificate to RawIssuer on the parsed CRL.
  3006  			// However, this doesn't work with our hacked issuers above (that
  3007  			// aren't parsed from a proper DER bundle but are instead manually
  3008  			// constructed). Prefer RawSubject when it is set.
  3009  			if len(tc.issuer.RawSubject) > 0 {
  3010  				issuerSubj, err := subjectBytes(tc.issuer)
  3011  				if err != nil {
  3012  					t.Fatalf("failed to get issuer subject: %s", err)
  3013  				}
  3014  				if !bytes.Equal(issuerSubj, parsedCRL.RawIssuer) {
  3015  					t.Fatalf("Unexpected issuer subject; wanted: %v, got: %v", hex.EncodeToString(issuerSubj), hex.EncodeToString(parsedCRL.RawIssuer))
  3016  				}
  3017  			} else {
  3018  				// When we hack our custom Subject in the test cases above,
  3019  				// we don't set the additional fields (such as Names) in the
  3020  				// hacked issuer. Round-trip a parsing of pkix.Name so that
  3021  				// we add these missing fields for the comparison.
  3022  				issuerRDN := tc.issuer.Subject.ToRDNSequence()
  3023  				var caIssuer pkix.Name
  3024  				caIssuer.FillFromRDNSequence(&issuerRDN)
  3025  				if !reflect.DeepEqual(caIssuer, parsedCRL.Issuer) {
  3026  					t.Fatalf("Expected issuer.Subject, parsedCRL.Issuer to be the same; wanted: %#v, got: %#v", caIssuer, parsedCRL.Issuer)
  3027  				}
  3028  			}
  3029  
  3030  			if len(parsedCRL.Extensions[2:]) == 0 && len(tc.template.ExtraExtensions) == 0 {
  3031  				// If we don't have anything to check return early so we don't
  3032  				// hit a [] != nil false positive below.
  3033  				return
  3034  			}
  3035  			if !reflect.DeepEqual(parsedCRL.Extensions[2:], tc.template.ExtraExtensions) {
  3036  				t.Fatalf("Extensions mismatch: got %v; want %v.",
  3037  					parsedCRL.Extensions[2:], tc.template.ExtraExtensions)
  3038  			}
  3039  
  3040  			if tc.template.Number != nil && parsedCRL.Number == nil {
  3041  				t.Fatalf("Generated CRL missing Number: got nil, want %s",
  3042  					tc.template.Number.String())
  3043  			}
  3044  			if tc.template.Number != nil && tc.template.Number.Cmp(parsedCRL.Number) != 0 {
  3045  				t.Fatalf("Generated CRL has wrong Number: got %s, want %s",
  3046  					parsedCRL.Number.String(), tc.template.Number.String())
  3047  			}
  3048  			if !bytes.Equal(parsedCRL.AuthorityKeyId, tc.issuer.SubjectKeyId) {
  3049  				t.Fatalf("Generated CRL has wrong AuthorityKeyId: got %x, want %x",
  3050  					parsedCRL.AuthorityKeyId, tc.issuer.SubjectKeyId)
  3051  			}
  3052  		})
  3053  	}
  3054  }
  3055  
  3056  func TestRSAPSAParameters(t *testing.T) {
  3057  	generateParams := func(hashFunc crypto.Hash) []byte {
  3058  		var hashOID asn1.ObjectIdentifier
  3059  
  3060  		switch hashFunc {
  3061  		case crypto.SHA256:
  3062  			hashOID = oidSHA256
  3063  		case crypto.SHA384:
  3064  			hashOID = oidSHA384
  3065  		case crypto.SHA512:
  3066  			hashOID = oidSHA512
  3067  		}
  3068  
  3069  		params := pssParameters{
  3070  			Hash: pkix.AlgorithmIdentifier{
  3071  				Algorithm:  hashOID,
  3072  				Parameters: asn1.NullRawValue,
  3073  			},
  3074  			MGF: pkix.AlgorithmIdentifier{
  3075  				Algorithm: oidMGF1,
  3076  			},
  3077  			SaltLength:   hashFunc.Size(),
  3078  			TrailerField: 1,
  3079  		}
  3080  
  3081  		mgf1Params := pkix.AlgorithmIdentifier{
  3082  			Algorithm:  hashOID,
  3083  			Parameters: asn1.NullRawValue,
  3084  		}
  3085  
  3086  		var err error
  3087  		params.MGF.Parameters.FullBytes, err = asn1.Marshal(mgf1Params)
  3088  		if err != nil {
  3089  			t.Fatalf("failed to marshal MGF parameters: %s", err)
  3090  		}
  3091  
  3092  		serialized, err := asn1.Marshal(params)
  3093  		if err != nil {
  3094  			t.Fatalf("failed to marshal parameters: %s", err)
  3095  		}
  3096  
  3097  		return serialized
  3098  	}
  3099  
  3100  	for _, detail := range signatureAlgorithmDetails {
  3101  		if !detail.isRSAPSS {
  3102  			continue
  3103  		}
  3104  		generated := generateParams(detail.hash)
  3105  		if !bytes.Equal(detail.params.FullBytes, generated) {
  3106  			t.Errorf("hardcoded parameters for %s didn't match generated parameters: got (generated) %x, wanted (hardcoded) %x", detail.hash, generated, detail.params.FullBytes)
  3107  		}
  3108  	}
  3109  }
  3110  
  3111  func TestUnknownExtKey(t *testing.T) {
  3112  	const errorContains = "unknown extended key usage"
  3113  
  3114  	template := &Certificate{
  3115  		SerialNumber: big.NewInt(10),
  3116  		DNSNames:     []string{"foo"},
  3117  		ExtKeyUsage:  []ExtKeyUsage{ExtKeyUsage(-1)},
  3118  	}
  3119  
  3120  	_, err := CreateCertificate(rand.Reader, template, template, testPrivateKey.Public(), testPrivateKey)
  3121  	if !strings.Contains(err.Error(), errorContains) {
  3122  		t.Errorf("expected error containing %q, got %s", errorContains, err)
  3123  	}
  3124  }
  3125  
  3126  func TestIA5SANEnforcement(t *testing.T) {
  3127  	k, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
  3128  	if err != nil {
  3129  		t.Fatalf("ecdsa.GenerateKey failed: %s", err)
  3130  	}
  3131  
  3132  	testURL, err := url.Parse("https://example.com/")
  3133  	if err != nil {
  3134  		t.Fatalf("url.Parse failed: %s", err)
  3135  	}
  3136  	testURL.RawQuery = "∞"
  3137  
  3138  	marshalTests := []struct {
  3139  		name          string
  3140  		template      *Certificate
  3141  		expectedError string
  3142  	}{
  3143  		{
  3144  			name: "marshal: unicode dNSName",
  3145  			template: &Certificate{
  3146  				SerialNumber: big.NewInt(0),
  3147  				DNSNames:     []string{"∞"},
  3148  			},
  3149  			expectedError: "x509: \"∞\" cannot be encoded as an IA5String",
  3150  		},
  3151  		{
  3152  			name: "marshal: unicode rfc822Name",
  3153  			template: &Certificate{
  3154  				SerialNumber:   big.NewInt(0),
  3155  				EmailAddresses: []string{"∞"},
  3156  			},
  3157  			expectedError: "x509: \"∞\" cannot be encoded as an IA5String",
  3158  		},
  3159  		{
  3160  			name: "marshal: unicode uniformResourceIdentifier",
  3161  			template: &Certificate{
  3162  				SerialNumber: big.NewInt(0),
  3163  				URIs:         []*url.URL{testURL},
  3164  			},
  3165  			expectedError: "x509: \"https://example.com/?∞\" cannot be encoded as an IA5String",
  3166  		},
  3167  	}
  3168  
  3169  	for _, tc := range marshalTests {
  3170  		t.Run(tc.name, func(t *testing.T) {
  3171  			_, err := CreateCertificate(rand.Reader, tc.template, tc.template, k.Public(), k)
  3172  			if err == nil {
  3173  				t.Errorf("expected CreateCertificate to fail with template: %v", tc.template)
  3174  			} else if err.Error() != tc.expectedError {
  3175  				t.Errorf("unexpected error: got %q, want %q", err.Error(), tc.expectedError)
  3176  			}
  3177  		})
  3178  	}
  3179  
  3180  	unmarshalTests := []struct {
  3181  		name          string
  3182  		cert          string
  3183  		expectedError string
  3184  	}{
  3185  		{
  3186  			name:          "unmarshal: unicode dNSName",
  3187  			cert:          "308201083081aea003020102020100300a06082a8648ce3d04030230003022180f30303031303130313030303030305a180f30303031303130313030303030305a30003059301306072a8648ce3d020106082a8648ce3d0301070342000424bcc48180d8d9db794028f2575ebe3cac79f04d7b0d0151c5292e588aac3668c495f108c626168462e0668c9705e08a211dd103a659d2684e0adf8c2bfd47baa315301330110603551d110101ff040730058203e2889e300a06082a8648ce3d04030203490030460221008ac7827ac326a6ee0fa70b2afe99af575ec60b975f820f3c25f60fff43fbccd0022100bffeed93556722d43d13e461d5b3e33efc61f6349300327d3a0196cb6da501c2",
  3188  			expectedError: "x509: SAN dNSName is malformed",
  3189  		},
  3190  		{
  3191  			name:          "unmarshal: unicode rfc822Name",
  3192  			cert:          "308201083081aea003020102020100300a06082a8648ce3d04030230003022180f30303031303130313030303030305a180f30303031303130313030303030305a30003059301306072a8648ce3d020106082a8648ce3d0301070342000405cb4c4ba72aac980f7b11b0285191425e29e196ce7c5df1c83f56886566e517f196657cc1b73de89ab84ce503fd634e2f2af88fde24c63ca536dc3a5eed2665a315301330110603551d110101ff040730058103e2889e300a06082a8648ce3d0403020349003046022100ed1431cd4b9bb03d88d1511a0ec128a51204375764c716280dc36e2a60142c8902210088c96d25cfaf97eea851ff17d87bb6fe619d6546656e1739f35c3566051c3d0f",
  3193  			expectedError: "x509: SAN rfc822Name is malformed",
  3194  		},
  3195  		{
  3196  			name:          "unmarshal: unicode uniformResourceIdentifier",
  3197  			cert:          "3082011b3081c3a003020102020100300a06082a8648ce3d04030230003022180f30303031303130313030303030305a180f30303031303130313030303030305a30003059301306072a8648ce3d020106082a8648ce3d03010703420004ce0a79b511701d9188e1ea76bcc5907f1db51de6cc1a037b803f256e8588145ca409d120288bfeb4e38f3088104674d374b35bb91fc80d768d1d519dbe2b0b5aa32a302830260603551d110101ff041c301a861868747470733a2f2f6578616d706c652e636f6d2f3fe2889e300a06082a8648ce3d0403020347003044022044f4697779fd1dae1e382d2452413c5c5ca67851e267d6bc64a8d164977c172c0220505015e657637aa1945d46e7650b6f59b968fc1508ca8b152c99f782446dfc81",
  3198  			expectedError: "x509: SAN uniformResourceIdentifier is malformed",
  3199  		},
  3200  	}
  3201  
  3202  	for _, tc := range unmarshalTests {
  3203  		der, err := hex.DecodeString(tc.cert)
  3204  		if err != nil {
  3205  			t.Fatalf("failed to decode test cert: %s", err)
  3206  		}
  3207  		_, err = ParseCertificate(der)
  3208  		if err == nil {
  3209  			t.Error("expected CreateCertificate to fail")
  3210  		} else if err.Error() != tc.expectedError {
  3211  			t.Errorf("unexpected error: got %q, want %q", err.Error(), tc.expectedError)
  3212  		}
  3213  	}
  3214  }
  3215  
  3216  func BenchmarkCreateCertificate(b *testing.B) {
  3217  	template := &Certificate{
  3218  		SerialNumber: big.NewInt(10),
  3219  		DNSNames:     []string{"example.com"},
  3220  	}
  3221  	tests := []struct {
  3222  		name string
  3223  		gen  func() crypto.Signer
  3224  	}{
  3225  		{
  3226  			name: "RSA 2048",
  3227  			gen: func() crypto.Signer {
  3228  				k, err := rsa.GenerateKey(rand.Reader, 2048)
  3229  				if err != nil {
  3230  					b.Fatalf("failed to generate test key: %s", err)
  3231  				}
  3232  				return k
  3233  			},
  3234  		},
  3235  		{
  3236  			name: "ECDSA P256",
  3237  			gen: func() crypto.Signer {
  3238  				k, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
  3239  				if err != nil {
  3240  					b.Fatalf("failed to generate test key: %s", err)
  3241  				}
  3242  				return k
  3243  			},
  3244  		},
  3245  	}
  3246  
  3247  	for _, tc := range tests {
  3248  		k := tc.gen()
  3249  		b.ResetTimer()
  3250  		b.Run(tc.name, func(b *testing.B) {
  3251  			for i := 0; i < b.N; i++ {
  3252  				_, err := CreateCertificate(rand.Reader, template, template, k.Public(), k)
  3253  				if err != nil {
  3254  					b.Fatalf("failed to create certificate: %s", err)
  3255  				}
  3256  			}
  3257  		})
  3258  	}
  3259  }
  3260  
  3261  type brokenSigner struct {
  3262  	pub crypto.PublicKey
  3263  }
  3264  
  3265  func (bs *brokenSigner) Public() crypto.PublicKey {
  3266  	return bs.pub
  3267  }
  3268  
  3269  func (bs *brokenSigner) Sign(_ io.Reader, _ []byte, _ crypto.SignerOpts) ([]byte, error) {
  3270  	return []byte{1, 2, 3}, nil
  3271  }
  3272  
  3273  func TestCreateCertificateBrokenSigner(t *testing.T) {
  3274  	template := &Certificate{
  3275  		SerialNumber: big.NewInt(10),
  3276  		DNSNames:     []string{"example.com"},
  3277  	}
  3278  	expectedErr := "signature returned by signer is invalid"
  3279  	_, err := CreateCertificate(rand.Reader, template, template, testPrivateKey.Public(), &brokenSigner{testPrivateKey.Public()})
  3280  	if err == nil {
  3281  		t.Fatal("expected CreateCertificate to fail with a broken signer")
  3282  	} else if !strings.Contains(err.Error(), expectedErr) {
  3283  		t.Fatalf("CreateCertificate returned an unexpected error: got %q, want %q", err, expectedErr)
  3284  	}
  3285  }
  3286  
  3287  func TestCreateCertificateLegacy(t *testing.T) {
  3288  	sigAlg := MD5WithRSA
  3289  	template := &Certificate{
  3290  		SerialNumber:       big.NewInt(10),
  3291  		DNSNames:           []string{"example.com"},
  3292  		SignatureAlgorithm: sigAlg,
  3293  	}
  3294  	_, err := CreateCertificate(rand.Reader, template, template, testPrivateKey.Public(), &brokenSigner{testPrivateKey.Public()})
  3295  	if err == nil {
  3296  		t.Fatal("CreateCertificate didn't fail when SignatureAlgorithm = MD5WithRSA")
  3297  	}
  3298  }
  3299  
  3300  func (s *CertPool) mustCert(t *testing.T, n int) *Certificate {
  3301  	c, err := s.lazyCerts[n].getCert()
  3302  	if err != nil {
  3303  		t.Fatalf("failed to load cert %d: %v", n, err)
  3304  	}
  3305  	return c
  3306  }
  3307  
  3308  func allCerts(t *testing.T, p *CertPool) []*Certificate {
  3309  	all := make([]*Certificate, p.len())
  3310  	for i := range all {
  3311  		all[i] = p.mustCert(t, i)
  3312  	}
  3313  	return all
  3314  }
  3315  
  3316  // certPoolEqual reports whether a and b are equal, except for the
  3317  // function pointers.
  3318  func certPoolEqual(a, b *CertPool) bool {
  3319  	if (a != nil) != (b != nil) {
  3320  		return false
  3321  	}
  3322  	if a == nil {
  3323  		return true
  3324  	}
  3325  	if !reflect.DeepEqual(a.byName, b.byName) ||
  3326  		len(a.lazyCerts) != len(b.lazyCerts) {
  3327  		return false
  3328  	}
  3329  	for i := range a.lazyCerts {
  3330  		la, lb := a.lazyCerts[i], b.lazyCerts[i]
  3331  		if !bytes.Equal(la.rawSubject, lb.rawSubject) {
  3332  			return false
  3333  		}
  3334  		ca, err := la.getCert()
  3335  		if err != nil {
  3336  			panic(err)
  3337  		}
  3338  		cb, err := la.getCert()
  3339  		if err != nil {
  3340  			panic(err)
  3341  		}
  3342  		if !ca.Equal(cb) {
  3343  			return false
  3344  		}
  3345  	}
  3346  
  3347  	return true
  3348  }
  3349  
  3350  func TestCertificateRequestRoundtripFields(t *testing.T) {
  3351  	urlA, err := url.Parse("https://example.com/_")
  3352  	if err != nil {
  3353  		t.Fatal(err)
  3354  	}
  3355  	urlB, err := url.Parse("https://example.org/_")
  3356  	if err != nil {
  3357  		t.Fatal(err)
  3358  	}
  3359  	in := &CertificateRequest{
  3360  		DNSNames:       []string{"example.com", "example.org"},
  3361  		EmailAddresses: []string{"a@example.com", "b@example.com"},
  3362  		IPAddresses:    []net.IP{net.IPv4(192, 0, 2, 0), net.IPv6loopback},
  3363  		URIs:           []*url.URL{urlA, urlB},
  3364  	}
  3365  	out := marshalAndParseCSR(t, in)
  3366  
  3367  	if !slices.Equal(in.DNSNames, out.DNSNames) {
  3368  		t.Fatalf("Unexpected DNSNames: got %v, want %v", out.DNSNames, in.DNSNames)
  3369  	}
  3370  	if !slices.Equal(in.EmailAddresses, out.EmailAddresses) {
  3371  		t.Fatalf("Unexpected EmailAddresses: got %v, want %v", out.EmailAddresses, in.EmailAddresses)
  3372  	}
  3373  	if len(in.IPAddresses) != len(out.IPAddresses) ||
  3374  		!in.IPAddresses[0].Equal(out.IPAddresses[0]) ||
  3375  		!in.IPAddresses[1].Equal(out.IPAddresses[1]) {
  3376  		t.Fatalf("Unexpected IPAddresses: got %v, want %v", out.IPAddresses, in.IPAddresses)
  3377  	}
  3378  	if !reflect.DeepEqual(in.URIs, out.URIs) {
  3379  		t.Fatalf("Unexpected URIs: got %v, want %v", out.URIs, in.URIs)
  3380  	}
  3381  }
  3382  
  3383  func BenchmarkParseCertificate(b *testing.B) {
  3384  	cases := []struct {
  3385  		name string
  3386  		pem  string
  3387  	}{
  3388  		{
  3389  			name: "ecdsa leaf",
  3390  			pem: `-----BEGIN CERTIFICATE-----
  3391  MIIINjCCBx6gAwIBAgIQHdQ6oBMoe/MJAAAAAEHzmTANBgkqhkiG9w0BAQsFADBG
  3392  MQswCQYDVQQGEwJVUzEiMCAGA1UEChMZR29vZ2xlIFRydXN0IFNlcnZpY2VzIExM
  3393  QzETMBEGA1UEAxMKR1RTIENBIDFDMzAeFw0yMDEyMDgwOTExMzZaFw0yMTAzMDIw
  3394  OTExMzVaMBcxFTATBgNVBAMMDCouZ29vZ2xlLmNvbTBZMBMGByqGSM49AgEGCCqG
  3395  SM49AwEHA0IABEFYegyHh1AHRS1nar5+zYJgMACcsIQMtg0YMyK/59ml8ERIt/JF
  3396  kXM3XIvQuCJhghUawZrrAcAs8djZF1U9M4mjggYYMIIGFDAOBgNVHQ8BAf8EBAMC
  3397  B4AwEwYDVR0lBAwwCgYIKwYBBQUHAwEwDAYDVR0TAQH/BAIwADAdBgNVHQ4EFgQU
  3398  6SWWF36XBsmXJ6iV0EHPXUFoMbwwHwYDVR0jBBgwFoAUinR/r4XN7pXNPZzQ4kYU
  3399  83E1HScwagYIKwYBBQUHAQEEXjBcMCcGCCsGAQUFBzABhhtodHRwOi8vb2NzcC5w
  3400  a2kuZ29vZy9ndHMxYzMwMQYIKwYBBQUHMAKGJWh0dHA6Ly9wa2kuZ29vZy9yZXBv
  3401  L2NlcnRzL2d0czFjMy5kZXIwggTCBgNVHREEggS5MIIEtYIMKi5nb29nbGUuY29t
  3402  gg0qLmFuZHJvaWQuY29tghYqLmFwcGVuZ2luZS5nb29nbGUuY29tggkqLmJkbi5k
  3403  ZXaCEiouY2xvdWQuZ29vZ2xlLmNvbYIYKi5jcm93ZHNvdXJjZS5nb29nbGUuY29t
  3404  ghgqLmRhdGFjb21wdXRlLmdvb2dsZS5jb22CBiouZy5jb4IOKi5nY3AuZ3Z0Mi5j
  3405  b22CESouZ2NwY2RuLmd2dDEuY29tggoqLmdncGh0LmNugg4qLmdrZWNuYXBwcy5j
  3406  boIWKi5nb29nbGUtYW5hbHl0aWNzLmNvbYILKi5nb29nbGUuY2GCCyouZ29vZ2xl
  3407  LmNsgg4qLmdvb2dsZS5jby5pboIOKi5nb29nbGUuY28uanCCDiouZ29vZ2xlLmNv
  3408  LnVrgg8qLmdvb2dsZS5jb20uYXKCDyouZ29vZ2xlLmNvbS5hdYIPKi5nb29nbGUu
  3409  Y29tLmJygg8qLmdvb2dsZS5jb20uY2+CDyouZ29vZ2xlLmNvbS5teIIPKi5nb29n
  3410  bGUuY29tLnRygg8qLmdvb2dsZS5jb20udm6CCyouZ29vZ2xlLmRlggsqLmdvb2ds
  3411  ZS5lc4ILKi5nb29nbGUuZnKCCyouZ29vZ2xlLmh1ggsqLmdvb2dsZS5pdIILKi5n
  3412  b29nbGUubmyCCyouZ29vZ2xlLnBsggsqLmdvb2dsZS5wdIISKi5nb29nbGVhZGFw
  3413  aXMuY29tgg8qLmdvb2dsZWFwaXMuY26CESouZ29vZ2xlY25hcHBzLmNughQqLmdv
  3414  b2dsZWNvbW1lcmNlLmNvbYIRKi5nb29nbGV2aWRlby5jb22CDCouZ3N0YXRpYy5j
  3415  boINKi5nc3RhdGljLmNvbYISKi5nc3RhdGljY25hcHBzLmNuggoqLmd2dDEuY29t
  3416  ggoqLmd2dDIuY29tghQqLm1ldHJpYy5nc3RhdGljLmNvbYIMKi51cmNoaW4uY29t
  3417  ghAqLnVybC5nb29nbGUuY29tghMqLndlYXIuZ2tlY25hcHBzLmNughYqLnlvdXR1
  3418  YmUtbm9jb29raWUuY29tgg0qLnlvdXR1YmUuY29tghYqLnlvdXR1YmVlZHVjYXRp
  3419  b24uY29tghEqLnlvdXR1YmVraWRzLmNvbYIHKi55dC5iZYILKi55dGltZy5jb22C
  3420  GmFuZHJvaWQuY2xpZW50cy5nb29nbGUuY29tggthbmRyb2lkLmNvbYIbZGV2ZWxv
  3421  cGVyLmFuZHJvaWQuZ29vZ2xlLmNughxkZXZlbG9wZXJzLmFuZHJvaWQuZ29vZ2xl
  3422  LmNuggRnLmNvgghnZ3BodC5jboIMZ2tlY25hcHBzLmNuggZnb28uZ2yCFGdvb2ds
  3423  ZS1hbmFseXRpY3MuY29tggpnb29nbGUuY29tgg9nb29nbGVjbmFwcHMuY26CEmdv
  3424  b2dsZWNvbW1lcmNlLmNvbYIYc291cmNlLmFuZHJvaWQuZ29vZ2xlLmNuggp1cmNo
  3425  aW4uY29tggp3d3cuZ29vLmdsggh5b3V0dS5iZYILeW91dHViZS5jb22CFHlvdXR1
  3426  YmVlZHVjYXRpb24uY29tgg95b3V0dWJla2lkcy5jb22CBXl0LmJlMCEGA1UdIAQa
  3427  MBgwCAYGZ4EMAQIBMAwGCisGAQQB1nkCBQMwNQYDVR0fBC4wLDAqoCigJoYkaHR0
  3428  cDovL2NybC5wa2kuZ29vZy9ndHNyMS9ndHMxYzMuY3JsMBMGCisGAQQB1nkCBAMB
  3429  Af8EAgUAMA0GCSqGSIb3DQEBCwUAA4IBAQAlDQm5zY7JcPxcJ9ulfTGsWV/m6Pro
  3430  gLYmAlBUPGKy313aetT4Zjz44ZseVtUOKsXVHh4avPA9O+ta1FgkASlbkgJ05ivb
  3431  j/+MMqkrLemdMv9Svvx3CNaAq2jJ2E+8GdrA1RzMkiNthJCiRafaPnXnN6hOHGNr
  3432  GtqYfMHsvrRHW8J2IPHW0/MUHmJ/NDu/vNchxke2OEfCPLtseo3hJt8l8HbH+yE8
  3433  DFrt8YVRi1CLomEyuPJDF4og3O3ZsoXuxcPd9UPxULOCxycdolRw8Iv/Xgr082j3
  3434  svXC3HUd3apM2Yy3xJAlk/mUkzVXfdJZ+Zy1huNsUoJ+gM8rmpyGhYyx
  3435  -----END CERTIFICATE-----`,
  3436  		},
  3437  		{
  3438  			name: "rsa leaf",
  3439  			pem: `-----BEGIN CERTIFICATE-----
  3440  MIIJXjCCCEagAwIBAgIRAPYaTUsjP4iRBQAAAACHSSgwDQYJKoZIhvcNAQELBQAw
  3441  QjELMAkGA1UEBhMCVVMxHjAcBgNVBAoTFUdvb2dsZSBUcnVzdCBTZXJ2aWNlczET
  3442  MBEGA1UEAxMKR1RTIENBIDFPMTAeFw0yMTAxMjYwODQ2MzRaFw0yMTA0MjAwODQ2
  3443  MzNaMGYxCzAJBgNVBAYTAlVTMRMwEQYDVQQIEwpDYWxpZm9ybmlhMRYwFAYDVQQH
  3444  Ew1Nb3VudGFpbiBWaWV3MRMwEQYDVQQKEwpHb29nbGUgTExDMRUwEwYDVQQDDAwq
  3445  Lmdvb2dsZS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC76xx0
  3446  UdZ36/41rZNPfQ/yQ05vsBLUO0d+3uMOhvDlpst+XvIsG6L+vLDgf3RiQRFlei0h
  3447  KqqLOtWLDc/y0+OmaaC+8ft1zljBYdvQlAYoZrT79Cc5pAIDq7G1OZ7cC4ahDno/
  3448  n46FHjT/UTUAMYa8cKWBaMPneMIsKvn8nMdZzHkfO2nUd6OEecn90XweMvNmx8De
  3449  6h5AlIgG3m66hkD/UCSdxn7yJHBQVdHgkfTqzv3sz2YyBQGNi288F1bn541f6khE
  3450  fYti1MvXRtkky7yLCQNUG6PtvuSU4cKaNvRklHigf5i1nVdGEuH61gAElZIklSia
  3451  OVK46UyU4DGtbdWNAgMBAAGjggYpMIIGJTAOBgNVHQ8BAf8EBAMCBaAwEwYDVR0l
  3452  BAwwCgYIKwYBBQUHAwEwDAYDVR0TAQH/BAIwADAdBgNVHQ4EFgQU8zCvllLd3jhB
  3453  k//+Wdjo40Q+T3gwHwYDVR0jBBgwFoAUmNH4bhDrz5vsYJ8YkBug630J/SswaAYI
  3454  KwYBBQUHAQEEXDBaMCsGCCsGAQUFBzABhh9odHRwOi8vb2NzcC5wa2kuZ29vZy9n
  3455  dHMxbzFjb3JlMCsGCCsGAQUFBzAChh9odHRwOi8vcGtpLmdvb2cvZ3NyMi9HVFMx
  3456  TzEuY3J0MIIE1wYDVR0RBIIEzjCCBMqCDCouZ29vZ2xlLmNvbYINKi5hbmRyb2lk
  3457  LmNvbYIWKi5hcHBlbmdpbmUuZ29vZ2xlLmNvbYIJKi5iZG4uZGV2ghIqLmNsb3Vk
  3458  Lmdvb2dsZS5jb22CGCouY3Jvd2Rzb3VyY2UuZ29vZ2xlLmNvbYIYKi5kYXRhY29t
  3459  cHV0ZS5nb29nbGUuY29tghMqLmZsYXNoLmFuZHJvaWQuY29tggYqLmcuY2+CDiou
  3460  Z2NwLmd2dDIuY29tghEqLmdjcGNkbi5ndnQxLmNvbYIKKi5nZ3BodC5jboIOKi5n
  3461  a2VjbmFwcHMuY26CFiouZ29vZ2xlLWFuYWx5dGljcy5jb22CCyouZ29vZ2xlLmNh
  3462  ggsqLmdvb2dsZS5jbIIOKi5nb29nbGUuY28uaW6CDiouZ29vZ2xlLmNvLmpwgg4q
  3463  Lmdvb2dsZS5jby51a4IPKi5nb29nbGUuY29tLmFygg8qLmdvb2dsZS5jb20uYXWC
  3464  DyouZ29vZ2xlLmNvbS5icoIPKi5nb29nbGUuY29tLmNvgg8qLmdvb2dsZS5jb20u
  3465  bXiCDyouZ29vZ2xlLmNvbS50coIPKi5nb29nbGUuY29tLnZuggsqLmdvb2dsZS5k
  3466  ZYILKi5nb29nbGUuZXOCCyouZ29vZ2xlLmZyggsqLmdvb2dsZS5odYILKi5nb29n
  3467  bGUuaXSCCyouZ29vZ2xlLm5sggsqLmdvb2dsZS5wbIILKi5nb29nbGUucHSCEiou
  3468  Z29vZ2xlYWRhcGlzLmNvbYIPKi5nb29nbGVhcGlzLmNughEqLmdvb2dsZWNuYXBw
  3469  cy5jboIUKi5nb29nbGVjb21tZXJjZS5jb22CESouZ29vZ2xldmlkZW8uY29tggwq
  3470  LmdzdGF0aWMuY26CDSouZ3N0YXRpYy5jb22CEiouZ3N0YXRpY2NuYXBwcy5jboIK
  3471  Ki5ndnQxLmNvbYIKKi5ndnQyLmNvbYIUKi5tZXRyaWMuZ3N0YXRpYy5jb22CDCou
  3472  dXJjaGluLmNvbYIQKi51cmwuZ29vZ2xlLmNvbYITKi53ZWFyLmdrZWNuYXBwcy5j
  3473  boIWKi55b3V0dWJlLW5vY29va2llLmNvbYINKi55b3V0dWJlLmNvbYIWKi55b3V0
  3474  dWJlZWR1Y2F0aW9uLmNvbYIRKi55b3V0dWJla2lkcy5jb22CByoueXQuYmWCCyou
  3475  eXRpbWcuY29tghphbmRyb2lkLmNsaWVudHMuZ29vZ2xlLmNvbYILYW5kcm9pZC5j
  3476  b22CG2RldmVsb3Blci5hbmRyb2lkLmdvb2dsZS5jboIcZGV2ZWxvcGVycy5hbmRy
  3477  b2lkLmdvb2dsZS5jboIEZy5jb4IIZ2dwaHQuY26CDGdrZWNuYXBwcy5jboIGZ29v
  3478  LmdsghRnb29nbGUtYW5hbHl0aWNzLmNvbYIKZ29vZ2xlLmNvbYIPZ29vZ2xlY25h
  3479  cHBzLmNughJnb29nbGVjb21tZXJjZS5jb22CGHNvdXJjZS5hbmRyb2lkLmdvb2ds
  3480  ZS5jboIKdXJjaGluLmNvbYIKd3d3Lmdvby5nbIIIeW91dHUuYmWCC3lvdXR1YmUu
  3481  Y29tghR5b3V0dWJlZWR1Y2F0aW9uLmNvbYIPeW91dHViZWtpZHMuY29tggV5dC5i
  3482  ZTAhBgNVHSAEGjAYMAgGBmeBDAECAjAMBgorBgEEAdZ5AgUDMDMGA1UdHwQsMCow
  3483  KKAmoCSGImh0dHA6Ly9jcmwucGtpLmdvb2cvR1RTMU8xY29yZS5jcmwwEwYKKwYB
  3484  BAHWeQIEAwEB/wQCBQAwDQYJKoZIhvcNAQELBQADggEBAHh9/ozYUGRd+W5akWlM
  3485  4WvX808TK2oUISnagbxCCFZ2trpg2oi03CJf4o4o3Je5Qzzz10s22oQY6gPHAR0B
  3486  QHzrpqAveQw9D5vd8xjgtQ/SAujPzPKNQee5511rS7/EKW9I83ccd5XhhoEyx8A1
  3487  /65RTS+2hKpJKTMkr0yHBPJV7kUW+n/KIef5YaSOA9VYK7hyH0niDpvm9EmoqvWS
  3488  U5xAFAe/Xrrq3sxTuDJPQA8alk6h/ql5Klkw6dL53csiPka/MevDqdifWkzuT/6n
  3489  YK/ePeJzPD17FA9V+N1rcuF3Wk29AZvCOSasdIkIuE82vGr3dfNrsrn9E9lWIbCr
  3490  Qc4=
  3491  -----END CERTIFICATE-----`,
  3492  		},
  3493  	}
  3494  	for _, c := range cases {
  3495  		b.Run(c.name, func(b *testing.B) {
  3496  			pemBlock, _ := pem.Decode([]byte(c.pem))
  3497  			b.ReportAllocs()
  3498  			b.ResetTimer()
  3499  			for i := 0; i < b.N; i++ {
  3500  				_, err := ParseCertificate(pemBlock.Bytes)
  3501  				if err != nil {
  3502  					b.Fatal(err)
  3503  				}
  3504  			}
  3505  		})
  3506  	}
  3507  }
  3508  
  3509  func TestParseCertificateRawEquals(t *testing.T) {
  3510  	p, _ := pem.Decode([]byte(pemCertificate))
  3511  	cert, err := ParseCertificate(p.Bytes)
  3512  	if err != nil {
  3513  		t.Fatalf("failed to parse certificate: %s", err)
  3514  	}
  3515  	if !bytes.Equal(p.Bytes, cert.Raw) {
  3516  		t.Fatalf("unexpected Certificate.Raw\ngot: %x\nwant: %x\n", cert.Raw, p.Bytes)
  3517  	}
  3518  }
  3519  
  3520  // mismatchingSigAlgIDPEM contains a certificate where the Certificate
  3521  // signatureAlgorithm and the TBSCertificate signature contain
  3522  // mismatching OIDs
  3523  const mismatchingSigAlgIDPEM = `-----BEGIN CERTIFICATE-----
  3524  MIIBBzCBrqADAgECAgEAMAoGCCqGSM49BAMCMAAwIhgPMDAwMTAxMDEwMDAwMDBa
  3525  GA8wMDAxMDEwMTAwMDAwMFowADBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABOqV
  3526  EDuVXxwZgIU3+dOwv1SsMu0xuV48hf7xmK8n7sAMYgllB+96DnPqBeboJj4snYnx
  3527  0AcE0PDVQ1l4Z3YXsQWjFTATMBEGA1UdEQEB/wQHMAWCA2FzZDAKBggqhkjOPQQD
  3528  AwNIADBFAiBi1jz/T2HT5nAfrD7zsgR+68qh7Erc6Q4qlxYBOgKG4QIhAOtjIn+Q
  3529  tA+bq+55P3ntxTOVRq0nv1mwnkjwt9cQR9Fn
  3530  -----END CERTIFICATE-----`
  3531  
  3532  // mismatchingSigAlgParamPEM contains a certificate where the Certificate
  3533  // signatureAlgorithm and the TBSCertificate signature contain
  3534  // mismatching parameters
  3535  const mismatchingSigAlgParamPEM = `-----BEGIN CERTIFICATE-----
  3536  MIIBCTCBrqADAgECAgEAMAoGCCqGSM49BAMCMAAwIhgPMDAwMTAxMDEwMDAwMDBa
  3537  GA8wMDAxMDEwMTAwMDAwMFowADBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABOqV
  3538  EDuVXxwZgIU3+dOwv1SsMu0xuV48hf7xmK8n7sAMYgllB+96DnPqBeboJj4snYnx
  3539  0AcE0PDVQ1l4Z3YXsQWjFTATMBEGA1UdEQEB/wQHMAWCA2FzZDAMBggqhkjOPQQD
  3540  AgUAA0gAMEUCIGLWPP9PYdPmcB+sPvOyBH7ryqHsStzpDiqXFgE6AobhAiEA62Mi
  3541  f5C0D5ur7nk/ee3FM5VGrSe/WbCeSPC31xBH0Wc=
  3542  -----END CERTIFICATE-----`
  3543  
  3544  func TestSigAlgMismatch(t *testing.T) {
  3545  	for _, certPEM := range []string{mismatchingSigAlgIDPEM, mismatchingSigAlgParamPEM} {
  3546  		b, _ := pem.Decode([]byte(certPEM))
  3547  		if b == nil {
  3548  			t.Fatalf("couldn't decode test certificate")
  3549  		}
  3550  		_, err := ParseCertificate(b.Bytes)
  3551  		if err == nil {
  3552  			t.Fatalf("expected ParseCertificate to fail")
  3553  		}
  3554  		expected := "x509: inner and outer signature algorithm identifiers don't match"
  3555  		if err.Error() != expected {
  3556  			t.Errorf("unexpected error from ParseCertificate: got %q, want %q", err.Error(), expected)
  3557  		}
  3558  	}
  3559  }
  3560  
  3561  const optionalAuthKeyIDPEM = `-----BEGIN CERTIFICATE-----
  3562  MIIFEjCCBHugAwIBAgICAQwwDQYJKoZIhvcNAQEFBQAwgbsxJDAiBgNVBAcTG1Zh
  3563  bGlDZXJ0IFZhbGlkYXRpb24gTmV0d29yazEXMBUGA1UEChMOVmFsaUNlcnQsIElu
  3564  Yy4xNTAzBgNVBAsTLFZhbGlDZXJ0IENsYXNzIDIgUG9saWN5IFZhbGlkYXRpb24g
  3565  QXV0aG9yaXR5MSEwHwYDVQQDExhodHRwOi8vd3d3LnZhbGljZXJ0LmNvbS8xIDAe
  3566  BgkqhkiG9w0BCQEWEWluZm9AdmFsaWNlcnQuY29tMB4XDTA0MDYyOTE3MzkxNloX
  3567  DTI0MDYyOTE3MzkxNlowaDELMAkGA1UEBhMCVVMxJTAjBgNVBAoTHFN0YXJmaWVs
  3568  ZCBUZWNobm9sb2dpZXMsIEluYy4xMjAwBgNVBAsTKVN0YXJmaWVsZCBDbGFzcyAy
  3569  IENlcnRpZmljYXRpb24gQXV0aG9yaXR5MIIBIDANBgkqhkiG9w0BAQEFAAOCAQ0A
  3570  MIIBCAKCAQEAtzLI/ulxpgSFrQwRZN/OTe/IAxiHP6Gr+zymn/DDodrU2G4rU5D7
  3571  JKQ+hPCe6F/s5SdE9SimP3ve4CrwyK9TL57KBQGTHo9mHDmnTfpatnMEJWbrd3/n
  3572  WcZKmSUUVOsmx/N/GdUwcI+vsEYq/63rKe3Xn6oEh6PU+YmlNF/bQ5GCNtlmPLG4
  3573  uYL9nDo+EMg77wZlZnqbGRg9/3FRPDAuX749d3OyXQZswyNWmiuFJpIcpwKz5D8N
  3574  rwh5grg2Peqc0zWzvGnK9cyd6P1kjReAM25eSl2ZyR6HtJ0awNVuEzUjXt+bXz3v
  3575  1vd2wuo+u3gNHEJnawTY+Nbab4vyRKABqwIBA6OCAfMwggHvMB0GA1UdDgQWBBS/
  3576  X7fRzt0fhvRbVazc1xDCDqmI5zCB0gYDVR0jBIHKMIHHoYHBpIG+MIG7MSQwIgYD
  3577  VQQHExtWYWxpQ2VydCBWYWxpZGF0aW9uIE5ldHdvcmsxFzAVBgNVBAoTDlZhbGlD
  3578  ZXJ0LCBJbmMuMTUwMwYDVQQLEyxWYWxpQ2VydCBDbGFzcyAyIFBvbGljeSBWYWxp
  3579  ZGF0aW9uIEF1dGhvcml0eTEhMB8GA1UEAxMYaHR0cDovL3d3dy52YWxpY2VydC5j
  3580  b20vMSAwHgYJKoZIhvcNAQkBFhFpbmZvQHZhbGljZXJ0LmNvbYIBATAPBgNVHRMB
  3581  Af8EBTADAQH/MDkGCCsGAQUFBwEBBC0wKzApBggrBgEFBQcwAYYdaHR0cDovL29j
  3582  c3Auc3RhcmZpZWxkdGVjaC5jb20wSgYDVR0fBEMwQTA/oD2gO4Y5aHR0cDovL2Nl
  3583  cnRpZmljYXRlcy5zdGFyZmllbGR0ZWNoLmNvbS9yZXBvc2l0b3J5L3Jvb3QuY3Js
  3584  MFEGA1UdIARKMEgwRgYEVR0gADA+MDwGCCsGAQUFBwIBFjBodHRwOi8vY2VydGlm
  3585  aWNhdGVzLnN0YXJmaWVsZHRlY2guY29tL3JlcG9zaXRvcnkwDgYDVR0PAQH/BAQD
  3586  AgEGMA0GCSqGSIb3DQEBBQUAA4GBAKVi8afCXSWlcD284ipxs33kDTcdVWptobCr
  3587  mADkhWBKIMuh8D1195TaQ39oXCUIuNJ9MxB73HZn8bjhU3zhxoNbKXuNSm8uf0So
  3588  GkVrMgfHeMpkksK0hAzc3S1fTbvdiuo43NlmouxBulVtWmQ9twPMHOKRUJ7jCUSV
  3589  FxdzPcwl
  3590  -----END CERTIFICATE-----`
  3591  
  3592  func TestAuthKeyIdOptional(t *testing.T) {
  3593  	b, _ := pem.Decode([]byte(optionalAuthKeyIDPEM))
  3594  	if b == nil {
  3595  		t.Fatalf("couldn't decode test certificate")
  3596  	}
  3597  	_, err := ParseCertificate(b.Bytes)
  3598  	if err != nil {
  3599  		t.Fatalf("ParseCertificate to failed to parse certificate with optional authority key identifier fields: %s", err)
  3600  	}
  3601  }
  3602  
  3603  const largeOIDPEM = `
  3604  Certificate:
  3605      Data:
  3606          Version: 3 (0x2)
  3607          Serial Number:
  3608              da:ba:53:19:1b:09:4b:82:b2:89:26:7d:c7:6f:a0:02
  3609          Signature Algorithm: sha256WithRSAEncryption
  3610          Issuer: O = Acme Co
  3611          Validity
  3612              Not Before: Dec 21 16:59:27 2021 GMT
  3613              Not After : Dec 21 16:59:27 2022 GMT
  3614          Subject: O = Acme Co
  3615          Subject Public Key Info:
  3616              Public Key Algorithm: rsaEncryption
  3617                  RSA Public-Key: (2048 bit)
  3618                  Modulus:
  3619                      00:bf:17:16:d8:bc:29:9c:16:e5:76:b4:93:15:78:
  3620                      ad:6e:45:c5:4a:63:46:a1:b2:76:71:65:51:9c:14:
  3621                      c4:ea:74:13:e4:34:df:2f:2c:65:11:e8:56:52:69:
  3622                      11:f9:0e:fc:77:bb:63:a8:7c:1a:c6:a1:7b:6e:6c:
  3623                      e7:18:25:25:c9:e8:fb:06:7f:a2:a9:98:fe:2a:bc:
  3624                      8a:b3:75:b6:b8:7d:b6:c9:6b:29:08:32:22:10:cb:
  3625                      8d:d6:60:c8:83:ad:f5:58:91:d6:11:e8:55:56:fb:
  3626                      8f:a3:a2:9f:48:cb:79:e4:65:4a:8c:a6:52:64:9f:
  3627                      99:38:35:d4:d5:ac:6f:cf:a0:cb:42:8c:07:eb:21:
  3628                      17:31:3a:eb:91:7b:62:43:a4:75:5f:ef:a7:2f:94:
  3629                      f8:69:0b:d4:ec:09:e6:00:c0:8c:dd:07:63:0b:e4:
  3630                      77:aa:60:18:3c:a0:e0:ae:0a:ea:0e:52:3b:b4:fa:
  3631                      6a:30:1b:50:62:21:73:53:33:01:60:a1:6b:99:58:
  3632                      00:f3:77:c6:0f:46:19:ca:c2:5d:cd:f5:e2:52:4d:
  3633                      84:94:23:d3:32:2f:ae:5f:da:43:a1:19:95:d2:17:
  3634                      dd:49:14:b4:d9:48:1c:08:13:93:8e:d5:09:43:21:
  3635                      b6:ce:52:e8:87:bb:d2:60:0d:c6:4e:bf:c5:93:6a:
  3636                      c6:bf
  3637                  Exponent: 65537 (0x10001)
  3638          X509v3 extensions:
  3639              X509v3 Key Usage: critical
  3640                  Digital Signature, Key Encipherment
  3641              X509v3 Extended Key Usage:
  3642                  TLS Web Server Authentication
  3643              X509v3 Basic Constraints: critical
  3644                  CA:FALSE
  3645              X509v3 Subject Alternative Name:
  3646                  DNS:longOID.example
  3647              X509v3 Certificate Policies:
  3648                  Policy: 1.3.6.1.4.1.311.21.8.1492336001
  3649  
  3650      Signature Algorithm: sha256WithRSAEncryption
  3651           72:77:8b:de:48:fb:6d:9a:94:b1:be:d4:90:7d:4c:e6:d3:79:
  3652           fa:fb:fc:3e:d5:3d:e9:a0:ce:28:2b:2f:94:77:3f:87:f8:9c:
  3653           9f:91:1c:f3:f6:58:91:15:6b:24:b9:ca:ae:9f:ee:ca:c8:31:
  3654           db:1a:3d:bb:6b:83:6d:bc:81:8b:a1:79:d5:3e:bb:dd:93:fe:
  3655           35:3e:b7:99:e0:d6:eb:58:0c:fd:42:73:dc:49:da:e2:b7:ae:
  3656           15:ee:e6:cc:aa:ef:91:41:9a:18:46:8d:4a:39:65:a2:85:3c:
  3657           7f:0c:41:f8:0b:9c:e8:1f:35:36:60:8d:8c:e0:8e:18:b1:06:
  3658           57:d0:4e:c4:c3:cd:8f:6f:e7:76:02:52:da:03:43:61:2b:b3:
  3659           bf:19:fd:73:0d:6a:0b:b4:b6:cb:a9:6f:70:4e:53:2a:54:07:
  3660           b3:74:fd:85:49:57:5b:23:8d:8c:6b:53:2b:09:e8:41:a5:80:
  3661           3f:69:1b:11:d1:6b:13:35:2e:f9:d6:50:15:d9:91:38:42:43:
  3662           e9:17:af:67:d9:96:a4:d1:6a:4f:cc:b4:a7:8e:48:1f:00:72:
  3663           69:de:4d:f1:73:a4:47:12:67:e9:f9:07:3e:79:75:90:42:b8:
  3664           d4:b5:fd:d1:7e:35:04:f7:00:04:cf:f1:36:be:0f:27:81:1f:
  3665           a6:ba:88:6c
  3666  -----BEGIN CERTIFICATE-----
  3667  MIIDHTCCAgWgAwIBAgIRANq6UxkbCUuCsokmfcdvoAIwDQYJKoZIhvcNAQELBQAw
  3668  EjEQMA4GA1UEChMHQWNtZSBDbzAeFw0yMTEyMjExNjU5MjdaFw0yMjEyMjExNjU5
  3669  MjdaMBIxEDAOBgNVBAoTB0FjbWUgQ28wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw
  3670  ggEKAoIBAQC/FxbYvCmcFuV2tJMVeK1uRcVKY0ahsnZxZVGcFMTqdBPkNN8vLGUR
  3671  6FZSaRH5Dvx3u2OofBrGoXtubOcYJSXJ6PsGf6KpmP4qvIqzdba4fbbJaykIMiIQ
  3672  y43WYMiDrfVYkdYR6FVW+4+jop9Iy3nkZUqMplJkn5k4NdTVrG/PoMtCjAfrIRcx
  3673  OuuRe2JDpHVf76cvlPhpC9TsCeYAwIzdB2ML5HeqYBg8oOCuCuoOUju0+mowG1Bi
  3674  IXNTMwFgoWuZWADzd8YPRhnKwl3N9eJSTYSUI9MyL65f2kOhGZXSF91JFLTZSBwI
  3675  E5OO1QlDIbbOUuiHu9JgDcZOv8WTasa/AgMBAAGjbjBsMA4GA1UdDwEB/wQEAwIF
  3676  oDATBgNVHSUEDDAKBggrBgEFBQcDATAMBgNVHRMBAf8EAjAAMBoGA1UdEQQTMBGC
  3677  D2xvbmdPSUQuZXhhbXBsZTAbBgNVHSAEFDASMBAGDisGAQQBgjcVCIXHzPsBMA0G
  3678  CSqGSIb3DQEBCwUAA4IBAQByd4veSPttmpSxvtSQfUzm03n6+/w+1T3poM4oKy+U
  3679  dz+H+JyfkRzz9liRFWskucqun+7KyDHbGj27a4NtvIGLoXnVPrvdk/41PreZ4Nbr
  3680  WAz9QnPcSdrit64V7ubMqu+RQZoYRo1KOWWihTx/DEH4C5zoHzU2YI2M4I4YsQZX
  3681  0E7Ew82Pb+d2AlLaA0NhK7O/Gf1zDWoLtLbLqW9wTlMqVAezdP2FSVdbI42Ma1Mr
  3682  CehBpYA/aRsR0WsTNS751lAV2ZE4QkPpF69n2Zak0WpPzLSnjkgfAHJp3k3xc6RH
  3683  Emfp+Qc+eXWQQrjUtf3RfjUE9wAEz/E2vg8ngR+muohs
  3684  -----END CERTIFICATE-----`
  3685  
  3686  func TestLargeOID(t *testing.T) {
  3687  	// See Issue 49678.
  3688  	b, _ := pem.Decode([]byte(largeOIDPEM))
  3689  	if b == nil {
  3690  		t.Fatalf("couldn't decode test certificate")
  3691  	}
  3692  	_, err := ParseCertificate(b.Bytes)
  3693  	if err != nil {
  3694  		t.Fatalf("ParseCertificate to failed to parse certificate with large OID: %s", err)
  3695  	}
  3696  }
  3697  
  3698  const uniqueIDPEM = `-----BEGIN CERTIFICATE-----
  3699  MIIFsDCCBJigAwIBAgIILOyC1ydafZMwDQYJKoZIhvcNAQEFBQAwgY4xgYswgYgG
  3700  A1UEAx6BgABNAGkAYwByAG8AcwBvAGYAdAAgAEYAbwByAGUAZgByAG8AbgB0ACAA
  3701  VABNAEcAIABIAFQAVABQAFMAIABJAG4AcwBwAGUAYwB0AGkAbwBuACAAQwBlAHIA
  3702  dABpAGYAaQBjAGEAdABpAG8AbgAgAEEAdQB0AGgAbwByAGkAdAB5MB4XDTE0MDEx
  3703  ODAwNDEwMFoXDTE1MTExNTA5Mzc1NlowgZYxCzAJBgNVBAYTAklEMRAwDgYDVQQI
  3704  EwdqYWthcnRhMRIwEAYDVQQHEwlJbmRvbmVzaWExHDAaBgNVBAoTE3N0aG9ub3Jl
  3705  aG90ZWxyZXNvcnQxHDAaBgNVBAsTE3N0aG9ub3JlaG90ZWxyZXNvcnQxJTAjBgNV
  3706  BAMTHG1haWwuc3Rob25vcmVob3RlbHJlc29ydC5jb20wggEiMA0GCSqGSIb3DQEB
  3707  AQUAA4IBDwAwggEKAoIBAQCvuu0qpI+Ko2X84Twkf84cRD/rgp6vpgc5Ebejx/D4
  3708  PEVON5edZkazrMGocK/oQqIlRxx/lefponN/chlGcllcVVPWTuFjs8k+Aat6T1qp
  3709  4iXxZekAqX+U4XZMIGJD3PckPL6G2RQSlF7/LhGCsRNRdKpMWSTbou2Ma39g52Kf
  3710  gsl3SK/GwLiWpxpcSkNQD1hugguEIsQYLxbeNwpcheXZtxbBGguPzQ7rH8c5vuKU
  3711  BkMOzaiNKLzHbBdFSrua8KWwCJg76Vdq/q36O9GlW6YgG3i+A4pCJjXWerI1lWwX
  3712  Ktk5V+SvUHGey1bkDuZKJ6myMk2pGrrPWCT7jP7WskChAgMBAAGBCQBCr1dgEleo
  3713  cKOCAfswggH3MIHDBgNVHREEgbswgbiCHG1haWwuc3Rob25vcmVob3RlbHJlc29y
  3714  dC5jb22CIGFzaGNoc3ZyLnN0aG9ub3JlaG90ZWxyZXNvcnQuY29tgiRBdXRvRGlz
  3715  Y292ZXIuc3Rob25vcmVob3RlbHJlc29ydC5jb22CHEF1dG9EaXNjb3Zlci5ob3Rl
  3716  bHJlc29ydC5jb22CCEFTSENIU1ZSghdzdGhvbm9yZWhvdGVscmVzb3J0LmNvbYIP
  3717  aG90ZWxyZXNvcnQuY29tMCEGCSsGAQQBgjcUAgQUHhIAVwBlAGIAUwBlAHIAdgBl
  3718  AHIwHQYDVR0OBBYEFMAC3UR4FwAdGekbhMgnd6lMejtbMAsGA1UdDwQEAwIFoDAT
  3719  BgNVHSUEDDAKBggrBgEFBQcDATAJBgNVHRMEAjAAMIG/BgNVHQEEgbcwgbSAFGfF
  3720  6xihk+gJJ5TfwvtWe1UFnHLQoYGRMIGOMYGLMIGIBgNVBAMegYAATQBpAGMAcgBv
  3721  AHMAbwBmAHQAIABGAG8AcgBlAGYAcgBvAG4AdAAgAFQATQBHACAASABUAFQAUABT
  3722  ACAASQBuAHMAcABlAGMAdABpAG8AbgAgAEMAZQByAHQAaQBmAGkAYwBhAHQAaQBv
  3723  AG4AIABBAHUAdABoAG8AcgBpAHQAeYIIcKhXEmBXr0IwDQYJKoZIhvcNAQEFBQAD
  3724  ggEBABlSxyCMr3+ANr+WmPSjyN5YCJBgnS0IFCwJAzIYP87bcTye/U8eQ2+E6PqG
  3725  Q7Huj7nfHEw9qnGo+HNyPp1ad3KORzXDb54c6xEoi+DeuPzYHPbn4c3hlH49I0aQ
  3726  eWW2w4RslSWpLvO6Y7Lboyz2/Thk/s2kd4RHxkkWpH2ltPqJuYYg3X6oM5+gIFHJ
  3727  WGnh+ojZ5clKvS5yXh3Wkj78M6sb32KfcBk0Hx6NkCYPt60ODYmWtvqwtw6r73u5
  3728  TnTYWRNvo2svX69TriL+CkHY9O1Hkwf2It5zHl3gNiKTJVaak8AuEz/CKWZneovt
  3729  yYLwhUhg3PX5Co1VKYE+9TxloiE=
  3730  -----END CERTIFICATE-----`
  3731  
  3732  func TestParseUniqueID(t *testing.T) {
  3733  	b, _ := pem.Decode([]byte(uniqueIDPEM))
  3734  	if b == nil {
  3735  		t.Fatalf("couldn't decode test certificate")
  3736  	}
  3737  	cert, err := ParseCertificate(b.Bytes)
  3738  	if err != nil {
  3739  		t.Fatalf("ParseCertificate to failed to parse certificate with unique identifier id: %s", err)
  3740  	}
  3741  	if len(cert.Extensions) != 7 {
  3742  		t.Fatalf("unexpected number of extensions (probably because the extension section was not parsed): got %d, want 7", len(cert.Extensions))
  3743  	}
  3744  }
  3745  
  3746  func TestDisableSHA1ForCertOnly(t *testing.T) {
  3747  	t.Setenv("GODEBUG", "")
  3748  
  3749  	tmpl := &Certificate{
  3750  		SerialNumber:          big.NewInt(1),
  3751  		NotBefore:             time.Now().Add(-time.Hour),
  3752  		NotAfter:              time.Now().Add(time.Hour),
  3753  		SignatureAlgorithm:    SHA1WithRSA,
  3754  		BasicConstraintsValid: true,
  3755  		IsCA:                  true,
  3756  		KeyUsage:              KeyUsageCertSign | KeyUsageCRLSign,
  3757  	}
  3758  	certDER, err := CreateCertificate(rand.Reader, tmpl, tmpl, rsaPrivateKey.Public(), rsaPrivateKey)
  3759  	if err != nil {
  3760  		t.Fatalf("failed to generate test cert: %s", err)
  3761  	}
  3762  	cert, err := ParseCertificate(certDER)
  3763  	if err != nil {
  3764  		t.Fatalf("failed to parse test cert: %s", err)
  3765  	}
  3766  
  3767  	err = cert.CheckSignatureFrom(cert)
  3768  	if err == nil {
  3769  		t.Error("expected CheckSignatureFrom to fail")
  3770  	} else if _, ok := err.(InsecureAlgorithmError); !ok {
  3771  		t.Errorf("expected InsecureAlgorithmError error, got %T", err)
  3772  	}
  3773  
  3774  	crlDER, err := CreateRevocationList(rand.Reader, &RevocationList{
  3775  		SignatureAlgorithm: SHA1WithRSA,
  3776  		Number:             big.NewInt(1),
  3777  		ThisUpdate:         time.Now().Add(-time.Hour),
  3778  		NextUpdate:         time.Now().Add(time.Hour),
  3779  	}, cert, rsaPrivateKey)
  3780  	if err != nil {
  3781  		t.Fatalf("failed to generate test CRL: %s", err)
  3782  	}
  3783  	crl, err := ParseRevocationList(crlDER)
  3784  	if err != nil {
  3785  		t.Fatalf("failed to parse test CRL: %s", err)
  3786  	}
  3787  
  3788  	if err = crl.CheckSignatureFrom(cert); err != nil {
  3789  		t.Errorf("unexpected error: %s", err)
  3790  	}
  3791  
  3792  	// This is an unrelated OCSP response, which will fail signature verification
  3793  	// but shouldn't return an InsecureAlgorithmError, since SHA1 should be allowed
  3794  	// for OCSP.
  3795  	ocspTBSHex := "30819fa2160414884451ff502a695e2d88f421bad90cf2cecbea7c180f32303133303631383037323434335a30743072304a300906052b0e03021a0500041448b60d38238df8456e4ee5843ea394111802979f0414884451ff502a695e2d88f421bad90cf2cecbea7c021100f78b13b946fc9635d8ab49de9d2148218000180f32303133303631383037323434335aa011180f32303133303632323037323434335a"
  3796  	ocspTBS, err := hex.DecodeString(ocspTBSHex)
  3797  	if err != nil {
  3798  		t.Fatalf("failed to decode OCSP response TBS hex: %s", err)
  3799  	}
  3800  
  3801  	err = cert.CheckSignature(SHA1WithRSA, ocspTBS, nil)
  3802  	if err != rsa.ErrVerification {
  3803  		t.Errorf("unexpected error: %s", err)
  3804  	}
  3805  }
  3806  
  3807  func TestParseRevocationList(t *testing.T) {
  3808  	derBytes := fromBase64(derCRLBase64)
  3809  	certList, err := ParseRevocationList(derBytes)
  3810  	if err != nil {
  3811  		t.Errorf("error parsing: %s", err)
  3812  		return
  3813  	}
  3814  	numCerts := len(certList.RevokedCertificateEntries)
  3815  	numCertsDeprecated := len(certList.RevokedCertificateEntries)
  3816  	expected := 88
  3817  	if numCerts != expected || numCertsDeprecated != expected {
  3818  		t.Errorf("bad number of revoked certificates. got: %d want: %d", numCerts, expected)
  3819  	}
  3820  }
  3821  
  3822  func TestRevocationListCheckSignatureFrom(t *testing.T) {
  3823  	goodKey, err := ecdsa.GenerateKey(elliptic.P224(), rand.Reader)
  3824  	if err != nil {
  3825  		t.Fatalf("failed to generate test key: %s", err)
  3826  	}
  3827  	badKey, err := ecdsa.GenerateKey(elliptic.P224(), rand.Reader)
  3828  	if err != nil {
  3829  		t.Fatalf("failed to generate test key: %s", err)
  3830  	}
  3831  	tests := []struct {
  3832  		name   string
  3833  		issuer *Certificate
  3834  		err    string
  3835  	}{
  3836  		{
  3837  			name: "valid",
  3838  			issuer: &Certificate{
  3839  				Version:               3,
  3840  				BasicConstraintsValid: true,
  3841  				IsCA:                  true,
  3842  				PublicKeyAlgorithm:    ECDSA,
  3843  				PublicKey:             goodKey.Public(),
  3844  			},
  3845  		},
  3846  		{
  3847  			name: "valid, key usage set",
  3848  			issuer: &Certificate{
  3849  				Version:               3,
  3850  				BasicConstraintsValid: true,
  3851  				IsCA:                  true,
  3852  				PublicKeyAlgorithm:    ECDSA,
  3853  				PublicKey:             goodKey.Public(),
  3854  				KeyUsage:              KeyUsageCRLSign,
  3855  			},
  3856  		},
  3857  		{
  3858  			name: "invalid issuer, wrong key usage",
  3859  			issuer: &Certificate{
  3860  				Version:               3,
  3861  				BasicConstraintsValid: true,
  3862  				IsCA:                  true,
  3863  				PublicKeyAlgorithm:    ECDSA,
  3864  				PublicKey:             goodKey.Public(),
  3865  				KeyUsage:              KeyUsageCertSign,
  3866  			},
  3867  			err: "x509: invalid signature: parent certificate cannot sign this kind of certificate",
  3868  		},
  3869  		{
  3870  			name: "invalid issuer, no basic constraints/ca",
  3871  			issuer: &Certificate{
  3872  				Version:            3,
  3873  				PublicKeyAlgorithm: ECDSA,
  3874  				PublicKey:          goodKey.Public(),
  3875  			},
  3876  			err: "x509: invalid signature: parent certificate cannot sign this kind of certificate",
  3877  		},
  3878  		{
  3879  			name: "invalid issuer, unsupported public key type",
  3880  			issuer: &Certificate{
  3881  				Version:               3,
  3882  				BasicConstraintsValid: true,
  3883  				IsCA:                  true,
  3884  				PublicKeyAlgorithm:    UnknownPublicKeyAlgorithm,
  3885  				PublicKey:             goodKey.Public(),
  3886  			},
  3887  			err: "x509: cannot verify signature: algorithm unimplemented",
  3888  		},
  3889  		{
  3890  			name: "wrong key",
  3891  			issuer: &Certificate{
  3892  				Version:               3,
  3893  				BasicConstraintsValid: true,
  3894  				IsCA:                  true,
  3895  				PublicKeyAlgorithm:    ECDSA,
  3896  				PublicKey:             badKey.Public(),
  3897  			},
  3898  			err: "x509: ECDSA verification failure",
  3899  		},
  3900  	}
  3901  
  3902  	crlIssuer := &Certificate{
  3903  		BasicConstraintsValid: true,
  3904  		IsCA:                  true,
  3905  		PublicKeyAlgorithm:    ECDSA,
  3906  		PublicKey:             goodKey.Public(),
  3907  		KeyUsage:              KeyUsageCRLSign,
  3908  		SubjectKeyId:          []byte{1, 2, 3},
  3909  	}
  3910  	for _, tc := range tests {
  3911  		t.Run(tc.name, func(t *testing.T) {
  3912  			crlDER, err := CreateRevocationList(rand.Reader, &RevocationList{Number: big.NewInt(1)}, crlIssuer, goodKey)
  3913  			if err != nil {
  3914  				t.Fatalf("failed to generate CRL: %s", err)
  3915  			}
  3916  			crl, err := ParseRevocationList(crlDER)
  3917  			if err != nil {
  3918  				t.Fatalf("failed to parse test CRL: %s", err)
  3919  			}
  3920  			err = crl.CheckSignatureFrom(tc.issuer)
  3921  			if err != nil && err.Error() != tc.err {
  3922  				t.Errorf("unexpected error: got %s, want %s", err, tc.err)
  3923  			} else if err == nil && tc.err != "" {
  3924  				t.Errorf("CheckSignatureFrom did not fail: want %s", tc.err)
  3925  			}
  3926  		})
  3927  	}
  3928  }
  3929  
  3930  func TestOmitEmptyExtensions(t *testing.T) {
  3931  	k, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
  3932  	if err != nil {
  3933  		t.Fatal(err)
  3934  	}
  3935  	tmpl := &Certificate{
  3936  		SerialNumber: big.NewInt(1),
  3937  		Subject: pkix.Name{
  3938  			CommonName: ":)",
  3939  		},
  3940  		NotAfter:  time.Now().Add(time.Hour),
  3941  		NotBefore: time.Now().Add(-time.Hour),
  3942  	}
  3943  	der, err := CreateCertificate(rand.Reader, tmpl, tmpl, k.Public(), k)
  3944  	if err != nil {
  3945  		t.Fatal(err)
  3946  	}
  3947  
  3948  	emptyExtSeq := []byte{0xA3, 0x02, 0x30, 0x00}
  3949  	if bytes.Contains(der, emptyExtSeq) {
  3950  		t.Error("DER encoding contains the an empty extensions SEQUENCE")
  3951  	}
  3952  }
  3953  
  3954  var negativeSerialCert = `-----BEGIN CERTIFICATE-----
  3955  MIIBBTCBraADAgECAgH/MAoGCCqGSM49BAMCMA0xCzAJBgNVBAMTAjopMB4XDTIy
  3956  MDQxNDIzNTYwNFoXDTIyMDQxNTAxNTYwNFowDTELMAkGA1UEAxMCOikwWTATBgcq
  3957  hkjOPQIBBggqhkjOPQMBBwNCAAQ9ezsIsj+q17K87z/PXE/rfGRN72P/Wyn5d6oo
  3958  5M0ZbSatuntMvfKdX79CQxXAxN4oXk3Aov4jVSG12AcDI8ShMAoGCCqGSM49BAMC
  3959  A0cAMEQCIBzfBU5eMPT6m5lsR6cXaJILpAaiD9YxOl4v6dT3rzEjAiBHmjnHmAss
  3960  RqUAyJKFzqZxOlK2q4j2IYnuj5+LrLGbQA==
  3961  -----END CERTIFICATE-----`
  3962  
  3963  func TestParseNegativeSerial(t *testing.T) {
  3964  	pemBlock, _ := pem.Decode([]byte(negativeSerialCert))
  3965  	_, err := ParseCertificate(pemBlock.Bytes)
  3966  	if err == nil {
  3967  		t.Fatal("parsed certificate with negative serial")
  3968  	}
  3969  }
  3970  
  3971  func TestCreateNegativeSerial(t *testing.T) {
  3972  	k, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
  3973  	if err != nil {
  3974  		t.Fatal(err)
  3975  	}
  3976  	tmpl := &Certificate{
  3977  		SerialNumber: big.NewInt(-1),
  3978  		Subject: pkix.Name{
  3979  			CommonName: ":)",
  3980  		},
  3981  		NotAfter:  time.Now().Add(time.Hour),
  3982  		NotBefore: time.Now().Add(-time.Hour),
  3983  	}
  3984  	expectedErr := "x509: serial number must be positive"
  3985  	_, err = CreateCertificate(rand.Reader, tmpl, tmpl, k.Public(), k)
  3986  	if err == nil || err.Error() != expectedErr {
  3987  		t.Errorf("CreateCertificate returned unexpected error: want %q, got %q", expectedErr, err)
  3988  	}
  3989  }
  3990  
  3991  const dupExtCert = `-----BEGIN CERTIFICATE-----
  3992  MIIBrjCCARegAwIBAgIBATANBgkqhkiG9w0BAQsFADAPMQ0wCwYDVQQDEwR0ZXN0
  3993  MCIYDzAwMDEwMTAxMDAwMDAwWhgPMDAwMTAxMDEwMDAwMDBaMA8xDTALBgNVBAMT
  3994  BHRlc3QwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMiFchnHms9l9NninAIz
  3995  SkY9acwl9Bk2AtmJrNCenFpiA17AcOO5q8DJYwdXi6WPKlVgcyH+ysW8XMWkq+CP
  3996  yhtF/+LMzl9odaUF2iUy3vgTC5gxGLWH5URVssx21Und2Pm2f4xyou5IVxbS9dxy
  3997  jLvV9PEY9BIb0H+zFthjhihDAgMBAAGjFjAUMAgGAioDBAIFADAIBgIqAwQCBQAw
  3998  DQYJKoZIhvcNAQELBQADgYEAlhQ4TQQKIQ8GUyzGiN/75TCtQtjhMGemxc0cNgre
  3999  d9rmm4DjydH0t7/sMCB56lQrfhJNplguzsbjFW4l245KbNKHfLiqwEGUgZjBNKur
  4000  ot6qX/skahLtt0CNOaFIge75HVKe/69OrWQGdp18dkay/KS4Glu8YMKIjOhfrUi1
  4001  NZA=
  4002  -----END CERTIFICATE-----`
  4003  
  4004  func TestDuplicateExtensionsCert(t *testing.T) {
  4005  	b, _ := pem.Decode([]byte(dupExtCert))
  4006  	if b == nil {
  4007  		t.Fatalf("couldn't decode test certificate")
  4008  	}
  4009  	_, err := ParseCertificate(b.Bytes)
  4010  	if err == nil {
  4011  		t.Fatal("ParseCertificate should fail when parsing certificate with duplicate extensions")
  4012  	}
  4013  }
  4014  
  4015  const dupExtCSR = `-----BEGIN CERTIFICATE REQUEST-----
  4016  MIIBczCB3QIBADAPMQ0wCwYDVQQDEwR0ZXN0MIGfMA0GCSqGSIb3DQEBAQUAA4GN
  4017  ADCBiQKBgQC5PbxMGVJ8aLF9lq/EvGObXTRMB7ieiZL9N+DJZg1n/ECCnZLIvYrr
  4018  ZmmDV7YZsClgxKGfjJB0RQFFyZElFM9EfHEs8NJdidDKCRdIhDXQWRyhXKevHvdm
  4019  CQNKzUeoxvdHpU/uscSkw6BgUzPyLyTx9A6ye2ix94z8Y9hGOBO2DQIDAQABoCUw
  4020  IwYJKoZIhvcNAQkOMRYwFDAIBgIqAwQCBQAwCAYCKgMEAgUAMA0GCSqGSIb3DQEB
  4021  CwUAA4GBAHROEsE7URk1knXmBnQtIHwoq663vlMcX3Hes58pUy020rWP8QkocA+X
  4022  VF18/phg3p5ILlS4fcbbP2bEeV0pePo2k00FDPsJEKCBAX2LKxbU7Vp2OuV2HM2+
  4023  VLOVx0i+/Q7fikp3hbN1JwuMTU0v2KL/IKoUcZc02+5xiYrnOIt5
  4024  -----END CERTIFICATE REQUEST-----`
  4025  
  4026  func TestDuplicateExtensionsCSR(t *testing.T) {
  4027  	b, _ := pem.Decode([]byte(dupExtCSR))
  4028  	if b == nil {
  4029  		t.Fatalf("couldn't decode test CSR")
  4030  	}
  4031  	_, err := ParseCertificateRequest(b.Bytes)
  4032  	if err == nil {
  4033  		t.Fatal("ParseCertificateRequest should fail when parsing CSR with duplicate extensions")
  4034  	}
  4035  }
  4036  
  4037  const dupAttCSR = `-----BEGIN CERTIFICATE REQUEST-----
  4038  MIIBbDCB1gIBADAPMQ0wCwYDVQQDEwR0ZXN0MIGfMA0GCSqGSIb3DQEBAQUAA4GN
  4039  ADCBiQKBgQCj5Po3PKO/JNuxr+B+WNfMIzqqYztdlv+mTQhT0jOR5rTkUvxeeHH8
  4040  YclryES2dOISjaUOTmOAr5GQIIdQl4Ql33Cp7ZR/VWcRn+qvTak0Yow+xVsDo0n4
  4041  7IcvvP6CJ7FRoYBUakVczeXLxCjLwdyK16VGJM06eRzDLykPxpPwLQIDAQABoB4w
  4042  DQYCKgMxBwwFdGVzdDEwDQYCKgMxBwwFdGVzdDIwDQYJKoZIhvcNAQELBQADgYEA
  4043  UJ8hsHxtnIeqb2ufHnQFJO+wEJhx2Uxm/BTuzHOeffuQkwATez4skZ7SlX9exgb7
  4044  6jRMRilqb4F7f8w+uDoqxRrA9zc8mwY16zPsyBhRet+ZGbj/ilgvGmtZ21qZZ/FU
  4045  0pJFJIVLM3l49Onr5uIt5+hCWKwHlgE0nGpjKLR3cMg=
  4046  -----END CERTIFICATE REQUEST-----`
  4047  
  4048  func TestDuplicateAttributesCSR(t *testing.T) {
  4049  	b, _ := pem.Decode([]byte(dupAttCSR))
  4050  	if b == nil {
  4051  		t.Fatalf("couldn't decode test CSR")
  4052  	}
  4053  	_, err := ParseCertificateRequest(b.Bytes)
  4054  	if err != nil {
  4055  		t.Fatal("ParseCertificateRequest should succeed when parsing CSR with duplicate attributes")
  4056  	}
  4057  }
  4058  
  4059  func TestCertificateOIDPoliciesGODEBUG(t *testing.T) {
  4060  	t.Setenv("GODEBUG", "x509usepolicies=0")
  4061  
  4062  	template := Certificate{
  4063  		SerialNumber:      big.NewInt(1),
  4064  		Subject:           pkix.Name{CommonName: "Cert"},
  4065  		NotBefore:         time.Unix(1000, 0),
  4066  		NotAfter:          time.Unix(100000, 0),
  4067  		PolicyIdentifiers: []asn1.ObjectIdentifier{[]int{1, 2, 3}},
  4068  	}
  4069  
  4070  	var expectPolicyIdentifiers = []asn1.ObjectIdentifier{
  4071  		[]int{1, 2, 3},
  4072  	}
  4073  
  4074  	var expectPolicies = []OID{
  4075  		mustNewOIDFromInts([]uint64{1, 2, 3}),
  4076  	}
  4077  
  4078  	certDER, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4079  	if err != nil {
  4080  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4081  	}
  4082  
  4083  	cert, err := ParseCertificate(certDER)
  4084  	if err != nil {
  4085  		t.Fatalf("ParseCertificate() unexpected error: %v", err)
  4086  	}
  4087  
  4088  	if !slices.EqualFunc(cert.PolicyIdentifiers, expectPolicyIdentifiers, slices.Equal) {
  4089  		t.Errorf("cert.PolicyIdentifiers = %v, want: %v", cert.PolicyIdentifiers, expectPolicyIdentifiers)
  4090  	}
  4091  
  4092  	if !slices.EqualFunc(cert.Policies, expectPolicies, OID.Equal) {
  4093  		t.Errorf("cert.Policies = %v, want: %v", cert.Policies, expectPolicies)
  4094  	}
  4095  }
  4096  
  4097  func TestCertificatePolicies(t *testing.T) {
  4098  	if x509usepolicies.Value() == "0" {
  4099  		t.Skip("test relies on default x509usepolicies GODEBUG")
  4100  	}
  4101  
  4102  	template := Certificate{
  4103  		SerialNumber:      big.NewInt(1),
  4104  		Subject:           pkix.Name{CommonName: "Cert"},
  4105  		NotBefore:         time.Unix(1000, 0),
  4106  		NotAfter:          time.Unix(100000, 0),
  4107  		PolicyIdentifiers: []asn1.ObjectIdentifier{[]int{1, 2, 3}},
  4108  		Policies:          []OID{mustNewOIDFromInts([]uint64{1, 2, math.MaxUint32 + 1})},
  4109  	}
  4110  
  4111  	expectPolicies := []OID{mustNewOIDFromInts([]uint64{1, 2, math.MaxUint32 + 1})}
  4112  	certDER, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4113  	if err != nil {
  4114  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4115  	}
  4116  
  4117  	cert, err := ParseCertificate(certDER)
  4118  	if err != nil {
  4119  		t.Fatalf("ParseCertificate() unexpected error: %v", err)
  4120  	}
  4121  
  4122  	if !slices.EqualFunc(cert.Policies, expectPolicies, OID.Equal) {
  4123  		t.Errorf("cert.Policies = %v, want: %v", cert.Policies, expectPolicies)
  4124  	}
  4125  
  4126  	t.Setenv("GODEBUG", "x509usepolicies=1")
  4127  	expectPolicies = []OID{mustNewOIDFromInts([]uint64{1, 2, math.MaxUint32 + 1})}
  4128  
  4129  	certDER, err = CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4130  	if err != nil {
  4131  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4132  	}
  4133  
  4134  	cert, err = ParseCertificate(certDER)
  4135  	if err != nil {
  4136  		t.Fatalf("ParseCertificate() unexpected error: %v", err)
  4137  	}
  4138  
  4139  	if !slices.EqualFunc(cert.Policies, expectPolicies, OID.Equal) {
  4140  		t.Errorf("cert.Policies = %v, want: %v", cert.Policies, expectPolicies)
  4141  	}
  4142  }
  4143  
  4144  func TestGob(t *testing.T) {
  4145  	// Test that gob does not reject Certificate.
  4146  	// See go.dev/issue/65633.
  4147  	cert := new(Certificate)
  4148  	err := gob.NewEncoder(io.Discard).Encode(cert)
  4149  	if err != nil {
  4150  		t.Fatal(err)
  4151  	}
  4152  }
  4153  
  4154  func TestRejectCriticalAKI(t *testing.T) {
  4155  	template := Certificate{
  4156  		SerialNumber: big.NewInt(1),
  4157  		Subject:      pkix.Name{CommonName: "Cert"},
  4158  		NotBefore:    time.Unix(1000, 0),
  4159  		NotAfter:     time.Unix(100000, 0),
  4160  		ExtraExtensions: []pkix.Extension{
  4161  			{
  4162  				Id:       asn1.ObjectIdentifier{2, 5, 29, 35},
  4163  				Critical: true,
  4164  				Value:    []byte{1, 2, 3},
  4165  			},
  4166  		},
  4167  	}
  4168  	certDER, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4169  	if err != nil {
  4170  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4171  	}
  4172  	expectedErr := "x509: authority key identifier incorrectly marked critical"
  4173  	_, err = ParseCertificate(certDER)
  4174  	if err == nil || err.Error() != expectedErr {
  4175  		t.Fatalf("ParseCertificate() unexpected error: %v, want: %s", err, expectedErr)
  4176  	}
  4177  }
  4178  
  4179  func TestRejectCriticalAIA(t *testing.T) {
  4180  	template := Certificate{
  4181  		SerialNumber: big.NewInt(1),
  4182  		Subject:      pkix.Name{CommonName: "Cert"},
  4183  		NotBefore:    time.Unix(1000, 0),
  4184  		NotAfter:     time.Unix(100000, 0),
  4185  		ExtraExtensions: []pkix.Extension{
  4186  			{
  4187  				Id:       asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 1, 1},
  4188  				Critical: true,
  4189  				Value:    []byte{1, 2, 3},
  4190  			},
  4191  		},
  4192  	}
  4193  	certDER, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4194  	if err != nil {
  4195  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4196  	}
  4197  	expectedErr := "x509: authority info access incorrectly marked critical"
  4198  	_, err = ParseCertificate(certDER)
  4199  	if err == nil || err.Error() != expectedErr {
  4200  		t.Fatalf("ParseCertificate() unexpected error: %v, want: %s", err, expectedErr)
  4201  	}
  4202  }
  4203  
  4204  func TestRejectCriticalSKI(t *testing.T) {
  4205  	template := Certificate{
  4206  		SerialNumber: big.NewInt(1),
  4207  		Subject:      pkix.Name{CommonName: "Cert"},
  4208  		NotBefore:    time.Unix(1000, 0),
  4209  		NotAfter:     time.Unix(100000, 0),
  4210  		ExtraExtensions: []pkix.Extension{
  4211  			{
  4212  				Id:       asn1.ObjectIdentifier{2, 5, 29, 14},
  4213  				Critical: true,
  4214  				Value:    []byte{1, 2, 3},
  4215  			},
  4216  		},
  4217  	}
  4218  	certDER, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4219  	if err != nil {
  4220  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4221  	}
  4222  	expectedErr := "x509: subject key identifier incorrectly marked critical"
  4223  	_, err = ParseCertificate(certDER)
  4224  	if err == nil || err.Error() != expectedErr {
  4225  		t.Fatalf("ParseCertificate() unexpected error: %v, want: %s", err, expectedErr)
  4226  	}
  4227  }
  4228  
  4229  type messageSigner struct{}
  4230  
  4231  func (ms *messageSigner) Public() crypto.PublicKey { return rsaPrivateKey.Public() }
  4232  
  4233  func (ms *messageSigner) Sign(rand io.Reader, digest []byte, opts crypto.SignerOpts) (signature []byte, err error) {
  4234  	return nil, errors.New("unimplemented")
  4235  }
  4236  
  4237  func (ms *messageSigner) SignMessage(rand io.Reader, msg []byte, opts crypto.SignerOpts) (signature []byte, err error) {
  4238  	if _, ok := opts.(*rsa.PSSOptions); ok {
  4239  		return nil, errors.New("PSSOptions passed instead of hash")
  4240  	}
  4241  	h := opts.HashFunc().New()
  4242  	h.Write(msg)
  4243  	tbs := h.Sum(nil)
  4244  	return rsa.SignPKCS1v15(rand, rsaPrivateKey, opts.HashFunc(), tbs)
  4245  }
  4246  
  4247  func TestMessageSigner(t *testing.T) {
  4248  	template := Certificate{
  4249  		SignatureAlgorithm:    SHA256WithRSA,
  4250  		SerialNumber:          big.NewInt(1),
  4251  		Subject:               pkix.Name{CommonName: "Cert"},
  4252  		NotBefore:             time.Unix(1000, 0),
  4253  		NotAfter:              time.Unix(100000, 0),
  4254  		BasicConstraintsValid: true,
  4255  		IsCA:                  true,
  4256  	}
  4257  	certDER, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), &messageSigner{})
  4258  	if err != nil {
  4259  		t.Fatalf("CreateCertificate failed: %s", err)
  4260  	}
  4261  	cert, err := ParseCertificate(certDER)
  4262  	if err != nil {
  4263  		t.Fatalf("ParseCertificate failed: %s", err)
  4264  	}
  4265  	if err := cert.CheckSignatureFrom(cert); err != nil {
  4266  		t.Fatalf("CheckSignatureFrom failed: %s", err)
  4267  	}
  4268  }
  4269  
  4270  func TestCreateCertificateNegativeMaxPathLength(t *testing.T) {
  4271  	template := Certificate{
  4272  		SerialNumber:          big.NewInt(1),
  4273  		Subject:               pkix.Name{CommonName: "TEST"},
  4274  		NotBefore:             time.Unix(1000, 0),
  4275  		NotAfter:              time.Unix(100000, 0),
  4276  		BasicConstraintsValid: true,
  4277  		IsCA:                  true,
  4278  
  4279  		// CreateCertificate treats -1 in the same way as: MaxPathLen == 0 && MaxPathLenZero == false.
  4280  		MaxPathLen: -1,
  4281  	}
  4282  
  4283  	_, err := CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4284  	if err != nil {
  4285  		t.Fatalf("CreateCertificate() unexpected error: %v", err)
  4286  	}
  4287  
  4288  	template.MaxPathLen = -2
  4289  	_, err = CreateCertificate(rand.Reader, &template, &template, rsaPrivateKey.Public(), rsaPrivateKey)
  4290  	if err == nil || err.Error() != "x509: invalid MaxPathLen, must be greater or equal to -1" {
  4291  		t.Fatalf(`CreateCertificate() = %v; want = "x509: invalid MaxPathLen, must be greater or equal to -1"`, err)
  4292  	}
  4293  }
  4294  
  4295  func TestEKUOIDS(t *testing.T) {
  4296  	for _, eku := range extKeyUsageOIDs {
  4297  		oid := eku.extKeyUsage.OID()
  4298  		if !oid.EqualASN1OID(eku.oid) {
  4299  			t.Errorf("extKeyUsage %v: expected OID %v, got %v", eku.extKeyUsage, eku.oid, oid)
  4300  		}
  4301  	}
  4302  }
  4303  

View as plain text